[HttpClient] Check satus code before decoding in TraceableResponse::toArray()

chalasr · chalasr · commit c4f2d202fd4f · 2020-11-03T21:17:14.000+01:00
diff --git a/src/Symfony/Component/HttpClient/Response/TraceableResponse.php b/src/Symfony/Component/HttpClient/Response/TraceableResponse.php
@@ -16,6 +16,8 @@
 use Symfony\Component\HttpClient\Exception\ServerException;
 use Symfony\Component\HttpClient\TraceableHttpClient;
 use Symfony\Contracts\HttpClient\Exception\ClientExceptionInterface;
+use Symfony\Contracts\HttpClient\Exception\DecodingExceptionInterface;
+use Symfony\Contracts\HttpClient\Exception\HttpExceptionInterface;
 use Symfony\Contracts\HttpClient\Exception\RedirectionExceptionInterface;
 use Symfony\Contracts\HttpClient\Exception\ServerExceptionInterface;
 use Symfony\Contracts\HttpClient\Exception\TransportExceptionInterface;
@@ -52,24 +54,24 @@ public function getHeaders(bool $throw = true): array
 
     public function getContent(bool $throw = true): string
     {
-        $this->content = $this->response->getContent(false);
-
-        if ($throw) {
-            $this->checkStatusCode($this->response->getStatusCode());
+        try {
+            return $this->content = $this->response->getContent(false);
+        } finally {
+            if ($throw) {
+                $this->checkStatusCode($this->response->getStatusCode());
+            }
         }
-
-        return $this->content;
     }
 
     public function toArray(bool $throw = true): array
     {
-        $this->content = $this->response->toArray(false);
-
-        if ($throw) {
-            $this->checkStatusCode($this->response->getStatusCode());
+        try {
+            return $this->content = $this->response->toArray(false);
+        } finally {
+            if ($throw) {
+                $this->checkStatusCode($this->response->getStatusCode());
+            }
         }
-
-        return $this->content;
     }
 
     public function cancel(): void
diff --git a/src/Symfony/Component/HttpClient/Tests/TraceableHttpClientTest.php b/src/Symfony/Component/HttpClient/Tests/TraceableHttpClientTest.php
@@ -16,6 +16,7 @@
 use Symfony\Component\HttpClient\NativeHttpClient;
 use Symfony\Component\HttpClient\Response\MockResponse;
 use Symfony\Component\HttpClient\TraceableHttpClient;
+use Symfony\Contracts\HttpClient\Exception\ClientExceptionInterface;
 use Symfony\Contracts\HttpClient\HttpClientInterface;
 use Symfony\Contracts\HttpClient\Test\TestHttpServer;
 
@@ -100,4 +101,16 @@ public function testStream()
         $this->assertGreaterThan(1, \count($chunks));
         $this->assertSame('Symfony is awesome!', implode('', $chunks));
     }
+
+    public function testToArrayChecksStatusCodeBeforeDecoding()
+    {
+        $this->expectException(ClientExceptionInterface::class);
+
+        $sut = new TraceableHttpClient(new MockHttpClient($responseFactory = function (): MockResponse {
+            return new MockResponse('Errored.', ['http_code' => 400]);
+        }));
+
+        $response = $sut->request('GET', 'https://example.com/foo/bar');
+        $response->toArray();
+    }
 }
