bug #47335 [Security] [AbstractToken] getUserIdentifier() must return a string (mpiot)

fabpot · fabpot · commit c616e2cff72d · 2022-08-19T15:30:35.000+02:00
This PR was submitted for the 6.2 branch but it was merged into the 6.0 branch instead. Discussion ---------- [Security] [AbstractToken] getUserIdentifier() must return a string | Q | A | ------------- | --- | Branch? | 6.1 | Bug fix? | yes | New feature? | no | Deprecations? | no | Tickets | | License | MIT | Doc PR | Fix the `getUserIdentifier()` method from Symfony\Component\Security\Core\Authentication\Token\AbstractToken, he method must return a string, but based on a nullable UserInterface object. Commits ------- 2987d58 [Security][AbstractToken] getUserIdentifier() must return a string
diff --git a/src/Symfony/Component/Security/Core/Authentication/Token/AbstractToken.php b/src/Symfony/Component/Security/Core/Authentication/Token/AbstractToken.php
@@ -48,7 +48,7 @@ public function getRoleNames(): array
 
     public function getUserIdentifier(): string
     {
-        return $this->user->getUserIdentifier();
+        return $this->user ? $this->user->getUserIdentifier() : '';
     }
 
     /**

Original file line number	Diff line number	Diff line change
`@@ -48,7 +48,7 @@ public function getRoleNames(): array`
`48`	`48`
`49`	`49`	`public function getUserIdentifier(): string`
`50`	`50`	`{`
`51`		`- return $this->user->getUserIdentifier();`
	`51`	`+ return $this->user ? $this->user->getUserIdentifier() : '';`
`52`	`52`	`}`
`53`	`53`
`54`	`54`	`/**`