fix streamedresponse

dunglas · dunglas · commit c8caf02209a8 · 2023-03-11T10:49:23.000+01:00
diff --git a/src/Symfony/Component/HttpFoundation/Response.php b/src/Symfony/Component/HttpFoundation/Response.php
@@ -212,7 +212,7 @@ class Response
     ];
 
     /**
-     * Tracks headers already sent in informational responses
+     * Tracks headers already sent in informational responses.
      */
     private array $sentHeaders;
 
diff --git a/src/Symfony/Component/HttpFoundation/StreamedResponse.php b/src/Symfony/Component/HttpFoundation/StreamedResponse.php
@@ -69,9 +69,12 @@ public function sendHeaders(/* ?int $statusCode = null */): static
             return $this;
         }
 
-        $this->headersSent = true;
+        $statusCode = \func_num_args() > 0 ? func_get_arg(0) : null;
+        if ($statusCode < 100 || $statusCode >= 200) {
+            $this->headersSent = true;
+        }
 
-        return parent::sendHeaders(...\func_get_args());
+        return parent::sendHeaders($statusCode);
     }
 
     /**
diff --git a/src/Symfony/Component/HttpFoundation/Tests/StreamedResponseTest.php b/src/Symfony/Component/HttpFoundation/Tests/StreamedResponseTest.php
@@ -124,4 +124,15 @@ public function testSetNotModified()
         $string = ob_get_clean();
         $this->assertEmpty($string);
     }
+
+    public function testSendInformationalResponse()
+    {
+        $response = new StreamedResponse();
+        $response->sendHeaders(103);
+
+        // Informational responses must not override the main status code
+        $this->assertSame(200, $response->getStatusCode());
+
+        $response->sendHeaders();
+    }
 }

Original file line number	Diff line number	Diff line change
`@@ -69,9 +69,12 @@ public function sendHeaders(/* ?int $statusCode = null */): static`
`69`	`69`	`return $this;`
`70`	`70`	`}`
`71`	`71`
`72`		`- $this->headersSent = true;`
	`72`	`+ $statusCode = \func_num_args() > 0 ? func_get_arg(0) : null;`
	`73`	`+ if ($statusCode < 100 \|\| $statusCode >= 200) {`
	`74`	`+ $this->headersSent = true;`
	`75`	`+ }`
`73`	`76`
`74`		`- return parent::sendHeaders(...\func_get_args());`
	`77`	`+ return parent::sendHeaders($statusCode);`
`75`	`78`	`}`
`76`	`79`
`77`	`80`	`/**`