bug #51612 [Security] Fix for TraceableAuthenticator debug when no Auth (PhilETaylor)

fabpot · fabpot · commit cae4ccd47519 · 2023-09-10T19:11:10.000+02:00
This PR was merged into the 6.4 branch. Discussion ---------- [Security] Fix for TraceableAuthenticator debug when no Auth | Q | A | ------------- | --- | Branch? | 6.4 | Bug fix? | yes | New feature? | no  | Deprecations? | no  | Tickets | Fix #51585 (comment) | License | MIT Fixes regression in PR #51585 and adds unit test ![image](https://github.com/symfony/symfony/assets/400092/8645c3c4-1827-4dce-83b6-a1cdace8dfb1) Commits ------- a9d36a5 Fix for TraceableAuthenticator debug when no Auth
diff --git a/src/Symfony/Component/Security/Http/Authenticator/Debug/TraceableAuthenticator.php b/src/Symfony/Component/Security/Http/Authenticator/Debug/TraceableAuthenticator.php
@@ -54,7 +54,7 @@ static function (BadgeInterface $badge): array {
                         'resolved' => $badge->isResolved(),
                     ];
                 },
-                $this->passport->getBadges(),
+                $this->passport?->getBadges() ?? [],
             ),
         ];
     }
diff --git a/src/Symfony/Component/Security/Http/Tests/Authenticator/Debug/TraceableAuthenticatorTest.php b/src/Symfony/Component/Security/Http/Tests/Authenticator/Debug/TraceableAuthenticatorTest.php
@@ -36,4 +36,14 @@ public function testGetInfo()
         $this->assertSame($passport, $traceable->authenticate($request));
         $this->assertSame($passport, $traceable->getInfo()['passport']);
     }
+
+    public function testGetInfoWithoutAuth()
+    {
+        $authenticator = $this->createMock(AuthenticatorInterface::class);
+
+        $traceable = new TraceableAuthenticator($authenticator);
+        $this->assertNull($traceable->getInfo()['passport']);
+        $this->assertIsArray($traceable->getInfo()['badges']);
+        $this->assertSame([], $traceable->getInfo()['badges']);
+    }
 }

Original file line number	Diff line number	Diff line change
`@@ -54,7 +54,7 @@ static function (BadgeInterface $badge): array {`
`54`	`54`	`'resolved' => $badge->isResolved(),`
`55`	`55`	`];`
`56`	`56`	`},`
`57`		`- $this->passport->getBadges(),`
	`57`	`+ $this->passport?->getBadges() ?? [],`
`58`	`58`	`),`
`59`	`59`	`];`
`60`	`60`	`}`