[FrameworkBundle] Avoid warming up the validator cache for non-existent classes

Seldaek · fabpot · commit cb12f2200d4e · 2016-11-21T16:13:32.000-08:00
diff --git a/src/Symfony/Bundle/FrameworkBundle/CacheWarmer/ValidatorCacheWarmer.php b/src/Symfony/Bundle/FrameworkBundle/CacheWarmer/ValidatorCacheWarmer.php
@@ -68,7 +68,9 @@ public function warmUp($cacheDir)
 
         foreach ($this->extractSupportedLoaders($loaders) as $loader) {
             foreach ($loader->getMappedClasses() as $mappedClass) {
-                $metadataFactory->getMetadataFor($mappedClass);
+                if ($metadataFactory->hasMetadataFor($mappedClass)) {
+                    $metadataFactory->getMetadataFor($mappedClass);
+                }
             }
         }
 
diff --git a/src/Symfony/Bundle/FrameworkBundle/Tests/Fixtures/Validation/Resources/person.xml b/src/Symfony/Bundle/FrameworkBundle/Tests/Fixtures/Validation/Resources/person.xml
@@ -15,4 +15,15 @@
             </constraint>
         </property>
     </class>
+
+    <class name="Symfony\Bundle\FrameworkBundle\Tests\Fixtures\Validation\NonExistentClass">
+        <property name="gender">
+            <constraint name="Choice">
+                <option name="choices">
+                    <value>other</value>
+                </option>
+                <option name="message">This should be ignored.</option>
+            </constraint>
+        </property>
+    </class>
 </constraint-mapping>

Original file line number	Diff line number	Diff line change
`@@ -68,7 +68,9 @@ public function warmUp($cacheDir)`
`68`	`68`
`69`	`69`	`foreach ($this->extractSupportedLoaders($loaders) as $loader) {`
`70`	`70`	`foreach ($loader->getMappedClasses() as $mappedClass) {`
`71`		`- $metadataFactory->getMetadataFor($mappedClass);`
	`71`	`+ if ($metadataFactory->hasMetadataFor($mappedClass)) {`
	`72`	`+ $metadataFactory->getMetadataFor($mappedClass);`
	`73`	`+ }`
`72`	`74`	`}`
`73`	`75`	`}`
`74`	`76`