bug #39226 [PhpUnitBridge] Fix disabling DeprecationErrorHandler from PHPUnit configuration file (fancyweb)

nicolas-grekas · nicolas-grekas · commit cba70a654753 · 2020-12-08T12:21:32.000+01:00
This PR was merged into the 4.4 branch. Discussion ---------- [PhpUnitBridge] Fix disabling DeprecationErrorHandler from PHPUnit configuration file | Q | A | ------------- | --- | Branch? | 4.4 | Bug fix? | yes | New feature? | no | Deprecations? | no | Tickets | #38239 | License | MIT | Doc PR | - The linked issue description is right, the bridge's bootstrap is hit before the env variables from the phpunit.xml file are read and set. So the easiest solution is to read it ourselves in the root script (like we already do for some of them). Commits ------- 41158b8 [PhpUnitBridge] Fix disabling DeprecationErrorHandler from phpunit configuration file
diff --git a/src/Symfony/Bridge/PhpUnit/bin/simple-phpunit.php b/src/Symfony/Bridge/PhpUnit/bin/simple-phpunit.php
@@ -146,6 +146,10 @@
     }
 }
 
+if ('disabled' === $getEnvVar('SYMFONY_DEPRECATIONS_HELPER')) {
+    putenv('SYMFONY_DEPRECATIONS_HELPER=disabled');
+}
+
 $COMPOSER = file_exists($COMPOSER = $oldPwd.'/composer.phar')
     || ($COMPOSER = rtrim('\\' === \DIRECTORY_SEPARATOR ? preg_replace('/[\r\n].*/', '', `where.exe composer.phar`) : `which composer.phar 2> /dev/null`))
     || ($COMPOSER = rtrim('\\' === \DIRECTORY_SEPARATOR ? preg_replace('/[\r\n].*/', '', `where.exe composer`) : `which composer 2> /dev/null`))

Original file line number	Diff line number	Diff line change
`@@ -146,6 +146,10 @@`
`146`	`146`	`}`
`147`	`147`	`}`
`148`	`148`
	`149`	`+if ('disabled' === $getEnvVar('SYMFONY_DEPRECATIONS_HELPER')) {`
	`150`	`+ putenv('SYMFONY_DEPRECATIONS_HELPER=disabled');`
	`151`	`+}`
	`152`	`+`
`149`	`153`	`$COMPOSER = file_exists($COMPOSER = $oldPwd.'/composer.phar')`
`150`	`154`	\|\| ($COMPOSER = rtrim('\\' === \DIRECTORY_SEPARATOR ? preg_replace('/[\r\n].*/', '', `where.exe composer.phar`) : `which composer.phar 2> /dev/null`))
`151`	`155`	\|\| ($COMPOSER = rtrim('\\' === \DIRECTORY_SEPARATOR ? preg_replace('/[\r\n].*/', '', `where.exe composer`) : `which composer 2> /dev/null`))