Merge branch '3.2'

nicolas-grekas · nicolas-grekas · commit cc398dbf7a1a · 2017-01-13T11:13:02.000+01:00
* 3.2:
  [Cache] Using strpbrk() instead of strcspn() is faster
  bumped Symfony version to 3.2.3
  updated VERSION for 3.2.2
  updated CHANGELOG for 3.2.2
  bumped Symfony version to 3.1.10
  updated VERSION for 3.1.9
  updated CHANGELOG for 3.1.9
diff --git a/CHANGELOG-3.1.md b/CHANGELOG-3.1.md
@@ -7,6 +7,52 @@ in 3.1 minor versions.
 To get the diff for a specific change, go to https://github.com/symfony/symfony/commit/XXX where XXX is the change hash
 To get the diff between two versions, go to https://github.com/symfony/symfony/compare/v3.1.0...v3.1.1
 
+* 3.1.9 (2017-01-12)
+
+ * bug #21218 [Form] DateTimeToLocalizedStringTransformer does not use timezone when using date only (magnetik)
+ * bug #20605 [Ldap] Always have a valid connection when using the EntryManager (bobvandevijver)
+ * bug #21104 [FrameworkBundle] fix IPv6 address handling in server commands (xabbuh)
+ * bug #20793 [Validator] Fix caching of constraints derived from non-serializable parents (uwej711)
+ * bug #19586 [TwigBundle] Fix bug where namespaced paths don't take parent bundles in account (wesleylancel)
+ * bug #21237 [FrameworkBundle] Fix relative paths used as cache keys (nicolas-grekas)
+ * bug #21183 [Validator] respect groups when merging constraints (xabbuh)
+ * bug #21179 [TwigBundle] Fixing regression in TwigEngine exception handling (Bertalan Attila)
+ * bug #21220 [DI] Fix missing new line after private alias (ogizanagi)
+ * bug #21211 Classloader tmpname (lyrixx)
+ * bug #21205 [TwigBundle] fixed usage when Templating is not installed (fabpot)
+ * bug #21155 [Validator] Check cascasdedGroups for being countable (scaytrase)
+ * bug #21200 [Filesystem] Check that directory is writable after created it in dumpFile() (chalasr)
+ * bug #21165 [Serializer] int is valid when float is expected when deserializing JSON (dunglas)
+ * bug #21166 [Cache] Fix order of writes in ChainAdapter (nicolas-grekas)
+ * bug #21113 [FrameworkBundle][HttpKernel] Fix resources loading for bundles with custom structure (chalasr)
+ * bug #21084 [Yaml] handle empty lines inside unindented collection (xabbuh)
+ * bug #20925 [HttpFoundation] Validate/cast cookie expire time (ro0NL)
+ * bug #21032 [SecurityBundle] Made collection of user provider unique when injecting them to the RemberMeService (lyrixx)
+ * bug #21078 [Console] Escape default value when dumping help (lyrixx)
+ * bug #21076 [Console] OS X Can't call cli_set_process_title php without superuser (ogizanagi)
+ * bug #20900 [Console] Descriptors should use Helper::strlen (ogizanagi)
+ * bug #21025 [Cache] remove is_writable check on filesystem cache (4rthem)
+ * bug #21064 [Debug] Wrap call to ->log in a try catch block (lyrixx)
+ * bug #21010 [Debug] UndefinedMethodFatalErrorHandler - Handle anonymous classes (SpacePossum)
+ * bug #20991 [cache] Bump RedisAdapter default timeout to 5s (Nicofuma)
+ * bug #20859 Avoid warning in PHP 7.2 because of non-countable data (wouterj)
+ * bug #21053 [Validator] override property constraints in child class (xabbuh)
+ * bug #21034 [FrameworkBundle] Make TemplateController working without the Templating component (dunglas)
+ * bug #20970 [Console] Fix question formatting using SymfonyStyle::ask() (chalasr, ogizanagi)
+ * bug #20999 [HttpKernel] Continuation of #20599 for 3.1 (ro0NL)
+ * bug #20975 [Form] fix group sequence based validation (xabbuh)
+ * bug #20599 [WebProfilerBundle] Display multiple HTTP headers in WDT (ro0NL)
+ * bug #20799 [TwigBundle] do not try to register incomplete definitions (xabbuh)
+ * bug #20961 [Validator] phpize default option values (xabbuh)
+ * bug #20934 [FrameworkBundle] Fix PHP form templates on translatable attributes (ro0NL)
+ * bug #20957 [FrameworkBundle] test for the Validator component to be present (xabbuh)
+ * bug #20936 [DependencyInjection] Fix on-invalid attribute type in xsd (ogizanagi)
+ * bug #20931 [VarDumper] Fix dumping by-ref variadics (nicolas-grekas)
+ * bug #20734 [Security] AbstractVoter->supportsAttribute gives false positive if attribute is zero (0) (martynas-foodpanda)
+ * bug #14082 [config] Fix issue when key removed and left value only (zerustech)
+ * bug #20910 [HttpFoundation] Fix cookie to string conversion for raw cookies (ro0NL)
+ * bug #20847 [Console] fixed BC issue with static closures (araines)
+
 * 3.1.8 (2016-12-13)
 
  * bug #20714 [FrameworkBundle] Fix unresolved parameters from default configs in debug:config (chalasr)
diff --git a/CHANGELOG-3.2.md b/CHANGELOG-3.2.md
@@ -7,6 +7,69 @@ in 3.2 minor versions.
 To get the diff for a specific change, go to https://github.com/symfony/symfony/commit/XXX where XXX is the change hash
 To get the diff between two versions, go to https://github.com/symfony/symfony/compare/v3.2.0...v3.2.1
 
+* 3.2.2 (2017-01-12)
+
+ * bug #21257 [Profiler][Form] Fix form profiler errors profiler_dump (ogizanagi)
+ * bug #21243 [FrameworkBundle] Fix class_exists() checks in PhpArrayAdapter-related cache warmers (nicolas-grekas, mpajunen)
+ * bug #21218 [Form] DateTimeToLocalizedStringTransformer does not use timezone when using date only (magnetik)
+ * bug #20605 [Ldap] Always have a valid connection when using the EntryManager (bobvandevijver)
+ * bug #21104 [FrameworkBundle] fix IPv6 address handling in server commands (xabbuh)
+ * bug #20793 [Validator] Fix caching of constraints derived from non-serializable parents (uwej711)
+ * bug #19586 [TwigBundle] Fix bug where namespaced paths don't take parent bundles in account (wesleylancel)
+ * bug #21237 [FrameworkBundle] Fix relative paths used as cache keys (nicolas-grekas)
+ * bug #21183 [Validator] respect groups when merging constraints (xabbuh)
+ * bug #21179 [TwigBundle] Fixing regression in TwigEngine exception handling (Bertalan Attila)
+ * bug #21220 [DI] Fix missing new line after private alias (ogizanagi)
+ * bug #21211 Classloader tmpname (lyrixx)
+ * bug #21205 [TwigBundle] fixed usage when Templating is not installed (fabpot)
+ * bug #21155 [Validator] Check cascasdedGroups for being countable (scaytrase)
+ * bug #21200 [Filesystem] Check that directory is writable after created it in dumpFile() (chalasr)
+ * bug #21186 [Bridge/PhpUnit] Relax expectedDeprecation for forward compat (nicolas-grekas)
+ * bug #21184 [FrameworkBundle] Remove Response* from classes to compile (nicolas-grekas)
+ * bug #21165 [Serializer] int is valid when float is expected when deserializing JSON (dunglas)
+ * bug #21167 [Cache] Remove silenced warning tiggered by PhpArrayAdapter (nicolas-grekas)
+ * bug #21166 [Cache] Fix order of writes in ChainAdapter (nicolas-grekas)
+ * bug #21113 [FrameworkBundle][HttpKernel] Fix resources loading for bundles with custom structure (chalasr)
+ * bug #20995 [DependencyInjection] Fix the priority order of compiler pass trait (francoispluchino)
+ * bug #21084 [Yaml] handle empty lines inside unindented collection (xabbuh)
+ * bug #21143 [PhpUnitBridge] Set COMPOSER_ROOT_VERSION while installing (nicolas-grekas)
+ * bug #20925 [HttpFoundation] Validate/cast cookie expire time (ro0NL)
+ * bug #21138 [PhpUnitBridge] skip tests with failure and error states too (xabbuh)
+ * bug #21135 [PhpUnitBridge] hide stack trace of expected deprecation failures (xabbuh)
+ * bug #21117 [Yaml] add missing indicator character (xabbuh)
+ * bug #21121 [PhpUnitBridge] respect skipped and incomplete tests (xabbuh)
+ * bug #21032 [SecurityBundle] Made collection of user provider unique when injecting them to the RemberMeService (lyrixx)
+ * bug #21078 [Console] Escape default value when dumping help (lyrixx)
+ * bug #21076 [Console] OS X Can't call cli_set_process_title php without superuser (ogizanagi)
+ * bug #20900 [Console] Descriptors should use Helper::strlen (ogizanagi)
+ * bug #21025 [Cache] remove is_writable check on filesystem cache (4rthem)
+ * bug #21064 [Debug] Wrap call to ->log in a try catch block (lyrixx)
+ * bug #21069 [Debug] Fixed cast of stream (lyrixx)
+ * bug #21010 [Debug] UndefinedMethodFatalErrorHandler - Handle anonymous classes (SpacePossum)
+ * bug #20991 [cache] Bump RedisAdapter default timeout to 5s (Nicofuma)
+ * bug #20959 [FrameworkBundle] Ignore AnnotationException exceptions in the AnnotationsCacheWarmer (fancyweb)
+ * bug #20795 [FrameworkBundle] Allow multiple transitions with the same name (Padam87)
+ * bug #20859 Avoid warning in PHP 7.2 because of non-countable data (wouterj)
+ * bug #21053 [Validator] override property constraints in child class (xabbuh)
+ * bug #21034 [FrameworkBundle] Make TemplateController working without the Templating component (dunglas)
+ * bug #20970 [Console] Fix question formatting using SymfonyStyle::ask() (chalasr, ogizanagi)
+ * bug #20999 [HttpKernel] Continuation of #20599 for 3.1 (ro0NL)
+ * bug #20975 [Form] fix group sequence based validation (xabbuh)
+ * bug #20599 [WebProfilerBundle] Display multiple HTTP headers in WDT (ro0NL)
+ * bug #20799 [TwigBundle] do not try to register incomplete definitions (xabbuh)
+ * bug #20961 [Validator] phpize default option values (xabbuh)
+ * bug #20934 [FrameworkBundle] Fix PHP form templates on translatable attributes (ro0NL)
+ * bug #20957 [FrameworkBundle] test for the Validator component to be present (xabbuh)
+ * bug #20936 [DependencyInjection] Fix on-invalid attribute type in xsd (ogizanagi)
+ * bug #20931 [VarDumper] Fix dumping by-ref variadics (nicolas-grekas)
+ * bug #20749 [FrameworkBundle] Smarter default for framework.annotations (ogizanagi)
+ * bug #20734 [Security] AbstractVoter->supportsAttribute gives false positive if attribute is zero (0) (martynas-foodpanda)
+ * bug #14082 [config] Fix issue when key removed and left value only (zerustech)
+ * bug #20910 [HttpFoundation] Fix cookie to string conversion for raw cookies (ro0NL)
+ * bug #20909 Fix misresolved parameters in debug:config on 3.2 (chalasr)
+ * bug #20904 [TwigBundle] Config is now a hard dependency (dunglas)
+ * bug #20847 [Console] fixed BC issue with static closures (araines)
+
 * 3.2.1 (2016-12-13)
 
  * bug #20891 Add support for REDIS_URL environment variables. (robinvdvleuten)
diff --git a/UPGRADE-3.3.md b/UPGRADE-3.3.md
@@ -30,12 +30,12 @@ Finder
 ------
 
  * The `ExceptionInterface` has been deprecated and will be removed in 4.0.
- 
+
 FrameworkBundle
 ---------------
 
  * The `Symfony\Bundle\FrameworkBundle\DependencyInjection\Compiler\AddConsoleCommandPass` has been deprecated. Use `Symfony\Component\Console\DependencyInjection\AddConsoleCommandPass` instead.
- 
+
 HttpKernel
 -----------
 
diff --git a/src/Symfony/Component/Cache/CacheItem.php b/src/Symfony/Component/Cache/CacheItem.php
@@ -104,7 +104,7 @@ public function expiresAfter($time)
      *
      * @return static
      *
-     * @throws InvalidArgumentException When $tag is not valid.
+     * @throws InvalidArgumentException When $tag is not valid
      */
     public function tag($tags)
     {
@@ -121,7 +121,7 @@ public function tag($tags)
             if (!isset($tag[0])) {
                 throw new InvalidArgumentException('Cache tag length must be greater than zero');
             }
-            if (isset($tag[strcspn($tag, '{}()/\@:')])) {
+            if (false !== strpbrk($tag, '{}()/\@:')) {
                 throw new InvalidArgumentException(sprintf('Cache tag "%s" contains reserved characters {}()/\@:', $tag));
             }
             $this->tags[$tag] = $tag;
@@ -135,7 +135,7 @@ public function tag($tags)
      *
      * @param string $key The key to validate
      *
-     * @throws InvalidArgumentException When $key is not valid.
+     * @throws InvalidArgumentException When $key is not valid
      */
     public static function validateKey($key)
     {
@@ -145,7 +145,7 @@ public static function validateKey($key)
         if (!isset($key[0])) {
             throw new InvalidArgumentException('Cache key length must be greater than zero');
         }
-        if (isset($key[strcspn($key, '{}()/\@:')])) {
+        if (false !== strpbrk($key, '{}()/\@:')) {
             throw new InvalidArgumentException(sprintf('Cache key "%s" contains reserved characters {}()/\@:', $key));
         }
     }

Original file line number	Diff line number	Diff line change
`@@ -104,7 +104,7 @@ public function expiresAfter($time)`
`104`	`104`	`*`
`105`	`105`	`* @return static`
`106`	`106`	`*`
`107`		`- * @throws InvalidArgumentException When $tag is not valid.`
	`107`	`+ * @throws InvalidArgumentException When $tag is not valid`
`108`	`108`	`*/`
`109`	`109`	`public function tag($tags)`
`110`	`110`	`{`
`@@ -121,7 +121,7 @@ public function tag($tags)`
`121`	`121`	`if (!isset($tag[0])) {`
`122`	`122`	`throw new InvalidArgumentException('Cache tag length must be greater than zero');`
`123`	`123`	`}`
`124`		`- if (isset($tag[strcspn($tag, '{}()/\@:')])) {`
	`124`	`+ if (false !== strpbrk($tag, '{}()/\@:')) {`
`125`	`125`	`throw new InvalidArgumentException(sprintf('Cache tag "%s" contains reserved characters {}()/\@:', $tag));`
`126`	`126`	`}`
`127`	`127`	`$this->tags[$tag] = $tag;`
`@@ -135,7 +135,7 @@ public function tag($tags)`
`135`	`135`	`*`
`136`	`136`	`* @param string $key The key to validate`
`137`	`137`	`*`
`138`		`- * @throws InvalidArgumentException When $key is not valid.`
	`138`	`+ * @throws InvalidArgumentException When $key is not valid`
`139`	`139`	`*/`
`140`	`140`	`public static function validateKey($key)`
`141`	`141`	`{`
`@@ -145,7 +145,7 @@ public static function validateKey($key)`
`145`	`145`	`if (!isset($key[0])) {`
`146`	`146`	`throw new InvalidArgumentException('Cache key length must be greater than zero');`
`147`	`147`	`}`
`148`		`- if (isset($key[strcspn($key, '{}()/\@:')])) {`
	`148`	`+ if (false !== strpbrk($key, '{}()/\@:')) {`
`149`	`149`	`throw new InvalidArgumentException(sprintf('Cache key "%s" contains reserved characters {}()/\@:', $key));`
`150`	`150`	`}`
`151`	`151`	`}`