minor #26913 [Messenger] Add tests for ValidationMiddleware (yceruto)

nicolas-grekas · nicolas-grekas · commit ce5b3e7dedf1 · 2018-04-14T09:04:31.000-05:00
This PR was merged into the 4.1-dev branch. Discussion ---------- [Messenger] Add tests for ValidationMiddleware | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | - Commits ------- 4a3f8f4 Add tests for ValidationMiddleware
diff --git a/src/Symfony/Component/Messenger/Tests/Middleware/HandleMessageMiddlewareTest.php b/src/Symfony/Component/Messenger/Tests/Middleware/HandleMessageMiddlewareTest.php
@@ -22,10 +22,10 @@ public function testItCallsTheHandlerAndNextMiddleware()
     {
         $message = new DummyMessage('Hey');
 
-        $handler = $this->createPartialMock(\stdClass::class, ['__invoke']);
+        $handler = $this->createPartialMock(\stdClass::class, array('__invoke'));
         $handler->method('__invoke')->willReturn('Hello');
 
-        $next = $this->createPartialMock(\stdClass::class, ['__invoke']);
+        $next = $this->createPartialMock(\stdClass::class, array('__invoke'));
 
         $middleware = new HandleMessageMiddleware(new HandlerLocator(array(
             DummyMessage::class => $handler,
diff --git a/src/Symfony/Component/Messenger/Tests/Middleware/ValidationMiddlewareTest.php b/src/Symfony/Component/Messenger/Tests/Middleware/ValidationMiddlewareTest.php
@@ -0,0 +1,75 @@
+<?php
+
+/*
+ * This file is part of the Symfony package.
+ *
+ * (c) Fabien Potencier <fabien@symfony.com>
+ *
+ * For the full copyright and license information, please view the LICENSE
+ * file that was distributed with this source code.
+ */
+
+namespace Symfony\Component\Messenger\Tests\Middleware;
+
+use PHPUnit\Framework\TestCase;
+use Symfony\Component\Messenger\Middleware\ValidationMiddleware;
+use Symfony\Component\Messenger\Tests\Fixtures\DummyMessage;
+use Symfony\Component\Validator\ConstraintViolationListInterface;
+use Symfony\Component\Validator\Validator\ValidatorInterface;
+
+class ValidationMiddlewareTest extends TestCase
+{
+    public function testValidateAndNextMiddleware()
+    {
+        $message = new DummyMessage('Hey');
+
+        $validator = $this->createMock(ValidatorInterface::class);
+        $validator
+            ->expects($this->once())
+            ->method('validate')
+            ->with($message)
+            ->willReturn($this->createMock(ConstraintViolationListInterface::class))
+        ;
+        $next = $this->createPartialMock(\stdClass::class, array('__invoke'));
+        $next
+            ->expects($this->once())
+            ->method('__invoke')
+            ->with($message)
+            ->willReturn('Hello')
+        ;
+
+        $result = (new ValidationMiddleware($validator))->handle($message, $next);
+
+        $this->assertSame('Hello', $result);
+    }
+
+    /**
+     * @expectedException \Symfony\Component\Messenger\Exception\ValidationFailedException
+     * @expectedExceptionMessage Message of type "Symfony\Component\Messenger\Tests\Fixtures\DummyMessage" failed validation.
+     */
+    public function testValidationFailedException()
+    {
+        $message = new DummyMessage('Hey');
+
+        $violationList = $this->createMock(ConstraintViolationListInterface::class);
+        $violationList
+            ->expects($this->once())
+            ->method('count')
+            ->willReturn(1)
+        ;
+        $validator = $this->createMock(ValidatorInterface::class);
+        $validator
+            ->expects($this->once())
+            ->method('validate')
+            ->with($message)
+            ->willReturn($violationList)
+        ;
+        $next = $this->createPartialMock(\stdClass::class, array('__invoke'));
+        $next
+            ->expects($this->never())
+            ->method('__invoke')
+        ;
+
+        (new ValidationMiddleware($validator))->handle($message, $next);
+    }
+}
diff --git a/src/Symfony/Component/Messenger/composer.json b/src/Symfony/Component/Messenger/composer.json
@@ -25,7 +25,8 @@
         "symfony/property-access": "~3.4|~4.0",
         "symfony/var-dumper": "~3.4|~4.0",
         "symfony/property-access": "~3.4|~4.0",
-        "symfony/process": "~4.0"
+        "symfony/process": "~4.0",
+        "symfony/validator": "~4.0"
     },
     "suggest": {
         "sroze/enqueue-bridge": "For using the php-enqueue library as an adapter."
