minor #40936 [DependencyInjection] Add missing bool type in procesValue() (TomasVotruba)

derrabus · derrabus · commit cef2f647b918 · 2021-04-24T16:32:33.000+02:00
This PR was submitted for the 5.x branch but it was merged into the 5.2 branch instead. Discussion ---------- [DependencyInjection] Add missing bool type in procesValue() | Q | A | ------------- | --- | Branch? | 5.x | Bug fix? | no | New feature? | no | Deprecations? | no | License | MIT This method is the only one missing `bool` type. Inside the method is used parent call, that has `bool` type already, so nothing else can be used in it. ![image](https://user-images.githubusercontent.com/924196/115951249-0052fb80-a4e0-11eb-8ee5-601b1d90038f.png) Commits ------- e0f8fe8 [DependencyInjection] Add missing bool type in procesValue()
diff --git a/src/Symfony/Component/DependencyInjection/Compiler/CheckTypeDeclarationsPass.php b/src/Symfony/Component/DependencyInjection/Compiler/CheckTypeDeclarationsPass.php
@@ -78,7 +78,7 @@ public function __construct(bool $autoload = false, array $skippedIds = [])
     /**
      * {@inheritdoc}
      */
-    protected function processValue($value, $isRoot = false)
+    protected function processValue($value, bool $isRoot = false)
     {
         if (isset($this->skippedIds[$this->currentId])) {
             return $value;

Original file line number	Diff line number	Diff line change
`@@ -78,7 +78,7 @@ public function __construct(bool $autoload = false, array $skippedIds = [])`
`78`	`78`	`/**`
`79`	`79`	`* {@inheritdoc}`
`80`	`80`	`*/`
`81`		`- protected function processValue($value, $isRoot = false)`
	`81`	`+ protected function processValue($value, bool $isRoot = false)`
`82`	`82`	`{`
`83`	`83`	`if (isset($this->skippedIds[$this->currentId])) {`
`84`	`84`	`return $value;`