Update WorkflowTest.php

izzyp · lyrixx · commit d00a4aae1e1f · 2017-08-07T10:28:23.000+02:00
diff --git a/src/Symfony/Component/Workflow/CHANGELOG.md b/src/Symfony/Component/Workflow/CHANGELOG.md
@@ -5,6 +5,7 @@ CHANGELOG
 -----
 
  * Added support for `Event::getWorkflowName()` for "announce" events.
+ * Added `workflow.completed` events which are fired after a transition is completed.
 
 3.3.0
 -----
diff --git a/src/Symfony/Component/Workflow/Tests/WorkflowTest.php b/src/Symfony/Component/Workflow/Tests/WorkflowTest.php
@@ -287,6 +287,9 @@ public function testApplyWithEventDispatcher()
             'workflow.workflow_name.entered',
             'workflow.workflow_name.entered.b',
             'workflow.workflow_name.entered.c',
+            'workflow.completed',
+            'workflow.workflow_name.completed',
+            'workflow.workflow_name.completed.t1',
             // Following events are fired because of announce() method
             'workflow.announce',
             'workflow.workflow_name.announce',
diff --git a/src/Symfony/Component/Workflow/Workflow.php b/src/Symfony/Component/Workflow/Workflow.php
@@ -151,6 +151,8 @@ public function apply($subject, $transitionName)
 
             $this->entered($subject, $transition, $marking);
 
+            $this->completed($subject, $transition, $marking);
+
             $this->announce($subject, $transition, $marking);
         }
 
@@ -309,6 +311,19 @@ private function entered($subject, Transition $transition, Marking $marking)
         }
     }
 
+    private function completed($subject, Transition $transition, Marking $marking)
+    {
+        if (null === $this->dispatcher) {
+            return;
+        }
+
+        $event = new Event($subject, $marking, $transition, $this->name);
+
+        $this->dispatcher->dispatch('workflow.completed', $event);
+        $this->dispatcher->dispatch(sprintf('workflow.%s.completed', $this->name), $event);
+        $this->dispatcher->dispatch(sprintf('workflow.%s.completed.%s', $this->name, $transition->getName()), $event);
+    }
+
     private function announce($subject, Transition $initialTransition, Marking $marking)
     {
         if (null === $this->dispatcher) {

Original file line number	Diff line number	Diff line change
`@@ -151,6 +151,8 @@ public function apply($subject, $transitionName)`
`151`	`151`
`152`	`152`	`$this->entered($subject, $transition, $marking);`
`153`	`153`
	`154`	`+ $this->completed($subject, $transition, $marking);`
	`155`	`+`
`154`	`156`	`$this->announce($subject, $transition, $marking);`
`155`	`157`	`}`
`156`	`158`
`@@ -309,6 +311,19 @@ private function entered($subject, Transition $transition, Marking $marking)`
`309`	`311`	`}`
`310`	`312`	`}`
`311`	`313`
	`314`	`+ private function completed($subject, Transition $transition, Marking $marking)`
	`315`	`+ {`
	`316`	`+ if (null === $this->dispatcher) {`
	`317`	`+ return;`
	`318`	`+ }`
	`319`	`+`
	`320`	`+ $event = new Event($subject, $marking, $transition, $this->name);`
	`321`	`+`
	`322`	`+ $this->dispatcher->dispatch('workflow.completed', $event);`
	`323`	`+ $this->dispatcher->dispatch(sprintf('workflow.%s.completed', $this->name), $event);`
	`324`	`+ $this->dispatcher->dispatch(sprintf('workflow.%s.completed.%s', $this->name, $transition->getName()), $event);`
	`325`	`+ }`
	`326`	`+`
`312`	`327`	`private function announce($subject, Transition $initialTransition, Marking $marking)`
`313`	`328`	`{`
`314`	`329`	`if (null === $this->dispatcher) {`