[DependencyInjection] Add shuffle env processor

ostrolucky · ostrolucky · commit d18d3837a23b · 2022-07-08T09:33:57.000+02:00
diff --git a/src/Symfony/Component/DependencyInjection/CHANGELOG.md b/src/Symfony/Component/DependencyInjection/CHANGELOG.md
@@ -6,6 +6,7 @@ CHANGELOG
 
  * Add argument `&$asGhostObject` to LazyProxy's `DumperInterface` to allow using ghost objects for lazy loading services
  * Add `enum` env var processor
+ * Add `shuffle` env var processor
 
 6.1
 ---
diff --git a/src/Symfony/Component/DependencyInjection/EnvVarProcessor.php b/src/Symfony/Component/DependencyInjection/EnvVarProcessor.php
@@ -58,6 +58,7 @@ public static function getProvidedTypes(): array
             'trim' => 'string',
             'require' => 'bool|int|float|string|array',
             'enum' => \BackedEnum::class,
+            'shuffle' => 'array',
         ];
     }
 
@@ -82,7 +83,7 @@ public function getEnv(string $prefix, string $name, \Closure $getEnv): mixed
             }
 
             if (!isset($array[$key]) && !\array_key_exists($key, $array)) {
-                throw new EnvNotFoundException(sprintf('Key "%s" not found in %s (resolved from "%s").', $key, json_encode($array), $next));
+                throw new EnvNotFoundException(sprintf('Key "%s" not found in "%s" (resolved from "%s").', $key, json_encode($array), $next));
             }
 
             return $array[$key];
@@ -206,6 +207,12 @@ public function getEnv(string $prefix, string $name, \Closure $getEnv): mixed
             return null;
         }
 
+        if ('shuffle' === $prefix) {
+            shuffle($env);
+
+            return $env;
+        }
+
         if (!\is_scalar($env)) {
             throw new RuntimeException(sprintf('Non-scalar env var "%s" cannot be cast to "%s".', $name, $prefix));
         }
diff --git a/src/Symfony/Component/DependencyInjection/Tests/EnvVarProcessorTest.php b/src/Symfony/Component/DependencyInjection/Tests/EnvVarProcessorTest.php
@@ -708,6 +708,16 @@ public function testGetEnvCsv($value, $processed)
         $this->assertSame($processed, $result);
     }
 
+    public function testGetEnvShuffle()
+    {
+        mt_srand(2);
+
+        $this->assertSame(
+            ['bar', 'foo'],
+            (new EnvVarProcessor(new Container()))->getEnv('shuffle', '', fn () => ['foo', 'bar']),
+        );
+    }
+
     public function validCsv()
     {
         $complex = <<<'CSV'

Original file line number	Diff line number	Diff line change
`@@ -58,6 +58,7 @@ public static function getProvidedTypes(): array`
`58`	`58`	`'trim' => 'string',`
`59`	`59`	`'require' => 'bool\|int\|float\|string\|array',`
`60`	`60`	`'enum' => \BackedEnum::class,`
	`61`	`+ 'shuffle' => 'array',`
`61`	`62`	`];`
`62`	`63`	`}`
`63`	`64`
`@@ -82,7 +83,7 @@ public function getEnv(string $prefix, string $name, \Closure $getEnv): mixed`
`82`	`83`	`}`
`83`	`84`
`84`	`85`	`if (!isset($array[$key]) && !\array_key_exists($key, $array)) {`
`85`		`- throw new EnvNotFoundException(sprintf('Key "%s" not found in %s (resolved from "%s").', $key, json_encode($array), $next));`
	`86`	`+ throw new EnvNotFoundException(sprintf('Key "%s" not found in "%s" (resolved from "%s").', $key, json_encode($array), $next));`
`86`	`87`	`}`
`87`	`88`
`88`	`89`	`return $array[$key];`
`@@ -206,6 +207,12 @@ public function getEnv(string $prefix, string $name, \Closure $getEnv): mixed`
`206`	`207`	`return null;`
`207`	`208`	`}`
`208`	`209`
	`210`	`+ if ('shuffle' === $prefix) {`
	`211`	`+ shuffle($env);`
	`212`	`+`
	`213`	`+ return $env;`
	`214`	`+ }`
	`215`	`+`
`209`	`216`	`if (!\is_scalar($env)) {`
`210`	`217`	`throw new RuntimeException(sprintf('Non-scalar env var "%s" cannot be cast to "%s".', $name, $prefix));`
`211`	`218`	`}`