[HttpFoundation] don't encode cookie name for BC

nicolas-grekas · nicolas-grekas · commit d28949b8469d · 2018-07-07T11:30:05.000+02:00
diff --git a/src/Symfony/Component/HttpFoundation/Response.php b/src/Symfony/Component/HttpFoundation/Response.php
@@ -333,12 +333,17 @@ public function sendHeaders()
         }
 
         // headers
-        foreach ($this->headers->allPreserveCase() as $name => $values) {
+        foreach ($this->headers->allPreserveCaseWithoutCookies() as $name => $values) {
             foreach ($values as $value) {
                 header($name.': '.$value, false, $this->statusCode);
             }
         }
 
+        // cookies
+        foreach ($this->headers->getCookies() as $cookie) {
+            header('Set-Cookie: '.$cookie->getName().strstr($cookie, '='), false, $this->statusCode);
+        }
+
         // status
         header(sprintf('HTTP/%s %s %s', $this->version, $this->statusCode, $this->statusText), true, $this->statusCode);
 
diff --git a/src/Symfony/Component/HttpFoundation/Tests/Fixtures/response-functional/cookie_urlencode.expected b/src/Symfony/Component/HttpFoundation/Tests/Fixtures/response-functional/cookie_urlencode.expected
@@ -4,7 +4,7 @@ Array
     [0] => Content-Type: text/plain; charset=utf-8
     [1] => Cache-Control: no-cache, private
     [2] => Date: Sat, 12 Nov 1955 20:04:00 GMT
-    [3] => Set-Cookie: %3F%2A%28%29%3A%40%26%2B%24%2F%25%23%5B%5D=%3F%2A%28%29%3A%40%26%2B%24%2F%25%23%5B%5D; path=/
+    [3] => Set-Cookie: ?*():@&+$/%#[]=%3F%2A%28%29%3A%40%26%2B%24%2F%25%23%5B%5D; path=/
     [4] => Set-Cookie: ?*():@&+$/%#[]=%3F%2A%28%29%3A%40%26%2B%24%2F%25%23%5B%5D; path=/
 )
 shutdown

Original file line number	Diff line number	Diff line change
`@@ -333,12 +333,17 @@ public function sendHeaders()`
`333`	`333`	`}`
`334`	`334`
`335`	`335`	`// headers`
`336`		`- foreach ($this->headers->allPreserveCase() as $name => $values) {`
	`336`	`+ foreach ($this->headers->allPreserveCaseWithoutCookies() as $name => $values) {`
`337`	`337`	`foreach ($values as $value) {`
`338`	`338`	`header($name.': '.$value, false, $this->statusCode);`
`339`	`339`	`}`
`340`	`340`	`}`
`341`	`341`
	`342`	`+ // cookies`
	`343`	`+ foreach ($this->headers->getCookies() as $cookie) {`
	`344`	`+ header('Set-Cookie: '.$cookie->getName().strstr($cookie, '='), false, $this->statusCode);`
	`345`	`+ }`
	`346`	`+`
`342`	`347`	`// status`
`343`	`348`	`header(sprintf('HTTP/%s %s %s', $this->version, $this->statusCode, $this->statusText), true, $this->statusCode);`
`344`	`349`
Original file line number	Diff line number	Diff line change
`@@ -4,7 +4,7 @@ Array`
`4`	`4`	`[0] => Content-Type: text/plain; charset=utf-8`
`5`	`5`	`[1] => Cache-Control: no-cache, private`
`6`	`6`	`[2] => Date: Sat, 12 Nov 1955 20:04:00 GMT`
`7`		`- [3] => Set-Cookie: %3F%2A%28%29%3A%40%26%2B%24%2F%25%23%5B%5D=%3F%2A%28%29%3A%40%26%2B%24%2F%25%23%5B%5D; path=/`
	`7`	`+ [3] => Set-Cookie: ?*():@&+$/%#[]=%3F%2A%28%29%3A%40%26%2B%24%2F%25%23%5B%5D; path=/`
`8`	`8`	`[4] => Set-Cookie: ?*():@&+$/%#[]=%3F%2A%28%29%3A%40%26%2B%24%2F%25%23%5B%5D; path=/`
`9`	`9`	`)`
`10`	`10`	`shutdown`