bug #52514 [FrameworkBundle] Don't reference SYMFONY_IDE env var in non-debug mode (nicolas-grekas)

nicolas-grekas · nicolas-grekas · commit d42b5c39a5db · 2023-11-09T15:40:38.000+01:00
This PR was merged into the 6.3 branch. Discussion ---------- [FrameworkBundle] Don't reference SYMFONY_IDE env var in non-debug mode | Q | A | ------------- | --- | Branch? | 6.3 | Bug fix? | yes | New feature? | no | Deprecations? | no | Issues | Fix #52146 | License | MIT See linked issue for an example of a nasty side effect of this. Commits ------- 371b948 [FrameworkBundle] Don't reference SYMFONY_IDE env var in non-debug mode
diff --git a/src/Symfony/Bundle/FrameworkBundle/DependencyInjection/Configuration.php b/src/Symfony/Bundle/FrameworkBundle/DependencyInjection/Configuration.php
@@ -103,7 +103,7 @@ public function getConfigTreeBuilder(): TreeBuilder
                     ->info('Set true to enable support for xsendfile in binary file responses.')
                     ->defaultFalse()
                 ->end()
-                ->scalarNode('ide')->defaultValue('%env(default::SYMFONY_IDE)%')->end()
+                ->scalarNode('ide')->defaultValue($this->debug ? '%env(default::SYMFONY_IDE)%' : null)->end()
                 ->booleanNode('test')->end()
                 ->scalarNode('default_locale')->defaultValue('en')->end()
                 ->booleanNode('set_locale_from_accept_language')
diff --git a/src/Symfony/Bundle/FrameworkBundle/Tests/Functional/ConfigDebugCommandTest.php b/src/Symfony/Bundle/FrameworkBundle/Tests/Functional/ConfigDebugCommandTest.php
@@ -141,7 +141,7 @@ public function testParametersValuesAreFullyResolved(bool $debug)
         $this->assertStringContainsString('locale: en', $tester->getDisplay());
         $this->assertStringContainsString('secret: test', $tester->getDisplay());
         $this->assertStringContainsString('cookie_httponly: true', $tester->getDisplay());
-        $this->assertStringContainsString('ide: '.($_ENV['SYMFONY_IDE'] ?? $_SERVER['SYMFONY_IDE'] ?? 'null'), $tester->getDisplay());
+        $this->assertStringContainsString('ide: '.$debug ? ($_ENV['SYMFONY_IDE'] ?? $_SERVER['SYMFONY_IDE'] ?? 'null') : 'null', $tester->getDisplay());
     }
 
     /**

Original file line number	Diff line number	Diff line change
`@@ -141,7 +141,7 @@ public function testParametersValuesAreFullyResolved(bool $debug)`
`141`	`141`	`$this->assertStringContainsString('locale: en', $tester->getDisplay());`
`142`	`142`	`$this->assertStringContainsString('secret: test', $tester->getDisplay());`
`143`	`143`	`$this->assertStringContainsString('cookie_httponly: true', $tester->getDisplay());`
`144`		`- $this->assertStringContainsString('ide: '.($_ENV['SYMFONY_IDE'] ?? $_SERVER['SYMFONY_IDE'] ?? 'null'), $tester->getDisplay());`
	`144`	`+ $this->assertStringContainsString('ide: '.$debug ? ($_ENV['SYMFONY_IDE'] ?? $_SERVER['SYMFONY_IDE'] ?? 'null') : 'null', $tester->getDisplay());`
`145`	`145`	`}`
`146`	`146`
`147`	`147`	`/**`