feature #28763 [WebProfilerBundle] Extract server parameters into their own tab (fabpot)

fabpot · fabpot · commit d482f0a07d4a · 2018-10-08T16:33:29.000+02:00
This PR was merged into the 4.2-dev branch. Discussion ---------- [WebProfilerBundle] Extract server parameters into their own tab | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | yes-ish | BC breaks? | no | Deprecations? | no  | Tests pass? | yes  | Fixed tickets | n/a | License | MIT | Doc PR | n/a As using env vars is important as of Symfony 4, I think they deserves their own tab under the request section.  Commits ------- 8d47798 [WebProfilerBundle] extracted server parameters into their own tab
diff --git a/src/Symfony/Bundle/WebProfilerBundle/Resources/views/Collector/request.html.twig b/src/Symfony/Bundle/WebProfilerBundle/Resources/views/Collector/request.html.twig
@@ -186,17 +186,6 @@
                         <p>No content</p>
                     </div>
                 {% endif %}
-
-                <h3>Server Parameters</h3>
-                <h4>Defined in .env</h4>
-                {{ include('@WebProfiler/Profiler/bag.html.twig', { bag: collector.dotenvvars }, with_context = false) }}
-
-                <h4>Defined as regular env variables</h4>
-                {% set requestserver = [] %}
-                {% for key, value in collector.requestserver if key not in collector.dotenvvars.keys %}
-                    {% set requestserver = requestserver|merge({(key): value}) %}
-                {% endfor %}
-                {{ include('@WebProfiler/Profiler/table.html.twig', { data: requestserver }, with_context = false) }}
             </div>
         </div>
 
@@ -278,6 +267,22 @@
             </div>
         </div>
 
+        <div class="tab">
+            <h3 class="tab-title">Server Parameters</h3>
+            <div class="tab-content">
+                <h3>Server Parameters</h3>
+                <h4>Defined in .env</h4>
+                {{ include('@WebProfiler/Profiler/bag.html.twig', { bag: collector.dotenvvars }, with_context = false) }}
+
+                <h4>Defined as regular env variables</h4>
+                {% set requestserver = [] %}
+                {% for key, value in collector.requestserver if key not in collector.dotenvvars.keys %}
+                    {% set requestserver = requestserver|merge({(key): value}) %}
+                {% endfor %}
+                {{ include('@WebProfiler/Profiler/table.html.twig', { data: requestserver }, with_context = false) }}
+            </div>
+        </div>
+
         {% if profile.parent %}
         <div class="tab">
             <h3 class="tab-title">Parent Request</h3>
