bug #51042 [Mailer] [Mailgun] Disable tls for mailgun as it should use STARTTLS (joelwurtz)

nicolas-grekas · nicolas-grekas · commit d5f4cf27513f · 2023-07-21T18:34:33.000+02:00
This PR was merged into the 6.3 branch. Discussion ---------- [Mailer] [Mailgun] Disable tls for mailgun as it should use STARTTLS | Q | A | ------------- | --- | Branch? | 6.3 | Bug fix? | yes | New feature? | no | Deprecations? | no | Tickets | | License | MIT | Doc PR | Since symfony 6.3 smtp mailgun use 587 as default port with tls true, but it does not work : ![image](https://github.com/symfony/symfony/assets/90466/807aff57-00f8-46cf-b137-db5210f9ebd6) Setting tls to false, force the smtp transport to try to use STARTTLS if available like others smtp providers (mailchimp in example) Commits ------- 26395d4 fix(mailgun-smtp): disable tls for mailgun as it should use starttls instead
diff --git a/src/Symfony/Component/Mailer/Bridge/Mailgun/Transport/MailgunSmtpTransport.php b/src/Symfony/Component/Mailer/Bridge/Mailgun/Transport/MailgunSmtpTransport.php
@@ -24,7 +24,7 @@ class MailgunSmtpTransport extends EsmtpTransport
 
     public function __construct(string $username, #[\SensitiveParameter] string $password, string $region = null, EventDispatcherInterface $dispatcher = null, LoggerInterface $logger = null)
     {
-        parent::__construct('us' !== ($region ?: 'us') ? sprintf('smtp.%s.mailgun.org', $region) : 'smtp.mailgun.org', 587, true, $dispatcher, $logger);
+        parent::__construct('us' !== ($region ?: 'us') ? sprintf('smtp.%s.mailgun.org', $region) : 'smtp.mailgun.org', 587, false, $dispatcher, $logger);
 
         $this->setUsername($username);
         $this->setPassword($password);

Original file line number	Diff line number	Diff line change
`@@ -24,7 +24,7 @@ class MailgunSmtpTransport extends EsmtpTransport`
`24`	`24`
`25`	`25`	`public function __construct(string $username, #[\SensitiveParameter] string $password, string $region = null, EventDispatcherInterface $dispatcher = null, LoggerInterface $logger = null)`
`26`	`26`	`{`
`27`		`- parent::__construct('us' !== ($region ?: 'us') ? sprintf('smtp.%s.mailgun.org', $region) : 'smtp.mailgun.org', 587, true, $dispatcher, $logger);`
	`27`	`+ parent::__construct('us' !== ($region ?: 'us') ? sprintf('smtp.%s.mailgun.org', $region) : 'smtp.mailgun.org', 587, false, $dispatcher, $logger);`
`28`	`28`
`29`	`29`	`$this->setUsername($username);`
`30`	`30`	`$this->setPassword($password);`