minor #46713 [DoctrineBridge] Add missing break (Gigino Chianese)

nicolas-grekas · nicolas-grekas · commit d686e38f3001 · 2022-06-19T15:04:59.000+02:00
This PR was merged into the 4.4 branch. Discussion ---------- [DoctrineBridge] Add missing break ~~This PR only adds the "no break" comment as requested on my last PR:~~ This PR only adds the missing break as requested on my last PR: #46676 (comment) I hope it's fine to not include the describing table. ~~The missing break is on purpose, so here is no real code change.~~ The missing break should not have caused any side effects. I have not changed any tests here, because both cases are already tested by these two lines: https://github.com/symfony/symfony/blob/7fc7acb1e4448762f438af03cadb2ce54e3918e0/src/Symfony/Bridge/Doctrine/Tests/PropertyInfo/DoctrineExtractorTest.php#L186-L187 Commits ------- 445b78a [DoctrineBridge] Add missing break
diff --git a/src/Symfony/Bridge/Doctrine/PropertyInfo/DoctrineExtractor.php b/src/Symfony/Bridge/Doctrine/PropertyInfo/DoctrineExtractor.php
@@ -199,6 +199,7 @@ public function getTypes($class, $property, array $context = [])
                         case self::$useDeprecatedConstants ? DBALType::SIMPLE_ARRAY : Types::SIMPLE_ARRAY:
                             return [new Type(Type::BUILTIN_TYPE_ARRAY, $nullable, null, true, new Type(Type::BUILTIN_TYPE_INT), $enumType ?? new Type(Type::BUILTIN_TYPE_STRING))];
                     }
+                    break;
                 case Type::BUILTIN_TYPE_INT:
                 case Type::BUILTIN_TYPE_STRING:
                     if ($enumType) {

Original file line number	Diff line number	Diff line change
`@@ -199,6 +199,7 @@ public function getTypes($class, $property, array $context = [])`
`199`	`199`	`case self::$useDeprecatedConstants ? DBALType::SIMPLE_ARRAY : Types::SIMPLE_ARRAY:`
`200`	`200`	`return [new Type(Type::BUILTIN_TYPE_ARRAY, $nullable, null, true, new Type(Type::BUILTIN_TYPE_INT), $enumType ?? new Type(Type::BUILTIN_TYPE_STRING))];`
`201`	`201`	`}`
	`202`	`+ break;`
`202`	`203`	`case Type::BUILTIN_TYPE_INT:`
`203`	`204`	`case Type::BUILTIN_TYPE_STRING:`
`204`	`205`	`if ($enumType) {`