Adding periods at the end of exceptions, and changing one class name to LogicException thanks to @iltar

weaverryan · weaverryan · commit d6937218be82 · 2015-09-20T19:24:21.000-04:00
diff --git a/src/Symfony/Component/Security/Guard/Firewall/GuardAuthenticationListener.php b/src/Symfony/Component/Security/Guard/Firewall/GuardAuthenticationListener.php
@@ -162,7 +162,7 @@ private function triggerRememberMe(GuardAuthenticatorInterface $guardAuthenticat
 
         if (null === $this->rememberMeServices) {
             if (null !== $this->logger) {
-                $this->logger->info('Remember me skipped: it is not configured for the firewall', array('authenticator' => get_class($guardAuthenticator)));
+                $this->logger->info('Remember me skipped: it is not configured for the firewall.', array('authenticator' => get_class($guardAuthenticator)));
             }
 
             return;
diff --git a/src/Symfony/Component/Security/Guard/GuardAuthenticatorHandler.php b/src/Symfony/Component/Security/Guard/GuardAuthenticatorHandler.php
@@ -68,7 +68,7 @@ public function handleAuthenticationSuccess(TokenInterface $token, Request $requ
         }
 
         throw new \UnexpectedValueException(sprintf(
-            'The %s::onAuthenticationSuccess method must return null or a Response object. You returned %s',
+            'The %s::onAuthenticationSuccess method must return null or a Response object. You returned %s.',
             get_class($guardAuthenticator),
             is_object($response) ? get_class($response) : gettype($response)
         ));
@@ -117,7 +117,7 @@ public function handleAuthenticationFailure(AuthenticationException $authenticat
         }
 
         throw new \UnexpectedValueException(sprintf(
-            'The %s::onAuthenticationFailure method must return null or a Response object. You returned %s',
+            'The %s::onAuthenticationFailure method must return null or a Response object. You returned %s.',
             get_class($guardAuthenticator),
             is_object($response) ? get_class($response) : gettype($response)
         ));
diff --git a/src/Symfony/Component/Security/Guard/Provider/GuardAuthenticationProvider.php b/src/Symfony/Component/Security/Guard/Provider/GuardAuthenticationProvider.php
@@ -52,7 +52,7 @@ public function __construct(array $guardAuthenticators, UserProviderInterface $u
     public function authenticate(TokenInterface $token)
     {
         if (!$this->supports($token)) {
-            throw new \InvalidArgumentException('GuardAuthenticationProvider only supports NonAuthenticatedGuardToken');
+            throw new \InvalidArgumentException('GuardAuthenticationProvider only supports GuardTokenInterface.');
         }
 
         if (!$token instanceof PreAuthenticationGuardToken) {
@@ -87,7 +87,7 @@ public function authenticate(TokenInterface $token)
         }
 
         throw new \LogicException(sprintf(
-            'The correct GuardAuthenticator could not be found for unique key "%s". The listener and provider should be passed the same list of authenticators!?',
+            'The correct GuardAuthenticator could not be found for unique key "%s". The listener and provider should be passed the same list of authenticators.',
             $token->getGuardProviderKey()
         ));
     }
@@ -99,7 +99,7 @@ private function authenticateViaGuard(GuardAuthenticatorInterface $guardAuthenti
 
         if (!$user instanceof UserInterface) {
             throw new \UnexpectedValueException(sprintf(
-                'The %s::authenticate method must return a UserInterface. You returned %s',
+                'The %s::authenticate method must return a UserInterface. You returned %s.',
                 get_class($guardAuthenticator),
                 is_object($user) ? get_class($user) : gettype($user)
             ));
@@ -113,7 +113,7 @@ private function authenticateViaGuard(GuardAuthenticatorInterface $guardAuthenti
         $authenticatedToken = $guardAuthenticator->createAuthenticatedToken($user, $this->providerKey);
         if (!$authenticatedToken instanceof TokenInterface) {
             throw new \UnexpectedValueException(sprintf(
-                'The %s::createAuthenticatedToken method must return a TokenInterface. You returned %s',
+                'The %s::createAuthenticatedToken method must return a TokenInterface. You returned %s.',
                 get_class($guardAuthenticator),
                 is_object($authenticatedToken) ? get_class($authenticatedToken) : gettype($authenticatedToken)
             ));
diff --git a/src/Symfony/Component/Security/Guard/Token/PreAuthenticationGuardToken.php b/src/Symfony/Component/Security/Guard/Token/PreAuthenticationGuardToken.php
@@ -51,6 +51,6 @@ public function getCredentials()
 
     public function setAuthenticated($authenticated)
     {
-        throw new \Exception('The PreAuthenticationGuardToken is *always* not authenticated');
+        throw new \LogicException('The PreAuthenticationGuardToken is *always* not authenticated.');
     }
 }

Original file line number	Diff line number	Diff line change
`@@ -162,7 +162,7 @@ private function triggerRememberMe(GuardAuthenticatorInterface $guardAuthenticat`
`162`	`162`
`163`	`163`	`if (null === $this->rememberMeServices) {`
`164`	`164`	`if (null !== $this->logger) {`
`165`		`- $this->logger->info('Remember me skipped: it is not configured for the firewall', array('authenticator' => get_class($guardAuthenticator)));`
	`165`	`+ $this->logger->info('Remember me skipped: it is not configured for the firewall.', array('authenticator' => get_class($guardAuthenticator)));`
`166`	`166`	`}`
`167`	`167`
`168`	`168`	`return;`
Original file line number	Diff line number	Diff line change
`@@ -51,6 +51,6 @@ public function getCredentials()`
`51`	`51`
`52`	`52`	`public function setAuthenticated($authenticated)`
`53`	`53`	`{`
`54`		`- throw new \Exception('The PreAuthenticationGuardToken is always not authenticated');`
	`54`	`+ throw new \LogicException('The PreAuthenticationGuardToken is always not authenticated.');`
`55`	`55`	`}`
`56`	`56`	`}`