[Routing] allow extending Route attribute

robmro27 · fabpot · commit d733b78f88dd · 2021-05-01T16:20:43.000+02:00
diff --git a/src/Symfony/Component/Routing/Loader/AnnotationClassLoader.php b/src/Symfony/Component/Routing/Loader/AnnotationClassLoader.php
@@ -280,7 +280,7 @@ protected function getGlobals(\ReflectionClass $class)
         $globals = $this->resetGlobals();
 
         $annot = null;
-        if (\PHP_VERSION_ID >= 80000 && ($attribute = $class->getAttributes($this->routeAnnotationClass)[0] ?? null)) {
+        if (\PHP_VERSION_ID >= 80000 && ($attribute = $class->getAttributes($this->routeAnnotationClass, \ReflectionAttribute::IS_INSTANCEOF)[0] ?? null)) {
             $annot = $attribute->newInstance();
         }
         if (!$annot && $this->reader) {
@@ -372,7 +372,7 @@ abstract protected function configureRoute(Route $route, \ReflectionClass $class
     private function getAnnotations(object $reflection): iterable
     {
         if (\PHP_VERSION_ID >= 80000) {
-            foreach ($reflection->getAttributes($this->routeAnnotationClass) as $attribute) {
+            foreach ($reflection->getAttributes($this->routeAnnotationClass, \ReflectionAttribute::IS_INSTANCEOF) as $attribute) {
                 yield $attribute->newInstance();
             }
         }

Original file line number	Diff line number	Diff line change
`@@ -280,7 +280,7 @@ protected function getGlobals(\ReflectionClass $class)`
`280`	`280`	`$globals = $this->resetGlobals();`
`281`	`281`
`282`	`282`	`$annot = null;`
`283`		`- if (\PHP_VERSION_ID >= 80000 && ($attribute = $class->getAttributes($this->routeAnnotationClass)[0] ?? null)) {`
	`283`	`+ if (\PHP_VERSION_ID >= 80000 && ($attribute = $class->getAttributes($this->routeAnnotationClass, \ReflectionAttribute::IS_INSTANCEOF)[0] ?? null)) {`
`284`	`284`	`$annot = $attribute->newInstance();`
`285`	`285`	`}`
`286`	`286`	`if (!$annot && $this->reader) {`
`@@ -372,7 +372,7 @@ abstract protected function configureRoute(Route $route, \ReflectionClass $class`
`372`	`372`	`private function getAnnotations(object $reflection): iterable`
`373`	`373`	`{`
`374`	`374`	`if (\PHP_VERSION_ID >= 80000) {`
`375`		`- foreach ($reflection->getAttributes($this->routeAnnotationClass) as $attribute) {`
	`375`	`+ foreach ($reflection->getAttributes($this->routeAnnotationClass, \ReflectionAttribute::IS_INSTANCEOF) as $attribute) {`
`376`	`376`	`yield $attribute->newInstance();`
`377`	`377`	`}`
`378`	`378`	`}`