bug #49046 Fix for Windows when projects are deployed on junctions/symlinks (nerdgod)

nicolas-grekas · nicolas-grekas · commit dd30a083d1db · 2023-01-20T17:47:56.000+01:00
This PR was submitted for the 6.0 branch but it was merged into the 5.4 branch instead. Discussion ---------- Fix for Windows when projects are deployed on junctions/symlinks | Q | A | ------------- | --- | Branch? | 5.4 | Bug fix? | yes | New feature? | no | Deprecations? | no | Tickets | Fix #49041 | License | MIT | Doc PR | none On windows systems where a project directory may be located at a directory that is a junction to a path on another drive, realpath() must be called on both sides of a call to `Filesystem::makePathRelative($path1,$path2)`. Otherwise the result will be an irresolvable comparison across filesystems and the return value will be the value of $path1, not a relative path. Commits ------- 6bbc46c Update ComposerPlugin.php
diff --git a/src/Symfony/Component/Runtime/Internal/ComposerPlugin.php b/src/Symfony/Component/Runtime/Internal/ComposerPlugin.php
@@ -58,7 +58,7 @@ public function uninstall(Composer $composer, IOInterface $io): void
 
     public function updateAutoloadFile(): void
     {
-        $vendorDir = $this->composer->getConfig()->get('vendor-dir');
+        $vendorDir = realpath($this->composer->getConfig()->get('vendor-dir'));
 
         if (!is_file($autoloadFile = $vendorDir.'/autoload.php')
             || false === $extra = $this->composer->getPackage()->getExtra()['runtime'] ?? []

Original file line number	Diff line number	Diff line change
`@@ -58,7 +58,7 @@ public function uninstall(Composer $composer, IOInterface $io): void`
`58`	`58`
`59`	`59`	`public function updateAutoloadFile(): void`
`60`	`60`	`{`
`61`		`- $vendorDir = $this->composer->getConfig()->get('vendor-dir');`
	`61`	`+ $vendorDir = realpath($this->composer->getConfig()->get('vendor-dir'));`
`62`	`62`
`63`	`63`	`if (!is_file($autoloadFile = $vendorDir.'/autoload.php')`
`64`	`64`	`\|\| false === $extra = $this->composer->getPackage()->getExtra()['runtime'] ?? []`