minor #31675 [Intl][4.3] Cleanup internal api (ro0NL)

nicolas-grekas · nicolas-grekas · commit dd3dc1a68400 · 2019-05-29T11:14:54.000+02:00
This PR was merged into the 4.3 branch. Discussion ---------- [Intl][4.3] Cleanup internal api | Q | A | ------------- | --- | Branch? | 4.3 | Bug fix? | yes | New feature? | no | BC breaks? | no  | Deprecations? | no | Tests pass? | yes  | Fixed tickets | #...  | License | MIT | Doc PR | symfony/symfony-docs#...  Forgotten in #31411 (comment) Commits ------- 6eab5d2 [Intl][4.3] Cleanup internal api
diff --git a/src/Symfony/Component/Intl/Data/Provider/LanguageDataProvider.php b/src/Symfony/Component/Intl/Data/Provider/LanguageDataProvider.php
@@ -18,7 +18,7 @@
  *
  * @author Bernhard Schussek <bschussek@gmail.com>
  *
- * @internal
+ * @internal to be removed in 5.0.
  */
 class LanguageDataProvider
 {
@@ -37,17 +37,11 @@ public function __construct(string $path, BundleEntryReaderInterface $reader)
         $this->reader = $reader;
     }
 
-    /**
-     * @internal to be removed in 5.0.
-     */
     public function getLanguages()
     {
         return $this->reader->readEntry($this->path, 'meta', ['Languages']);
     }
 
-    /**
-     * @internal to be removed in 5.0.
-     */
     public function getAliases()
     {
         return $this->reader->readEntry($this->path, 'root', ['Aliases']);
@@ -62,9 +56,6 @@ public function getName($language, $displayLocale = null)
         return $this->reader->readEntry($this->path, $displayLocale, ['Names', $language]);
     }
 
-    /**
-     * @internal to be removed in 5.0.
-     */
     public function getNames($displayLocale = null)
     {
         if (null === $displayLocale) {
@@ -83,9 +74,6 @@ public function getNames($displayLocale = null)
         return $languages;
     }
 
-    /**
-     * @internal to be removed in 5.0.
-     */
     public function getAlpha3Code($language)
     {
         return $this->reader->readEntry($this->path, 'meta', ['Alpha2ToAlpha3', $language]);
diff --git a/src/Symfony/Component/Intl/Data/Provider/RegionDataProvider.php b/src/Symfony/Component/Intl/Data/Provider/RegionDataProvider.php
@@ -18,7 +18,7 @@
  *
  * @author Bernhard Schussek <bschussek@gmail.com>
  *
- * @internal
+ * @internal to be removed in 5.0.
  */
 class RegionDataProvider
 {
@@ -37,9 +37,6 @@ public function __construct(string $path, BundleEntryReaderInterface $reader)
         $this->reader = $reader;
     }
 
-    /**
-     * @internal to be removed in 5.0.
-     */
     public function getRegions()
     {
         return $this->reader->readEntry($this->path, 'meta', ['Regions']);
@@ -54,9 +51,6 @@ public function getName($region, $displayLocale = null)
         return $this->reader->readEntry($this->path, $displayLocale, ['Names', $region]);
     }
 
-    /**
-     * @internal to be removed in 5.0.
-     */
     public function getNames($displayLocale = null)
     {
         if (null === $displayLocale) {
diff --git a/src/Symfony/Component/Intl/Data/Provider/ScriptDataProvider.php b/src/Symfony/Component/Intl/Data/Provider/ScriptDataProvider.php
@@ -18,7 +18,7 @@
  *
  * @author Bernhard Schussek <bschussek@gmail.com>
  *
- * @internal
+ * @internal to be removed in 5.0.
  */
 class ScriptDataProvider
 {
@@ -37,9 +37,6 @@ public function __construct(string $path, BundleEntryReaderInterface $reader)
         $this->reader = $reader;
     }
 
-    /**
-     * @internal to be removed in 5.0.
-     */
     public function getScripts()
     {
         return $this->reader->readEntry($this->path, 'meta', ['Scripts']);
@@ -54,9 +51,6 @@ public function getName($script, $displayLocale = null)
         return $this->reader->readEntry($this->path, $displayLocale, ['Names', $script]);
     }
 
-    /**
-     * @internal to be removed in 5.0.
-     */
     public function getNames($displayLocale = null)
     {
         if (null === $displayLocale) {

Original file line number	Diff line number	Diff line change
`@@ -18,7 +18,7 @@`
`18`	`18`	`*`
`19`	`19`	`* @author Bernhard Schussek <[email protected]>`
`20`	`20`	`*`
`21`		`- * @internal`
	`21`	`+ * @internal to be removed in 5.0.`
`22`	`22`	`*/`
`23`	`23`	`class LanguageDataProvider`
`24`	`24`	`{`
`@@ -37,17 +37,11 @@ public function __construct(string $path, BundleEntryReaderInterface $reader)`
`37`	`37`	`$this->reader = $reader;`
`38`	`38`	`}`
`39`	`39`
`40`		`- /**`
`41`		`- * @internal to be removed in 5.0.`
`42`		`- */`
`43`	`40`	`public function getLanguages()`
`44`	`41`	`{`
`45`	`42`	`return $this->reader->readEntry($this->path, 'meta', ['Languages']);`
`46`	`43`	`}`
`47`	`44`
`48`		`- /**`
`49`		`- * @internal to be removed in 5.0.`
`50`		`- */`
`51`	`45`	`public function getAliases()`
`52`	`46`	`{`
`53`	`47`	`return $this->reader->readEntry($this->path, 'root', ['Aliases']);`
`@@ -62,9 +56,6 @@ public function getName($language, $displayLocale = null)`
`62`	`56`	`return $this->reader->readEntry($this->path, $displayLocale, ['Names', $language]);`
`63`	`57`	`}`
`64`	`58`
`65`		`- /**`
`66`		`- * @internal to be removed in 5.0.`
`67`		`- */`
`68`	`59`	`public function getNames($displayLocale = null)`
`69`	`60`	`{`
`70`	`61`	`if (null === $displayLocale) {`
`@@ -83,9 +74,6 @@ public function getNames($displayLocale = null)`
`83`	`74`	`return $languages;`
`84`	`75`	`}`
`85`	`76`
`86`		`- /**`
`87`		`- * @internal to be removed in 5.0.`
`88`		`- */`
`89`	`77`	`public function getAlpha3Code($language)`
`90`	`78`	`{`
`91`	`79`	`return $this->reader->readEntry($this->path, 'meta', ['Alpha2ToAlpha3', $language]);`