minor #42903 [HttpKernel] Fix broken mock (derrabus)

fabpot · fabpot · commit dd45efcfa016 · 2021-09-07T07:26:05.000+02:00
This PR was merged into the 4.4 branch. Discussion ---------- [HttpKernel] Fix broken mock | Q | A | ------------- | --- | Branch? | 4.4 | Bug fix? | yes | New feature? | no | Deprecations? | no | Tickets | N/A | License | MIT | Doc PR | N/A This PR fixes a test that fails on the 6.0 branch because of a broken mock: A correct implementation of `CacheItemPoolInterface::clear()` returns a `bool`, but this mock currently returns `null`. Commits ------- 1ab97ea [HttpKernel] Fix broken mock
diff --git a/src/Symfony/Component/HttpKernel/Tests/CacheClearer/Psr6CacheClearerTest.php b/src/Symfony/Component/HttpKernel/Tests/CacheClearer/Psr6CacheClearerTest.php
@@ -32,9 +32,11 @@ public function testClearPool()
         $pool = $this->createMock(CacheItemPoolInterface::class);
         $pool
             ->expects($this->once())
-            ->method('clear');
+            ->method('clear')
+            ->willReturn(true)
+        ;
 
-        (new Psr6CacheClearer(['pool' => $pool]))->clearPool('pool');
+        $this->assertTrue((new Psr6CacheClearer(['pool' => $pool]))->clearPool('pool'));
     }
 
     public function testClearPoolThrowsExceptionOnUnreferencedPool()
