Do not throw when setSaveHandler is called and headers have already been sent

sroze · sroze · commit df88fdb629ba · 2017-11-13T13:35:01.000Z
diff --git a/src/Symfony/Component/HttpFoundation/Session/Storage/NativeSessionStorage.php b/src/Symfony/Component/HttpFoundation/Session/Storage/NativeSessionStorage.php
@@ -396,7 +396,7 @@ public function setSaveHandler($saveHandler = null)
         }
 
         if (headers_sent($file, $line)) {
-            throw new \RuntimeException(sprintf('Failed to set the session handler because headers have already been sent by "%s" at line %d.', $file, $line));
+        //    throw new \RuntimeException(sprintf('Failed to set the session handler because headers have already been sent by "%s" at line %d.', $file, $line));
         }
 
         // Wrap $saveHandler in proxy and prevent double wrapping of proxy

Original file line number	Diff line number	Diff line change
`@@ -396,7 +396,7 @@ public function setSaveHandler($saveHandler = null)`
`396`	`396`	`}`
`397`	`397`
`398`	`398`	`if (headers_sent($file, $line)) {`
`399`		`- throw new \RuntimeException(sprintf('Failed to set the session handler because headers have already been sent by "%s" at line %d.', $file, $line));`
	`399`	`+ // throw new \RuntimeException(sprintf('Failed to set the session handler because headers have already been sent by "%s" at line %d.', $file, $line));`
`400`	`400`	`}`
`401`	`401`
`402`	`402`	`// Wrap $saveHandler in proxy and prevent double wrapping of proxy`