bug #51497 [FrameworkBundle] no serializer mapping cache in debug mode without enable_annotations (soyuka)

nicolas-grekas · nicolas-grekas · commit e065f2e17128 · 2023-09-14T10:56:31.000+02:00
This PR was merged into the 5.4 branch. Discussion ---------- [FrameworkBundle] no serializer mapping cache in debug mode without enable_annotations | Q | A | ------------- | --- | Branch? | 5.4 | Bug fix? | yes There's no reason we should disable the cache only without `enable_annotations`, when working only with attributes, in debug mode the cache is enabled which is why we often need to clear cache when changing a serialized object to get the changes. Commits ------- 4312e96 [FrameworkBundle] no serializer mapping cache in debug mode without enable_annotations
diff --git a/src/Symfony/Bundle/FrameworkBundle/DependencyInjection/FrameworkExtension.php b/src/Symfony/Bundle/FrameworkBundle/DependencyInjection/FrameworkExtension.php
@@ -1790,14 +1790,15 @@ private function registerSerializerConfiguration(array $config, ContainerBuilder
             $container->removeDefinition('serializer.normalizer.mime_message');
         }
 
+        if ($container->getParameter('kernel.debug')) {
+            $container->removeDefinition('serializer.mapping.cache_class_metadata_factory');
+        }
+
         $serializerLoaders = [];
         if (isset($config['enable_annotations']) && $config['enable_annotations']) {
             if (\PHP_VERSION_ID < 80000 && !$this->annotationsConfigEnabled) {
                 throw new \LogicException('"enable_annotations" on the serializer cannot be set as the PHP version is lower than 8 and Annotations support is disabled. Consider upgrading PHP.');
             }
-            if ($container->getParameter('kernel.debug')) {
-                $container->removeDefinition('serializer.mapping.cache_class_metadata_factory');
-            }
 
             $annotationLoader = new Definition(
                 'Symfony\Component\Serializer\Mapping\Loader\AnnotationLoader',
diff --git a/src/Symfony/Bundle/FrameworkBundle/Tests/DependencyInjection/FrameworkExtensionTestCase.php b/src/Symfony/Bundle/FrameworkBundle/Tests/DependencyInjection/FrameworkExtensionTestCase.php
@@ -1530,6 +1530,12 @@ public function testSerializerCacheActivated()
     public function testSerializerCacheUsedWithoutAnnotationsAndMappingFiles()
     {
         $container = $this->createContainerFromFile('serializer_mapping_without_annotations', ['kernel.debug' => true, 'kernel.container_class' => __CLASS__]);
+        $this->assertFalse($container->hasDefinition('serializer.mapping.cache_class_metadata_factory'));
+    }
+
+    public function testSerializerCacheUsedWithoutAnnotationsAndMappingFilesNoDebug()
+    {
+        $container = $this->createContainerFromFile('serializer_mapping_without_annotations', ['kernel.debug' => false, 'kernel.container_class' => __CLASS__]);
         $this->assertTrue($container->hasDefinition('serializer.mapping.cache_class_metadata_factory'));
     }
 

Original file line number	Diff line number	Diff line change
`@@ -1530,6 +1530,12 @@ public function testSerializerCacheActivated()`
`1530`	`1530`	`public function testSerializerCacheUsedWithoutAnnotationsAndMappingFiles()`
`1531`	`1531`	`{`
`1532`	`1532`	`$container = $this->createContainerFromFile('serializer_mapping_without_annotations', ['kernel.debug' => true, 'kernel.container_class' => __CLASS__]);`
	`1533`	`+ $this->assertFalse($container->hasDefinition('serializer.mapping.cache_class_metadata_factory'));`
	`1534`	`+ }`
	`1535`	`+`
	`1536`	`+ public function testSerializerCacheUsedWithoutAnnotationsAndMappingFilesNoDebug()`
	`1537`	`+ {`
	`1538`	`+ $container = $this->createContainerFromFile('serializer_mapping_without_annotations', ['kernel.debug' => false, 'kernel.container_class' => __CLASS__]);`
`1533`	`1539`	`$this->assertTrue($container->hasDefinition('serializer.mapping.cache_class_metadata_factory'));`
`1534`	`1540`	`}`
`1535`	`1541`