[DI] Dont cache classes with missing parents

nicolas-grekas · nicolas-grekas · commit e1924f933942 · 2019-11-07T14:32:35.000+01:00
diff --git a/src/Symfony/Component/Config/Resource/ClassExistenceResource.php b/src/Symfony/Component/Config/Resource/ClassExistenceResource.php
@@ -155,7 +155,7 @@ public static function throwOnRequiredClass($class, \Exception $previous = null)
             throw $previous;
         }
 
-        $e = new \ReflectionException("Class $class not found", 0, $previous);
+        $e = new \ReflectionException(sprintf('Class "%s" not found while loading "%s".', $class, self::$autoloadedClass), 0, $previous);
 
         if (null !== $previous) {
             throw $e;
diff --git a/src/Symfony/Component/Config/Tests/Resource/ClassExistenceResourceTest.php b/src/Symfony/Component/Config/Tests/Resource/ClassExistenceResourceTest.php
@@ -84,7 +84,7 @@ public function testBadParentWithTimestamp()
     public function testBadParentWithNoTimestamp()
     {
         $this->expectException('ReflectionException');
-        $this->expectExceptionMessage('Class Symfony\Component\Config\Tests\Fixtures\MissingParent not found');
+        $this->expectExceptionMessage('Class "Symfony\Component\Config\Tests\Fixtures\MissingParent" not found while loading "Symfony\Component\Config\Tests\Fixtures\BadParent".');
 
         $res = new ClassExistenceResource(BadParent::class, false);
         $res->isFresh(0);
diff --git a/src/Symfony/Component/DependencyInjection/ContainerBuilder.php b/src/Symfony/Component/DependencyInjection/ContainerBuilder.php
@@ -361,7 +361,7 @@ public function getReflectionClass($class, $throw = true)
             return null;
         }
 
-        $resource = null;
+        $resource = $classReflector = null;
 
         try {
             if (isset($this->classReflectors[$class])) {
@@ -376,7 +376,6 @@ public function getReflectionClass($class, $throw = true)
             if ($throw) {
                 throw $e;
             }
-            $classReflector = false;
         }
 
         if ($this->trackResources) {
diff --git a/src/Symfony/Component/DependencyInjection/Loader/FileLoader.php b/src/Symfony/Component/DependencyInjection/Loader/FileLoader.php
@@ -149,12 +149,7 @@ private function findClasses($namespace, $pattern, $excludePattern)
             try {
                 $r = $this->container->getReflectionClass($class);
             } catch (\ReflectionException $e) {
-                $classes[$class] = sprintf(
-                    'While discovering services from namespace "%s", an error was thrown when processing the class "%s": "%s".',
-                    $namespace,
-                    $class,
-                    $e->getMessage()
-                );
+                $classes[$class] = sprintf('While discovering services from namespace "%s", an error was thrown when processing the class "%s": %s.', $namespace, $class, $e->getMessage());
                 continue;
             }
             // check to make sure the expected class exists
diff --git a/src/Symfony/Component/DependencyInjection/Tests/Compiler/AutowirePassTest.php b/src/Symfony/Component/DependencyInjection/Tests/Compiler/AutowirePassTest.php
@@ -380,7 +380,7 @@ public function testClassNotFoundThrowsException()
     public function testParentClassNotFoundThrowsException()
     {
         $this->expectException('Symfony\Component\DependencyInjection\Exception\AutowiringFailedException');
-        $this->expectExceptionMessage('Cannot autowire service "a": argument "$r" of method "Symfony\Component\DependencyInjection\Tests\Compiler\BadParentTypeHintedArgument::__construct()" has type "Symfony\Component\DependencyInjection\Tests\Compiler\OptionalServiceClass" but this class is missing a parent class (Class Symfony\Bug\NotExistClass not found).');
+        $this->expectExceptionMessageRegExp('{^Cannot autowire service "a": argument "\$r" of method "(Symfony\\\\Component\\\\DependencyInjection\\\\Tests\\\\Compiler\\\\)BadParentTypeHintedArgument::__construct\(\)" has type "\1OptionalServiceClass" but this class is missing a parent class \(Class "?Symfony\\\\Bug\\\\NotExistClass"? not found}');
 
         $container = new ContainerBuilder();
 
diff --git a/src/Symfony/Component/DependencyInjection/Tests/Loader/FileLoaderTest.php b/src/Symfony/Component/DependencyInjection/Tests/Loader/FileLoaderTest.php
@@ -178,9 +178,9 @@ public function testMissingParentClass()
 
         $this->assertTrue($container->has(MissingParent::class));
 
-        $this->assertSame(
-            ['While discovering services from namespace "Symfony\Component\DependencyInjection\Tests\Fixtures\Prototype\BadClasses\", an error was thrown when processing the class "Symfony\Component\DependencyInjection\Tests\Fixtures\Prototype\BadClasses\MissingParent": "Class Symfony\Component\DependencyInjection\Tests\Fixtures\Prototype\BadClasses\MissingClass not found".'],
-            $container->getDefinition(MissingParent::class)->getErrors()
+        $this->assertRegExp(
+            '{^While discovering services from namespace "(Symfony\\\\Component\\\\DependencyInjection\\\\Tests\\\\Fixtures\\\\Prototype\\\\BadClasses\\\\)", an error was thrown when processing the class "\1MissingParent": "?Class "?\1MissingClass"? not found}',
+            $container->getDefinition(MissingParent::class)->getErrors()[0]
         );
     }
 

Original file line number	Diff line number	Diff line change
`@@ -155,7 +155,7 @@ public static function throwOnRequiredClass($class, \Exception $previous = null)`
`155`	`155`	`throw $previous;`
`156`	`156`	`}`
`157`	`157`
`158`		`- $e = new \ReflectionException("Class $class not found", 0, $previous);`
	`158`	`+ $e = new \ReflectionException(sprintf('Class "%s" not found while loading "%s".', $class, self::$autoloadedClass), 0, $previous);`
`159`	`159`
`160`	`160`	`if (null !== $previous) {`
`161`	`161`	`throw $e;`
Original file line number	Diff line number	Diff line change
`@@ -84,7 +84,7 @@ public function testBadParentWithTimestamp()`
`84`	`84`	`public function testBadParentWithNoTimestamp()`
`85`	`85`	`{`
`86`	`86`	`$this->expectException('ReflectionException');`
`87`		`- $this->expectExceptionMessage('Class Symfony\Component\Config\Tests\Fixtures\MissingParent not found');`
	`87`	`+ $this->expectExceptionMessage('Class "Symfony\Component\Config\Tests\Fixtures\MissingParent" not found while loading "Symfony\Component\Config\Tests\Fixtures\BadParent".');`
`88`	`88`
`89`	`89`	`$res = new ClassExistenceResource(BadParent::class, false);`
`90`	`90`	`$res->isFresh(0);`
Original file line number	Diff line number	Diff line change
`@@ -361,7 +361,7 @@ public function getReflectionClass($class, $throw = true)`
`361`	`361`	`return null;`
`362`	`362`	`}`
`363`	`363`
`364`		`- $resource = null;`
	`364`	`+ $resource = $classReflector = null;`
`365`	`365`
`366`	`366`	`try {`
`367`	`367`	`if (isset($this->classReflectors[$class])) {`
`@@ -376,7 +376,6 @@ public function getReflectionClass($class, $throw = true)`
`376`	`376`	`if ($throw) {`
`377`	`377`	`throw $e;`
`378`	`378`	`}`
`379`		`- $classReflector = false;`
`380`	`379`	`}`
`381`	`380`
`382`	`381`	`if ($this->trackResources) {`
Original file line number	Diff line number	Diff line change
`@@ -380,7 +380,7 @@ public function testClassNotFoundThrowsException()`
`380`	`380`	`public function testParentClassNotFoundThrowsException()`
`381`	`381`	`{`
`382`	`382`	`$this->expectException('Symfony\Component\DependencyInjection\Exception\AutowiringFailedException');`
`383`		`- $this->expectExceptionMessage('Cannot autowire service "a": argument "$r" of method "Symfony\Component\DependencyInjection\Tests\Compiler\BadParentTypeHintedArgument::__construct()" has type "Symfony\Component\DependencyInjection\Tests\Compiler\OptionalServiceClass" but this class is missing a parent class (Class Symfony\Bug\NotExistClass not found).');`
	`383`	`+ $this->expectExceptionMessageRegExp('{^Cannot autowire service "a": argument "\$r" of method "(Symfony\\\\Component\\\\DependencyInjection\\\\Tests\\\\Compiler\\\\)BadParentTypeHintedArgument::__construct\(\)" has type "\1OptionalServiceClass" but this class is missing a parent class \(Class "?Symfony\\\\Bug\\\\NotExistClass"? not found}');`
`384`	`384`
`385`	`385`	`$container = new ContainerBuilder();`
`386`	`386`