bug #41893 [Filesystem] Workaround cannot dumpFile into "protected" folders on Windows (arnegroskurth)

fabpot · fabpot · commit e2d33fb93cfb · 2021-06-30T09:12:23.000+02:00
This PR was merged into the 4.4 branch. Discussion ---------- [Filesystem] Workaround cannot dumpFile into "protected" folders on Windows | Q | A | ------------- | --- | Branch? | 4.4 | Bug fix? | yes | New feature? | no | Deprecations? | no | Tickets | Fix #39496 | License | MIT | Doc PR | Commits ------- 4b9b68c [Filesystem] Workaround cannot dumpFile into "protected" folders on Windows
diff --git a/src/Symfony/Component/Filesystem/Filesystem.php b/src/Symfony/Component/Filesystem/Filesystem.php
@@ -678,10 +678,6 @@ public function dumpFile($filename, $content)
             $this->mkdir($dir);
         }
 
-        if (!is_writable($dir)) {
-            throw new IOException(sprintf('Unable to write to the "%s" directory.', $dir), 0, null, $dir);
-        }
-
         // Will create a temp file with 0600 access rights
         // when the filesystem supports chmod.
         $tmpFile = $this->tempnam($dir, basename($filename));
@@ -721,10 +717,6 @@ public function appendToFile($filename, $content)
             $this->mkdir($dir);
         }
 
-        if (!is_writable($dir)) {
-            throw new IOException(sprintf('Unable to write to the "%s" directory.', $dir), 0, null, $dir);
-        }
-
         if (false === @file_put_contents($filename, $content, \FILE_APPEND)) {
             throw new IOException(sprintf('Failed to write file "%s".', $filename), 0, null, $filename);
         }
diff --git a/src/Symfony/Component/Filesystem/Tests/FilesystemTest.php b/src/Symfony/Component/Filesystem/Tests/FilesystemTest.php
@@ -1756,6 +1756,27 @@ public function testCopyShouldKeepExecutionPermission()
         $this->assertFilePermissions(767, $targetFilePath);
     }
 
+    public function testDumpToProtectedDirectory()
+    {
+        if (\DIRECTORY_SEPARATOR !== '\\') {
+            $this->markTestSkipped('This test is specific to Windows.');
+        }
+
+        if (($userProfilePath = getenv('USERPROFILE')) === false || !is_dir($userProfilePath)) {
+            throw new \RuntimeException('Failed to retrieve user profile path.');
+        }
+
+        $targetPath = implode(\DIRECTORY_SEPARATOR, [$userProfilePath, 'Downloads', '__test_file.ext']);
+
+        try {
+            $this->assertFileDoesNotExist($targetPath);
+            $this->filesystem->dumpFile($targetPath, 'foobar');
+            $this->assertFileExists($targetPath);
+        } finally {
+            $this->filesystem->remove($targetPath);
+        }
+    }
+
     /**
      * Normalize the given path (transform each forward slash into a real directory separator).
      */

Original file line number	Diff line number	Diff line change
`@@ -678,10 +678,6 @@ public function dumpFile($filename, $content)`
`678`	`678`	`$this->mkdir($dir);`
`679`	`679`	`}`
`680`	`680`
`681`		`- if (!is_writable($dir)) {`
`682`		`- throw new IOException(sprintf('Unable to write to the "%s" directory.', $dir), 0, null, $dir);`
`683`		`- }`
`684`		`-`
`685`	`681`	`// Will create a temp file with 0600 access rights`
`686`	`682`	`// when the filesystem supports chmod.`
`687`	`683`	`$tmpFile = $this->tempnam($dir, basename($filename));`
`@@ -721,10 +717,6 @@ public function appendToFile($filename, $content)`
`721`	`717`	`$this->mkdir($dir);`
`722`	`718`	`}`
`723`	`719`
`724`		`- if (!is_writable($dir)) {`
`725`		`- throw new IOException(sprintf('Unable to write to the "%s" directory.', $dir), 0, null, $dir);`
`726`		`- }`
`727`		`-`
`728`	`720`	`if (false === @file_put_contents($filename, $content, \FILE_APPEND)) {`
`729`	`721`	`throw new IOException(sprintf('Failed to write file "%s".', $filename), 0, null, $filename);`
`730`	`722`	`}`