Fix LockStoreSchemaListener not working properly with iterable objects

barton-webwings · barton-webwings · commit e65178d6420b · 2024-03-26T14:49:20.000+01:00
diff --git a/src/Symfony/Bridge/Doctrine/SchemaListener/LockStoreSchemaListener.php b/src/Symfony/Bridge/Doctrine/SchemaListener/LockStoreSchemaListener.php
@@ -30,10 +30,8 @@ public function postGenerateSchema(GenerateSchemaEventArgs $event): void
     {
         $connection = $event->getEntityManager()->getConnection();
 
-        $storesIterator = new \ArrayIterator($this->stores);
-        while ($storesIterator->valid()) {
+        foreach ($this->stores as $store) {
             try {
-                $store = $storesIterator->current();
                 if (!$store instanceof DoctrineDbalStore) {
                     continue;
                 }
@@ -42,8 +40,6 @@ public function postGenerateSchema(GenerateSchemaEventArgs $event): void
             } catch (InvalidArgumentException) {
                 // no-op
             }
-
-            $storesIterator->next();
         }
     }
 }

Original file line number	Diff line number	Diff line change
`@@ -30,10 +30,8 @@ public function postGenerateSchema(GenerateSchemaEventArgs $event): void`
`30`	`30`	`{`
`31`	`31`	`$connection = $event->getEntityManager()->getConnection();`
`32`	`32`
`33`		`- $storesIterator = new \ArrayIterator($this->stores);`
`34`		`- while ($storesIterator->valid()) {`
	`33`	`+ foreach ($this->stores as $store) {`
`35`	`34`	`try {`
`36`		`- $store = $storesIterator->current();`
`37`	`35`	`if (!$store instanceof DoctrineDbalStore) {`
`38`	`36`	`continue;`
`39`	`37`	`}`
`@@ -42,8 +40,6 @@ public function postGenerateSchema(GenerateSchemaEventArgs $event): void`
`42`	`40`	`} catch (InvalidArgumentException) {`
`43`	`41`	`// no-op`
`44`	`42`	`}`
`45`		`-`
`46`		`- $storesIterator->next();`
`47`	`43`	`}`
`48`	`44`	`}`
`49`	`45`	`}`