minor #42384 [HttpFoundation] Fix broken mock (derrabus)

Tobion · Tobion · commit e6c9155ead2c · 2021-08-05T12:41:36.000+02:00
This PR was merged into the 4.4 branch. Discussion ---------- [HttpFoundation] Fix broken mock | Q | A | ------------- | --- | Branch? | 4.4 | Bug fix? | yes | New feature? | no | Deprecations? | no | Tickets | N/A | License | MIT | Doc PR | N/A Backport from #42378. This PR fixes a couple of mocked methods that currently return `null` although a real implementation would never do that. Commits ------- af37c64 Fix broken mock
diff --git a/src/Symfony/Component/HttpFoundation/Tests/Session/Storage/Proxy/SessionHandlerProxyTest.php b/src/Symfony/Component/HttpFoundation/Tests/Session/Storage/Proxy/SessionHandlerProxyTest.php
@@ -103,17 +103,21 @@ public function testRead()
     public function testWrite()
     {
         $this->mock->expects($this->once())
-            ->method('write');
+            ->method('write')
+            ->willReturn(true)
+        ;
 
-        $this->proxy->write('id', 'data');
+        $this->assertTrue($this->proxy->write('id', 'data'));
     }
 
     public function testDestroy()
     {
         $this->mock->expects($this->once())
-            ->method('destroy');
+            ->method('destroy')
+            ->willReturn(true)
+        ;
 
-        $this->proxy->destroy('id');
+        $this->assertTrue($this->proxy->destroy('id'));
     }
 
     public function testGc()
@@ -149,7 +153,9 @@ public function testUpdateTimestamp()
         $proxy->updateTimestamp('id', 'data');
 
         $this->mock->expects($this->once())
-            ->method('write');
+            ->method('write')
+            ->willReturn(true)
+        ;
 
         $this->proxy->updateTimestamp('id', 'data');
     }
