bug #26955 [DebugBundle][VarDumper] Fix server dumper placeholder command (ogizanagi)

nicolas-grekas · nicolas-grekas · commit e6f99da5ca52 · 2018-05-01T16:13:51.000-07:00
This PR was merged into the 4.1-dev branch. Discussion ---------- [DebugBundle][VarDumper] Fix server dumper placeholder command | Q | A | ------------- | --- | Branch? | master  | Bug fix? | no, fixes a deprecation warning | New feature? | no  | BC breaks? | no  | Deprecations? | no, fixes ones  | Tests pass? | yes  | Fixed tickets | #26944  | License | MIT | Doc PR | N/A This placeholder command was addressed in quite an unorthodox fashion and the following fix isn't really better, but I guess that's fine for an internal class. _As a reminder: this command aims to favor discoverability of the `ServerDumpCommand` when listing available commands and by exposing its definition so you can read about it by using `--help`. Execution hints about the `debug.dump_destination` config option required to wire the actual command._ That's the only command for which we're doing this, though. So better keep this placeholder or drop it? Commits ------- 60af39b [DebugBundle][VarDumper] Fix server dumper placeholder command
diff --git a/src/Symfony/Bundle/DebugBundle/Command/ServerDumpPlaceholderCommand.php b/src/Symfony/Bundle/DebugBundle/Command/ServerDumpPlaceholderCommand.php
@@ -11,6 +11,7 @@
 
 namespace Symfony\Bundle\DebugBundle\Command;
 
+use Symfony\Component\Console\Command\Command;
 use Symfony\Component\Console\Input\InputInterface;
 use Symfony\Component\Console\Output\OutputInterface;
 use Symfony\Component\Console\Style\SymfonyStyle;
@@ -24,15 +25,22 @@
  *
  * @internal
  */
-class ServerDumpPlaceholderCommand extends ServerDumpCommand
+class ServerDumpPlaceholderCommand extends Command
 {
+    private $replacedCommand;
+
     public function __construct(DumpServer $server = null, array $descriptors = array())
     {
-        parent::__construct(new class() extends DumpServer {
-            public function __construct()
-            {
-            }
-        }, $descriptors);
+        $this->replacedCommand = new ServerDumpCommand((new \ReflectionClass(DumpServer::class))->newInstanceWithoutConstructor(), $descriptors);
+
+        parent::__construct();
+    }
+
+    protected function configure()
+    {
+        $this->setDefinition($this->replacedCommand->getDefinition());
+        $this->setHelp($this->replacedCommand->getHelp());
+        $this->setDescription($this->replacedCommand->getDescription());
     }
 
     protected function execute(InputInterface $input, OutputInterface $output)
