Add negatable option to Fish completion output

GromNaN · GromNaN · commit e7e0485de0b2 · 2022-05-18T08:13:04.000+02:00
diff --git a/src/Symfony/Component/Console/Completion/Output/FishCompletionOutput.php b/src/Symfony/Component/Console/Completion/Output/FishCompletionOutput.php
@@ -24,6 +24,9 @@ public function write(CompletionSuggestions $suggestions, OutputInterface $outpu
         $values = $suggestions->getValueSuggestions();
         foreach ($suggestions->getOptionSuggestions() as $option) {
             $values[] = '--'.$option->getName();
+            if ($option->isNegatable()) {
+                $values[] = '--no-'.$option->getName();
+            }
         }
         $output->write(implode("\n", $values));
     }
diff --git a/src/Symfony/Component/Console/Tests/Completion/Output/FishCompletionOutputTest.php b/src/Symfony/Component/Console/Tests/Completion/Output/FishCompletionOutputTest.php
@@ -0,0 +1,33 @@
+<?php
+
+/*
+ * This file is part of the Symfony package.
+ *
+ * (c) Fabien Potencier <fabien@symfony.com>
+ *
+ * For the full copyright and license information, please view the LICENSE
+ * file that was distributed with this source code.
+ */
+
+namespace Symfony\Component\Console\Tests\Completion\Output;
+
+use Symfony\Component\Console\Completion\Output\CompletionOutputInterface;
+use Symfony\Component\Console\Completion\Output\FishCompletionOutput;
+
+class FishCompletionOutputTest extends CompletionOutputTestCase
+{
+    public function getCompletionOutput(): CompletionOutputInterface
+    {
+        return new FishCompletionOutput();
+    }
+
+    public function getExpectedOptionsOutput(): string
+    {
+        return "--option1\n--negatable\n--no-negatable";
+    }
+
+    public function getExpectedValuesOutput(): string
+    {
+        return "Green\nRed\nYellow";
+    }
+}

Original file line number	Diff line number	Diff line change
`@@ -24,6 +24,9 @@ public function write(CompletionSuggestions $suggestions, OutputInterface $outpu`
`24`	`24`	`$values = $suggestions->getValueSuggestions();`
`25`	`25`	`foreach ($suggestions->getOptionSuggestions() as $option) {`
`26`	`26`	`$values[] = '--'.$option->getName();`
	`27`	`+ if ($option->isNegatable()) {`
	`28`	`+ $values[] = '--no-'.$option->getName();`
	`29`	`+ }`
`27`	`30`	`}`
`28`	`31`	`$output->write(implode("\n", $values));`
`29`	`32`	`}`