[Config] dont catch instances of Error

nicolas-grekas · nicolas-grekas · commit e94c3fb87d69 · 2020-02-03T09:11:57.000+01:00
diff --git a/src/Symfony/Component/Config/Resource/ClassExistenceResource.php b/src/Symfony/Component/Config/Resource/ClassExistenceResource.php
@@ -92,6 +92,8 @@ public function isFresh($timestamp)
                 }
             } catch (\Throwable $e) {
                 $exists[1] = $e->getMessage();
+
+                throw $e;
             } finally {
                 self::$autoloadedClass = $autoloadedClass;
                 if (!--self::$autoloadLevel) {
diff --git a/src/Symfony/Component/Config/Tests/Fixtures/ParseError.php b/src/Symfony/Component/Config/Tests/Fixtures/ParseError.php
@@ -0,0 +1,7 @@
+<?php
+
+namespace Symfony\Component\Config\Tests\Fixtures;
+
+class ParseError
+{
+// missing closing bracket
diff --git a/src/Symfony/Component/Config/Tests/Resource/ClassExistenceResourceTest.php b/src/Symfony/Component/Config/Tests/Resource/ClassExistenceResourceTest.php
@@ -15,6 +15,7 @@
 use Symfony\Component\Config\Resource\ClassExistenceResource;
 use Symfony\Component\Config\Tests\Fixtures\BadFileName;
 use Symfony\Component\Config\Tests\Fixtures\BadParent;
+use Symfony\Component\Config\Tests\Fixtures\ParseError;
 use Symfony\Component\Config\Tests\Fixtures\Resource\ConditionalClass;
 
 class ClassExistenceResourceTest extends TestCase
@@ -115,4 +116,15 @@ public function testConditionalClass()
 
         $this->assertFalse($res->isFresh(0));
     }
+
+    /**
+     * @requires PHP 7
+     */
+    public function testParseError()
+    {
+        $this->expectException('ParseError');
+
+        $res = new ClassExistenceResource(ParseError::class, false);
+        $res->isFresh(0);
+    }
 }

Original file line number	Diff line number	Diff line change
`@@ -92,6 +92,8 @@ public function isFresh($timestamp)`
`92`	`92`	`}`
`93`	`93`	`} catch (\Throwable $e) {`
`94`	`94`	`$exists[1] = $e->getMessage();`
	`95`	`+`
	`96`	`+ throw $e;`
`95`	`97`	`} finally {`
`96`	`98`	`self::$autoloadedClass = $autoloadedClass;`
`97`	`99`	`if (!--self::$autoloadLevel) {`