Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Commit e9b5e37

Browse files
alexandre-dauboisalexandre-daubois
committed
[Tests] New iteration of removing $this occurrences in future static data providers
1 parent 4ae23e6 commit e9b5e37

14 files changed

+128
-119
lines changed

‎src/Symfony/Component/Asset/Tests/VersionStrategy/JsonManifestVersionStrategyTest.php

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -82,22 +82,22 @@ public function testRemoteManifestFileWithoutHttpClient()
8282
new JsonManifestVersionStrategy('https://cdn.example.com/manifest.json');
8383
}
8484

85-
public function provideValidStrategies()
85+
public static function provideValidStrategies(): \Generator
8686
{
87-
yield from $this->provideStrategies('manifest-valid.json');
87+
yield from static::provideStrategies('manifest-valid.json');
8888
}
8989

90-
public function provideInvalidStrategies()
90+
public static function provideInvalidStrategies(): \Generator
9191
{
92-
yield from $this->provideStrategies('manifest-invalid.json');
92+
yield from static::provideStrategies('manifest-invalid.json');
9393
}
9494

95-
public function provideMissingStrategies()
95+
public static function provideMissingStrategies(): \Generator
9696
{
97-
yield from $this->provideStrategies('non-existent-file.json');
97+
yield from static::provideStrategies('non-existent-file.json');
9898
}
9999

100-
public function provideStrategies(string $manifestPath)
100+
public static function provideStrategies(string $manifestPath): \Generator
101101
{
102102
$httpClient = new MockHttpClient(function ($method, $url, $options) {
103103
$filename = __DIR__.'/../fixtures/'.basename($url);
@@ -114,7 +114,7 @@ public function provideStrategies(string $manifestPath)
114114
yield [new JsonManifestVersionStrategy(__DIR__.'/../fixtures/'.$manifestPath)];
115115
}
116116

117-
public function provideStrictStrategies()
117+
public static function provideStrictStrategies(): \Generator
118118
{
119119
$strategy = new JsonManifestVersionStrategy(__DIR__.'/../fixtures/manifest-valid.json', null, true);
120120

‎src/Symfony/Component/Finder/Tests/Iterator/DateRangeFilterIteratorTest.php

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@ class DateRangeFilterIteratorTest extends RealIteratorTestCase
2222
public function testAccept($size, $expected)
2323
{
2424
$files = self::$files;
25-
$files[] = self::toAbsolute('doesnotexist');
25+
$files[] = static::toAbsolute('doesnotexist');
2626
$inner = new Iterator($files);
2727

2828
$iterator = new DateRangeFilterIterator($inner, $size);
@@ -84,9 +84,9 @@ public function getAcceptData()
8484
];
8585

8686
return [
87-
[[new DateComparator('since 20 years ago')], $this->toAbsolute($since20YearsAgo)],
88-
[[new DateComparator('since 2 months ago')], $this->toAbsolute($since2MonthsAgo)],
89-
[[new DateComparator('until last month')], $this->toAbsolute($untilLastMonth)],
87+
[[new DateComparator('since 20 years ago')], static::toAbsolute($since20YearsAgo)],
88+
[[new DateComparator('since 2 months ago')], static::toAbsolute($since2MonthsAgo)],
89+
[[new DateComparator('until last month')], static::toAbsolute($untilLastMonth)],
9090
];
9191
}
9292
}

‎src/Symfony/Component/Intl/Tests/DateFormatter/AbstractIntlDateFormatterTest.php

Lines changed: 19 additions & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -588,25 +588,25 @@ public function testParse($pattern, $value, $expected)
588588
public function parseProvider()
589589
{
590590
return array_merge(
591-
$this->parseYearProvider(),
592-
$this->parseQuarterProvider(),
593-
$this->parseMonthProvider(),
594-
$this->parseStandaloneMonthProvider(),
595-
$this->parseDayProvider(),
596-
$this->parseDayOfWeekProvider(),
597-
$this->parseDayOfYearProvider(),
598-
$this->parseHour12ClockOneBasedProvider(),
599-
$this->parseHour12ClockZeroBasedProvider(),
600-
$this->parseHour24ClockOneBasedProvider(),
601-
$this->parseHour24ClockZeroBasedProvider(),
602-
$this->parseMinuteProvider(),
603-
$this->parseSecondProvider(),
604-
$this->parseTimezoneProvider(),
605-
$this->parseAmPmProvider(),
606-
$this->parseStandaloneAmPmProvider(),
607-
$this->parseRegexMetaCharsProvider(),
608-
$this->parseQuoteCharsProvider(),
609-
$this->parseDashSlashProvider()
591+
static::parseYearProvider(),
592+
static::parseQuarterProvider(),
593+
static::parseMonthProvider(),
594+
static::parseStandaloneMonthProvider(),
595+
static::parseDayProvider(),
596+
static::parseDayOfWeekProvider(),
597+
static::parseDayOfYearProvider(),
598+
static::parseHour12ClockOneBasedProvider(),
599+
static::parseHour12ClockZeroBasedProvider(),
600+
static::parseHour24ClockOneBasedProvider(),
601+
static::parseHour24ClockZeroBasedProvider(),
602+
static::parseMinuteProvider(),
603+
static::parseSecondProvider(),
604+
static::parseTimezoneProvider(),
605+
static::parseAmPmProvider(),
606+
static::parseStandaloneAmPmProvider(),
607+
static::parseRegexMetaCharsProvider(),
608+
static::parseQuoteCharsProvider(),
609+
static::parseDashSlashProvider()
610610
);
611611
}
612612

0 commit comments

Comments
 (0)