Fix psalm error

louismariegaborit · louismariegaborit · commit ea1da0751e44 · 2024-01-23T06:00:01.000+01:00
diff --git a/src/Symfony/Bundle/SecurityBundle/DependencyInjection/Security/Factory/SignatureAlgorithmFactory.php b/src/Symfony/Bundle/SecurityBundle/DependencyInjection/Security/Factory/SignatureAlgorithmFactory.php
@@ -25,27 +25,25 @@ final class SignatureAlgorithmFactory
 {
     public static function create(string $algorithm): AlgorithmInterface
     {
+        $algorithmFqcn = Algorithm::class.'\\'.$algorithm;
+
         switch ($algorithm) {
             case 'ES256':
             case 'ES384':
             case 'ES512':
-                if (!class_exists(Algorithm::class.'\\'.$algorithm)) {
+                if (!class_exists($algorithmFqcn)) {
                     throw new \LogicException(sprintf('You cannot use the "%s" signature algorithm since "web-token/jwt-signature-algorithm-ecdsa" is not installed. Try running "composer require web-token/jwt-signature-algorithm-ecdsa".', $algorithm));
                 }
-
-                $algorithm = Algorithm::class.'\\'.$algorithm;
                 break;
             case 'RS256':
-                if (!class_exists(Algorithm::class.'\\'.$algorithm)) {
+                if (!class_exists($algorithmFqcn)) {
                     throw new \LogicException(sprintf('You cannot use the "%s" signature algorithm since "web-token/jwt-signature-algorithm-rsa" is not installed. Try running "composer require web-token/jwt-signature-algorithm-rsa".', $algorithm));
                 }
-
-                $algorithm = Algorithm::class.'\\'.$algorithm;
                 break;
             default:
                 throw new InvalidArgumentException(sprintf('Unsupported signature algorithm "%s". Only ES* and RS256 algorithms are supported. If you want to use another algorithm, create your TokenHandler as a service.', $algorithm));
         }
 
-        return new $algorithm();
+        return new $algorithmFqcn();
     }
 }

Original file line number	Diff line number	Diff line change
`@@ -25,27 +25,25 @@ final class SignatureAlgorithmFactory`
`25`	`25`	`{`
`26`	`26`	`public static function create(string $algorithm): AlgorithmInterface`
`27`	`27`	`{`
	`28`	`+ $algorithmFqcn = Algorithm::class.'\\'.$algorithm;`
	`29`	`+`
`28`	`30`	`switch ($algorithm) {`
`29`	`31`	`case 'ES256':`
`30`	`32`	`case 'ES384':`
`31`	`33`	`case 'ES512':`
`32`		`- if (!class_exists(Algorithm::class.'\\'.$algorithm)) {`
	`34`	`+ if (!class_exists($algorithmFqcn)) {`
`33`	`35`	`throw new \LogicException(sprintf('You cannot use the "%s" signature algorithm since "web-token/jwt-signature-algorithm-ecdsa" is not installed. Try running "composer require web-token/jwt-signature-algorithm-ecdsa".', $algorithm));`
`34`	`36`	`}`
`35`		`-`
`36`		`- $algorithm = Algorithm::class.'\\'.$algorithm;`
`37`	`37`	`break;`
`38`	`38`	`case 'RS256':`
`39`		`- if (!class_exists(Algorithm::class.'\\'.$algorithm)) {`
	`39`	`+ if (!class_exists($algorithmFqcn)) {`
`40`	`40`	`throw new \LogicException(sprintf('You cannot use the "%s" signature algorithm since "web-token/jwt-signature-algorithm-rsa" is not installed. Try running "composer require web-token/jwt-signature-algorithm-rsa".', $algorithm));`
`41`	`41`	`}`
`42`		`-`
`43`		`- $algorithm = Algorithm::class.'\\'.$algorithm;`
`44`	`42`	`break;`
`45`	`43`	`default:`
`46`	`44`	`throw new InvalidArgumentException(sprintf('Unsupported signature algorithm "%s". Only ES* and RS256 algorithms are supported. If you want to use another algorithm, create your TokenHandler as a service.', $algorithm));`
`47`	`45`	`}`
`48`	`46`
`49`		`- return new $algorithm();`
	`47`	`+ return new $algorithmFqcn();`
`50`	`48`	`}`
`51`	`49`	`}`