only call serialize once for better performance

dbu · dbu · commit ea4f387fdf3e · 2019-04-07T15:55:23.000+02:00
diff --git a/src/Symfony/Component/Serializer/Normalizer/AbstractObjectNormalizer.php b/src/Symfony/Component/Serializer/Normalizer/AbstractObjectNormalizer.php
@@ -371,7 +371,9 @@ private function isMaxDepthReached(array $attributesMetadata, $class, $attribute
     }
 
     /**
-     * Overwrite to update the cache key for the child.
+     * Overwritten to update the cache key for the child.
+     *
+     * We must not mix up the attribute cache between parent and children.
      *
      * {@inheritdoc}
      */
@@ -385,7 +387,7 @@ protected function createChildContext(array $parentContext, $attribute)
     }
 
     /**
-     * Build the cache key for the attributes cache.
+     * Builds the cache key for the attributes cache.
      *
      * The key must be different for every option in the context that could change which attributes should be handled.
      *
@@ -397,7 +399,11 @@ protected function createChildContext(array $parentContext, $attribute)
     private function getAttributeCacheKey($format, array $context)
     {
         try {
-            return md5($format.serialize($context).serialize($this->ignoredAttributes)).serialize($this->camelizedAttributes);
+            return md5($format.serialize([
+                'context' => $context,
+                'ignored' => $this->ignoredAttributes,
+                'camelized' => $this->camelizedAttributes,
+            ]));
         } catch (\Exception $exception) {
             // The context cannot be serialized, skip the cache
             return false;

Original file line number	Diff line number	Diff line change
`@@ -371,7 +371,9 @@ private function isMaxDepthReached(array $attributesMetadata, $class, $attribute`
`371`	`371`	`}`
`372`	`372`
`373`	`373`	`/**`
`374`		`- * Overwrite to update the cache key for the child.`
	`374`	`+ * Overwritten to update the cache key for the child.`
	`375`	`+ *`
	`376`	`+ * We must not mix up the attribute cache between parent and children.`
`375`	`377`	`*`
`376`	`378`	`* {@inheritdoc}`
`377`	`379`	`*/`
`@@ -385,7 +387,7 @@ protected function createChildContext(array $parentContext, $attribute)`
`385`	`387`	`}`
`386`	`388`
`387`	`389`	`/**`
`388`		`- * Build the cache key for the attributes cache.`
	`390`	`+ * Builds the cache key for the attributes cache.`
`389`	`391`	`*`
`390`	`392`	`* The key must be different for every option in the context that could change which attributes should be handled.`
`391`	`393`	`*`
`@@ -397,7 +399,11 @@ protected function createChildContext(array $parentContext, $attribute)`
`397`	`399`	`private function getAttributeCacheKey($format, array $context)`
`398`	`400`	`{`
`399`	`401`	`try {`
`400`		`- return md5($format.serialize($context).serialize($this->ignoredAttributes)).serialize($this->camelizedAttributes);`
	`402`	`+ return md5($format.serialize([`
	`403`	`+ 'context' => $context,`
	`404`	`+ 'ignored' => $this->ignoredAttributes,`
	`405`	`+ 'camelized' => $this->camelizedAttributes,`
	`406`	`+ ]));`
`401`	`407`	`} catch (\Exception $exception) {`
`402`	`408`	`// The context cannot be serialized, skip the cache`
`403`	`409`	`return false;`