Handle fetch mode deprecation of DBAL 2.11.

derrabus · derrabus · commit ed518551e119 · 2020-05-28T09:55:04.000+02:00
diff --git a/src/Symfony/Bridge/Doctrine/Security/RememberMe/DoctrineTokenProvider.php b/src/Symfony/Bridge/Doctrine/Security/RememberMe/DoctrineTokenProvider.php
@@ -63,7 +63,7 @@ public function loadTokenBySeries($series)
         $paramValues = ['series' => $series];
         $paramTypes = ['series' => \PDO::PARAM_STR];
         $stmt = $this->conn->executeQuery($sql, $paramValues, $paramTypes);
-        $row = $stmt->fetch(\PDO::FETCH_ASSOC);
+        $row = method_exists($stmt, 'fetchAssociative') ? $stmt->fetchAssociative() : $stmt->fetch(\PDO::FETCH_ASSOC);
 
         if ($row) {
             return new PersistentToken($row['class'], $row['username'], $series, $row['value'], new \DateTime($row['last_used']));
diff --git a/src/Symfony/Bridge/Doctrine/Tests/Security/RememberMe/DoctrineTokenProviderTest.php b/src/Symfony/Bridge/Doctrine/Tests/Security/RememberMe/DoctrineTokenProviderTest.php
@@ -0,0 +1,88 @@
+<?php
+
+namespace Security\RememberMe;
+
+use Doctrine\DBAL\DriverManager;
+use PHPUnit\Framework\TestCase;
+use Symfony\Bridge\Doctrine\Security\RememberMe\DoctrineTokenProvider;
+use Symfony\Component\Security\Core\Authentication\RememberMe\PersistentToken;
+use Symfony\Component\Security\Core\Exception\TokenNotFoundException;
+
+/**
+ * @requires extension pdo_sqlite
+ */
+class DoctrineTokenProviderTest extends TestCase
+{
+    public static function setUpBeforeClass()
+    {
+        if (\PHP_VERSION_ID >= 80000) {
+            self::markTestSkipped('Doctrine DBAL 2.x is incompatible with PHP 8.');
+        }
+    }
+
+    public function testCreateNewToken()
+    {
+        $provider = $this->bootstrapProvider();
+
+        $token = new PersistentToken('someClass', 'someUser', 'someSeries', 'tokenValue', new \DateTime('2013-01-26T18:23:51'));
+        $provider->createNewToken($token);
+
+        $this->assertEquals($provider->loadTokenBySeries('someSeries'), $token);
+    }
+
+    public function testLoadTokenBySeriesThrowsNotFoundException()
+    {
+        $provider = $this->bootstrapProvider();
+
+        $this->expectException(TokenNotFoundException::class);
+        $provider->loadTokenBySeries('someSeries');
+    }
+
+    public function testUpdateToken()
+    {
+        $provider = $this->bootstrapProvider();
+
+        $token = new PersistentToken('someClass', 'someUser', 'someSeries', 'tokenValue', new \DateTime('2013-01-26T18:23:51'));
+        $provider->createNewToken($token);
+        $provider->updateToken('someSeries', 'newValue', $lastUsed = new \DateTime('2014-06-26T22:03:46'));
+        $token = $provider->loadTokenBySeries('someSeries');
+
+        $this->assertEquals('newValue', $token->getTokenValue());
+        $this->assertEquals($token->getLastUsed(), $lastUsed);
+    }
+
+    public function testDeleteToken()
+    {
+        $provider = $this->bootstrapProvider();
+        $token = new PersistentToken('someClass', 'someUser', 'someSeries', 'tokenValue', new \DateTime('2013-01-26T18:23:51'));
+        $provider->createNewToken($token);
+        $provider->deleteTokenBySeries('someSeries');
+
+        $this->expectException(TokenNotFoundException::class);
+
+        $provider->loadTokenBySeries('someSeries');
+    }
+
+    /**
+     * @return DoctrineTokenProvider
+     */
+    private function bootstrapProvider()
+    {
+        $connection = DriverManager::getConnection([
+            'driver' => 'pdo_sqlite',
+            'url' => 'sqlite:///:memory:',
+        ]);
+        $connection->executeUpdate(<<< 'SQL'
+            CREATE TABLE rememberme_token (
+                series   char(88)     UNIQUE PRIMARY KEY NOT NULL,
+                value    char(88)     NOT NULL,
+                lastUsed datetime     NOT NULL,
+                class    varchar(100) NOT NULL,
+                username varchar(200) NOT NULL
+            );
+SQL
+        );
+
+        return new DoctrineTokenProvider($connection);
+    }
+}
diff --git a/src/Symfony/Component/Cache/Tests/Traits/PdoPruneableTrait.php b/src/Symfony/Component/Cache/Tests/Traits/PdoPruneableTrait.php
@@ -24,11 +24,11 @@ protected function isPruned($cache, $name)
         $getPdoConn = $o->getMethod('getConnection');
         $getPdoConn->setAccessible(true);
 
-        /** @var \Doctrine\DBAL\Statement $select */
+        /** @var \Doctrine\DBAL\Statement|\PDOStatement $select */
         $select = $getPdoConn->invoke($cache)->prepare('SELECT 1 FROM cache_items WHERE item_id LIKE :id');
         $select->bindValue(':id', sprintf('%%%s', $name));
         $select->execute();
 
-        return 0 === \count($select->fetchAll(\PDO::FETCH_COLUMN));
+        return 1 !== (int) (method_exists($select, 'fetchOne') ? $select->fetchOne() : $select->fetch(\PDO::FETCH_COLUMN));
     }
 }
diff --git a/src/Symfony/Component/Cache/Traits/PdoTrait.php b/src/Symfony/Component/Cache/Traits/PdoTrait.php
@@ -177,7 +177,13 @@ protected function doFetch(array $ids)
         }
         $stmt->execute();
 
-        while ($row = $stmt->fetch(\PDO::FETCH_NUM)) {
+        if (method_exists($stmt, 'iterateNumeric')) {
+            $stmt = $stmt->iterateNumeric();
+        } else {
+            $stmt->setFetchMode(\PDO::FETCH_NUM);
+        }
+
+        foreach ($stmt as $row) {
             if (null === $row[1]) {
                 $expired[] = $row[0];
             } else {

Original file line number	Diff line number	Diff line change
`@@ -24,11 +24,11 @@ protected function isPruned($cache, $name)`
`24`	`24`	`$getPdoConn = $o->getMethod('getConnection');`
`25`	`25`	`$getPdoConn->setAccessible(true);`
`26`	`26`
`27`		`- /** @var \Doctrine\DBAL\Statement $select */`
	`27`	`+ /** @var \Doctrine\DBAL\Statement\|\PDOStatement $select */`
`28`	`28`	`$select = $getPdoConn->invoke($cache)->prepare('SELECT 1 FROM cache_items WHERE item_id LIKE :id');`
`29`	`29`	`$select->bindValue(':id', sprintf('%%%s', $name));`
`30`	`30`	`$select->execute();`
`31`	`31`
`32`		`- return 0 === \count($select->fetchAll(\PDO::FETCH_COLUMN));`
	`32`	`+ return 1 !== (int) (method_exists($select, 'fetchOne') ? $select->fetchOne() : $select->fetch(\PDO::FETCH_COLUMN));`
`33`	`33`	`}`
`34`	`34`	`}`