test: discriminator withou matching property

soyuka · soyuka · commit ee61a55f5925 · 2023-05-30T14:12:44.000+02:00
diff --git a/src/Symfony/Component/Serializer/Tests/Fixtures/AbstractWithDiscriminator.php b/src/Symfony/Component/Serializer/Tests/Fixtures/AbstractWithDiscriminator.php
@@ -0,0 +1,39 @@
+<?php
+
+/*
+ * This file is part of the API Platform project.
+ *
+ * (c) Kévin Dunglas <dunglas@gmail.com>
+ *
+ * For the full copyright and license information, please view the LICENSE
+ * file that was distributed with this source code.
+ */
+
+declare(strict_types=1);
+
+/*
+ * This file is part of the Symfony package.
+ *
+ * (c) Fabien Potencier <fabien@symfony.com>
+ *
+ * For the full copyright and license information, please view the LICENSE
+ * file that was distributed with this source code.
+ */
+
+namespace Symfony\Component\Serializer\Tests\Fixtures;
+
+use Symfony\Component\Serializer\Annotation\DiscriminatorMap;
+
+#[DiscriminatorMap(typeProperty: 'discr', mapping: ['concrete' => ConcreteWithDiscriminator::class])]
+abstract class AbstractWithDiscriminator
+{
+    /**
+     * @var int The id
+     */
+    public ?int $id = null;
+
+    /**
+     * @var string The dummy name
+     */
+    public string $name;
+}
diff --git a/src/Symfony/Component/Serializer/Tests/Fixtures/ConcreteWithDiscriminator.php b/src/Symfony/Component/Serializer/Tests/Fixtures/ConcreteWithDiscriminator.php
@@ -0,0 +1,20 @@
+<?php
+
+/*
+ * This file is part of the Symfony package.
+ *
+ * (c) Fabien Potencier <fabien@symfony.com>
+ *
+ * For the full copyright and license information, please view the LICENSE
+ * file that was distributed with this source code.
+ */
+
+namespace Symfony\Component\Serializer\Tests\Fixtures;
+
+class ConcreteWithDiscriminator extends AbstractWithDiscriminator
+{
+    /**
+     * @var string a concrete thing
+     */
+    public string $instance;
+}
diff --git a/src/Symfony/Component/Serializer/Tests/Normalizer/AbstractObjectNormalizerTest.php b/src/Symfony/Component/Serializer/Tests/Normalizer/AbstractObjectNormalizerTest.php
@@ -41,9 +41,11 @@
 use Symfony\Component\Serializer\Serializer;
 use Symfony\Component\Serializer\SerializerAwareInterface;
 use Symfony\Component\Serializer\SerializerInterface;
+use Symfony\Component\Serializer\Tests\Fixtures\AbstractWithDiscriminator;
 use Symfony\Component\Serializer\Tests\Fixtures\Annotations\AbstractDummy;
 use Symfony\Component\Serializer\Tests\Fixtures\Annotations\AbstractDummyFirstChild;
 use Symfony\Component\Serializer\Tests\Fixtures\Annotations\AbstractDummySecondChild;
+use Symfony\Component\Serializer\Tests\Fixtures\ConcreteWithDiscriminator;
 use Symfony\Component\Serializer\Tests\Fixtures\DummySecondChildQuux;
 use Symfony\Component\Serializer\Tests\Normalizer\Features\ObjectDummyWithContextAttribute;
 
@@ -302,6 +304,39 @@ public function testNormalizeWithNestedAttributesInConstructor()
         ], $test);
     }
 
+    public function testDenormalizeWithDiscriminatorMapNotMappedToAProperty()
+    {
+        $factory = new ClassMetadataFactory(new AnnotationLoader(new AnnotationReader()));
+
+        $loaderMock = new class() implements ClassMetadataFactoryInterface {
+            public function getMetadataFor($value): ClassMetadataInterface
+            {
+                if (ConcreteWithDiscriminator::class === $value) {
+                    return new ClassMetadata(
+                        AbstractWithDiscriminator::class,
+                        new ClassDiscriminatorMapping('discr', [
+                            'first' => ConcreteWithDiscriminator::class,
+                        ])
+                    );
+                }
+
+                throw new InvalidArgumentException();
+            }
+
+            public function hasMetadataFor($value): bool
+            {
+                return ConcreteWithDiscriminator::class === $value;
+            }
+        };
+
+        $discriminatorResolver = new ClassDiscriminatorFromClassMetadata($loaderMock);
+        $normalizer = new AbstractObjectNormalizerDummy($factory, null, new PhpDocExtractor(), $discriminatorResolver);
+        $serializer = new Serializer([$normalizer]);
+        $normalizer->setSerializer($serializer);
+
+        $this->assertInstanceOf(AbstractWithDiscriminator::class, $normalizer->denormalize(['id' => 0, 'instance' => 'test', 'name' => 'test'], ConcreteWithDiscriminator::class, 'any'));
+    }
+
     public function testNormalizeWithNestedAttributesInConstructorAndDiscriminatorMap()
     {
         $classMetadataFactory = new ClassMetadataFactory(new AnnotationLoader(new AnnotationReader()));
