bug #39717 [TwigBridge] Remove full head content in HTML to text converter (pupaxxo)

fabpot · fabpot · commit ef11c2c6b484 · 2021-01-05T07:02:58.000+01:00
This PR was merged into the 4.4 branch. Discussion ---------- [TwigBridge] Remove full head content in HTML to text converter When extracting text from HTML part all the content between opening and closing tag should be removed | Q | A | ------------- | --- | Branch? | 4.4  | Bug fix? | yes | New feature? | no  | Deprecations? | no  | Tickets |  | License | MIT | Doc PR | symfony/symfony-docs#...   Without the `s` flag the preg_replace match only head (or style) tags on a single line Commits ------- 9e6baee Remove full head content in HTML to text converter
diff --git a/src/Symfony/Bridge/Twig/Mime/BodyRenderer.php b/src/Symfony/Bridge/Twig/Mime/BodyRenderer.php
@@ -74,6 +74,6 @@ private function convertHtmlToText(string $html): string
             return $this->converter->convert($html);
         }
 
-        return strip_tags(preg_replace('{<(head|style)\b.*?</\1>}i', '', $html));
+        return strip_tags(preg_replace('{<(head|style)\b.*?</\1>}is', '', $html));
     }
 }
diff --git a/src/Symfony/Bridge/Twig/Tests/Mime/BodyRendererTest.php b/src/Symfony/Bridge/Twig/Tests/Mime/BodyRendererTest.php
@@ -37,6 +37,23 @@ public function testRenderHtmlOnly()
         $this->assertEquals(str_replace('=', '=3D', $html), $body->getParts()[1]->bodyToString());
     }
 
+    public function testRenderMultiLineHtmlOnly()
+    {
+        $html = <<<HTML
+<head>
+<style type="text/css">
+css
+</style>
+</head>
+<b>HTML</b>
+HTML;
+        $email = $this->prepareEmail(null, $html);
+        $body = $email->getBody();
+        $this->assertInstanceOf(AlternativePart::class, $body);
+        $this->assertEquals('HTML', str_replace(["\r", "\n"], '', $body->getParts()[0]->bodyToString()));
+        $this->assertEquals(str_replace(['=', "\n"], ['=3D', "\r\n"], $html), $body->getParts()[1]->bodyToString());
+    }
+
     public function testRenderHtmlOnlyWithTextSet()
     {
         $email = $this->prepareEmail(null, '<b>HTML</b>');

Original file line number	Diff line number	Diff line change
`@@ -74,6 +74,6 @@ private function convertHtmlToText(string $html): string`
`74`	`74`	`return $this->converter->convert($html);`
`75`	`75`	`}`
`76`	`76`
`77`		`- return strip_tags(preg_replace('{<(head\|style)\b.*?</\1>}i', '', $html));`
	`77`	`+ return strip_tags(preg_replace('{<(head\|style)\b.*?</\1>}is', '', $html));`
`78`	`78`	`}`
`79`	`79`	`}`