bug #29090 LoggingTranslator should implement Symfony\Contracts\Translation\TranslatorInterface (desmax)

nicolas-grekas · nicolas-grekas · commit ef3be0b244be · 2018-11-06T16:56:30.000+01:00
This PR was merged into the 4.2-dev branch. Discussion ---------- LoggingTranslator should implement Symfony\Contracts\Translation\TranslatorInterface | Q | A | ------------- | --- | Branch? | master | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #29089 | License | MIT While autowiring Translator using `Symfony\Contracts\Translation\TranslatorInterface` symfony complains that wrong service was injected, because LoggingTranslator does not implement new interface. Commits ------- 65f321f LoggingTranslator should implement Symfony\Contracts\Translation\TranslatorInterface
diff --git a/src/Symfony/Component/Translation/LoggingTranslator.php b/src/Symfony/Component/Translation/LoggingTranslator.php
@@ -19,7 +19,7 @@
 /**
  * @author Abdellatif Ait boudad <a.aitboudad@gmail.com>
  */
-class LoggingTranslator implements LegacyTranslatorInterface, TranslatorBagInterface
+class LoggingTranslator implements TranslatorInterface, LegacyTranslatorInterface, TranslatorBagInterface
 {
     /**
      * @var TranslatorInterface|TranslatorBagInterface

Original file line number	Diff line number	Diff line change
`@@ -19,7 +19,7 @@`
`19`	`19`	`/**`
`20`	`20`	`* @author Abdellatif Ait boudad <[email protected]>`
`21`	`21`	`*/`
`22`		`-class LoggingTranslator implements LegacyTranslatorInterface, TranslatorBagInterface`
	`22`	`+class LoggingTranslator implements TranslatorInterface, LegacyTranslatorInterface, TranslatorBagInterface`
`23`	`23`	`{`
`24`	`24`	`/**`
`25`	`25`	`* @var TranslatorInterface\|TranslatorBagInterface`