add return types to driver wrapper

Jeroeny · Jeroeny · commit ef7e05982df7 · 2021-07-13T09:03:22.000+02:00
diff --git a/.github/patch-types.php b/.github/patch-types.php
@@ -25,7 +25,6 @@
         case false !== strpos($file = realpath($file), '/vendor/'):
         case false !== strpos($file, '/src/Symfony/Bridge/PhpUnit/'):
         case false !== strpos($file, '/src/Symfony/Bundle/FrameworkBundle/Tests/Fixtures/Validation/Article.php'):
-        case false !== strpos($file, '/src/Symfony/Component/Cache/Tests/Fixtures/DriverWrapper.php'):
         case false !== strpos($file, '/src/Symfony/Component/Config/Tests/Fixtures/BadFileName.php'):
         case false !== strpos($file, '/src/Symfony/Component/Config/Tests/Fixtures/BadParent.php'):
         case false !== strpos($file, '/src/Symfony/Component/Config/Tests/Fixtures/ParseError.php'):
diff --git a/src/Symfony/Component/Cache/Tests/Fixtures/DriverWrapper.php b/src/Symfony/Component/Cache/Tests/Fixtures/DriverWrapper.php
@@ -14,6 +14,7 @@
 use Doctrine\DBAL\Connection;
 use Doctrine\DBAL\Driver;
 use Doctrine\DBAL\Platforms\AbstractPlatform;
+use Doctrine\DBAL\Schema\AbstractSchemaManager;
 
 class DriverWrapper implements Driver
 {
@@ -25,26 +26,17 @@ public function __construct(Driver $driver)
         $this->driver = $driver;
     }
 
-    /**
-     * @return Driver\Connection
-     */
-    public function connect(array $params, $username = null, $password = null, array $driverOptions = [])
+    public function connect(array $params, $username = null, $password = null, array $driverOptions = []): Driver\Connection
     {
         return $this->driver->connect($params, $username, $password, $driverOptions);
     }
 
-    /**
-     * @return \Doctrine\DBAL\Platforms\AbstractPlatform
-     */
-    public function getDatabasePlatform()
+    public function getDatabasePlatform(): AbstractPlatform
     {
         return $this->driver->getDatabasePlatform();
     }
 
-    /**
-     * @return \Doctrine\DBAL\Schema\AbstractSchemaManager
-     */
-    public function getSchemaManager(Connection $conn, AbstractPlatform $platform)
+    public function getSchemaManager(Connection $conn, AbstractPlatform $platform): AbstractSchemaManager
     {
         return $this->driver->getSchemaManager($conn, $platform);
     }

Original file line number	Diff line number	Diff line change
`@@ -14,6 +14,7 @@`
`14`	`14`	`use Doctrine\DBAL\Connection;`
`15`	`15`	`use Doctrine\DBAL\Driver;`
`16`	`16`	`use Doctrine\DBAL\Platforms\AbstractPlatform;`
	`17`	`+use Doctrine\DBAL\Schema\AbstractSchemaManager;`
`17`	`18`
`18`	`19`	`class DriverWrapper implements Driver`
`19`	`20`	`{`
`@@ -25,26 +26,17 @@ public function __construct(Driver $driver)`
`25`	`26`	`$this->driver = $driver;`
`26`	`27`	`}`
`27`	`28`
`28`		`- /**`
`29`		`- * @return Driver\Connection`
`30`		`- */`
`31`		`- public function connect(array $params, $username = null, $password = null, array $driverOptions = [])`
	`29`	`+ public function connect(array $params, $username = null, $password = null, array $driverOptions = []): Driver\Connection`
`32`	`30`	`{`
`33`	`31`	`return $this->driver->connect($params, $username, $password, $driverOptions);`
`34`	`32`	`}`
`35`	`33`
`36`		`- /**`
`37`		`- * @return \Doctrine\DBAL\Platforms\AbstractPlatform`
`38`		`- */`
`39`		`- public function getDatabasePlatform()`
	`34`	`+ public function getDatabasePlatform(): AbstractPlatform`
`40`	`35`	`{`
`41`	`36`	`return $this->driver->getDatabasePlatform();`
`42`	`37`	`}`
`43`	`38`
`44`		`- /**`
`45`		`- * @return \Doctrine\DBAL\Schema\AbstractSchemaManager`
`46`		`- */`
`47`		`- public function getSchemaManager(Connection $conn, AbstractPlatform $platform)`
	`39`	`+ public function getSchemaManager(Connection $conn, AbstractPlatform $platform): AbstractSchemaManager`
`48`	`40`	`{`
`49`	`41`	`return $this->driver->getSchemaManager($conn, $platform);`
`50`	`42`	`}`