[HttpClient] Fix MockResponse in case of header timeout

rmikalkenas · rmikalkenas · commit f130731f4778 · 2024-01-24T16:31:36.000+02:00
diff --git a/src/Symfony/Component/HttpClient/Response/MockResponse.php b/src/Symfony/Component/HttpClient/Response/MockResponse.php
@@ -203,7 +203,7 @@ protected static function perform(ClientState $multi, array &$responses): void
                     $chunk[1]->getStatusCode();
                     $chunk[1]->getHeaders(false);
                     self::readResponse($response, $chunk[0], $chunk[1], $offset);
-                    $multi->handlesActivity[$id][] = new FirstChunk();
+                    $multi->handlesActivity[$id][] = ($response->body[0] ?? null) instanceof ErrorChunk ? $response->body[0] : new FirstChunk();
                     $buffer = $response->requestOptions['buffer'] ?? null;
 
                     if ($buffer instanceof \Closure && $response->content = $buffer($response->headers) ?: null) {
diff --git a/src/Symfony/Component/HttpClient/Tests/Response/MockResponseTest.php b/src/Symfony/Component/HttpClient/Tests/Response/MockResponseTest.php
@@ -13,6 +13,7 @@
 
 use PHPUnit\Framework\TestCase;
 use Symfony\Component\HttpClient\Exception\JsonException;
+use Symfony\Component\HttpClient\Exception\TimeoutException;
 use Symfony\Component\HttpClient\Exception\TransportException;
 use Symfony\Component\HttpClient\Response\MockResponse;
 
@@ -124,4 +125,34 @@ public function testCancelingAMockResponseNotIssuedByMockHttpClient()
 
         $this->assertTrue($mockResponse->getInfo('canceled'));
     }
+
+    public function testTimeoutHeader()
+    {
+        $response = MockResponse::fromRequest('GET', 'http://symfony.com', [], new MockResponse(['']));
+
+        try {
+            $response->getStatusCode();
+            $this->fail(TimeoutException::class.' expected');
+        } catch (TimeoutException $e) {
+        }
+
+        $this->assertSame('Idle timeout reached for "http://symfony.com".', $response->getInfo('error'));
+    }
+
+    public function testTimeoutBody()
+    {
+        $response = MockResponse::fromRequest('GET', 'http://symfony.com', [], new MockResponse(['content', '']));
+
+        try {
+            $this->assertSame(200, $response->getStatusCode());
+        } catch (TimeoutException $e) {
+            $this->fail(TimeoutException::class.' was not expected');
+        }
+
+        try {
+            $response->getContent();
+            $this->fail(TimeoutException::class.' expected');
+        } catch (TimeoutException $e) {
+        }
+    }
 }
