bug #38136 [Messenger] Run postgres setup trigger in transaction (akondas)

nicolas-grekas · nicolas-grekas · commit f1fd3c00690a · 2020-09-10T18:35:00.000+02:00
This PR was merged into the 5.1 branch. Discussion ---------- [Messenger] Run postgres setup trigger in transaction | Q | A | ------------- | --- | Branch? | 5.1  | Bug fix? | yes | New feature? | no  | Deprecations? | no  | Tickets | Fix #37179  | License | MIT | Doc PR | n/a  This PR fix `messenger:setup-transports` command when using with ` doctrine/doctrine-bundle` version >= 2.1 Commits ------- 7ed93b4 Run postgres setup trigger in transaction
diff --git a/src/Symfony/Component/Messenger/Bridge/Doctrine/Transport/PostgreSqlConnection.php b/src/Symfony/Component/Messenger/Bridge/Doctrine/Transport/PostgreSqlConnection.php
@@ -109,6 +109,7 @@ public function getExtraSetupSqlForTable(Table $createdTable): array
     private function getTriggerSql(): array
     {
         return [
+            'BEGIN;',
             sprintf('LOCK TABLE %s;', $this->configuration['table_name']),
             // create trigger function
             sprintf(<<<'SQL'
@@ -123,6 +124,7 @@ private function getTriggerSql(): array
             // register trigger
             sprintf('DROP TRIGGER IF EXISTS notify_trigger ON %s;', $this->configuration['table_name']),
             sprintf('CREATE TRIGGER notify_trigger AFTER INSERT ON %1$s FOR EACH ROW EXECUTE PROCEDURE notify_%1$s();', $this->configuration['table_name']),
+            'COMMIT;',
         ];
     }
 

Original file line number	Diff line number	Diff line change
`@@ -109,6 +109,7 @@ public function getExtraSetupSqlForTable(Table $createdTable): array`
`109`	`109`	`private function getTriggerSql(): array`
`110`	`110`	`{`
`111`	`111`	`return [`
	`112`	`+ 'BEGIN;',`
`112`	`113`	`sprintf('LOCK TABLE %s;', $this->configuration['table_name']),`
`113`	`114`	`// create trigger function`
`114`	`115`	`sprintf(<<<'SQL'`
`@@ -123,6 +124,7 @@ private function getTriggerSql(): array`
`123`	`124`	`// register trigger`
`124`	`125`	`sprintf('DROP TRIGGER IF EXISTS notify_trigger ON %s;', $this->configuration['table_name']),`
`125`	`126`	`sprintf('CREATE TRIGGER notify_trigger AFTER INSERT ON %1$s FOR EACH ROW EXECUTE PROCEDURE notify_%1$s();', $this->configuration['table_name']),`
	`127`	`+ 'COMMIT;',`
`126`	`128`	`];`
`127`	`129`	`}`
`128`	`130`