minor #44319 [DoctrineBridge] Add DbalLoggerTest to group legacy (nicolas-grekas)

nicolas-grekas · nicolas-grekas · commit f3be0435a77c · 2021-11-29T11:49:37.000+01:00
This PR was merged into the 4.4 branch. Discussion ---------- [DoctrineBridge] Add DbalLoggerTest to group legacy | Q | A | ------------- | --- | Branch? | 4.4 | Bug fix? | no | New feature? | no | Deprecations? | no | Tickets | - | License | MIT | Doc PR | - Commits ------- 325d19c [DoctrineBridge] Add DbalLoggerTest to group legacy
diff --git a/.appveyor.yml b/.appveyor.yml
@@ -12,7 +12,6 @@ init:
     - SET SYMFONY_DEPRECATIONS_HELPER=strict
     - SET ANSICON=121x90 (121x90)
     - SET SYMFONY_PHPUNIT_DISABLE_RESULT_CACHE=1
-    - SET SYMFONY_DEPRECATIONS_HELPER=max[direct]=1
     - REG ADD "HKEY_CURRENT_USER\Software\Microsoft\Command Processor" /v DelayedExpansion /t REG_DWORD /d 1 /f
 
 install:
diff --git a/.github/workflows/integration-tests.yml b/.github/workflows/integration-tests.yml
@@ -99,7 +99,6 @@ jobs:
       - name: Run tests
         run: ./phpunit --group integration -v
         env:
-          SYMFONY_DEPRECATIONS_HELPER: max[direct]=1 # to be removed once DbalLogger is compatible with dbal 3.2+
           REDIS_HOST: localhost
           REDIS_CLUSTER_HOSTS: 'localhost:7000 localhost:7001 localhost:7002 localhost:7003 localhost:7004 localhost:7005'
           REDIS_SENTINEL_HOSTS: 'localhost:26379'
diff --git a/.github/workflows/unit-tests.yml b/.github/workflows/unit-tests.yml
@@ -63,7 +63,6 @@ jobs:
           echo COLUMNS=120 >> $GITHUB_ENV
           echo PHPUNIT="$(readlink -f ./phpunit) --exclude-group tty,benchmark,intl-data" >> $GITHUB_ENV
           echo COMPOSER_UP='composer update --no-progress --ansi' >> $GITHUB_ENV
-          echo SYMFONY_DEPRECATIONS_HELPER=max[direct]=1 >> $GITHUB_ENV # to be removed once DbalLogger is compatible with dbal 3.2+
 
           SYMFONY_VERSIONS=$(git ls-remote -q --heads | cut -f2 | grep -o '/[1-9][0-9]*\.[0-9].*' | sort -V)
           SYMFONY_VERSION=$(grep ' VERSION = ' src/Symfony/Component/HttpKernel/Kernel.php | grep -P -o '[0-9]+\.[0-9]+')
diff --git a/src/Symfony/Bridge/Doctrine/Tests/Logger/DbalLoggerTest.php b/src/Symfony/Bridge/Doctrine/Tests/Logger/DbalLoggerTest.php
@@ -15,6 +15,9 @@
 use Psr\Log\LoggerInterface;
 use Symfony\Bridge\Doctrine\Logger\DbalLogger;
 
+/**
+ * @group legacy
+ */
 class DbalLoggerTest extends TestCase
 {
     /**
@@ -46,8 +49,8 @@ public function getLogFixtures()
             ['SQL', null, []],
             ['SQL', [], []],
             ['SQL', ['foo' => 'bar'], ['foo' => 'bar']],
-            ['SQL', ['foo' => "\x7F\xFF"], ['foo' => DbalLogger::BINARY_DATA_VALUE]],
-            ['SQL', ['foo' => "bar\x7F\xFF"], ['foo' => DbalLogger::BINARY_DATA_VALUE]],
+            ['SQL', ['foo' => "\x7F\xFF"], ['foo' => '(binary value)']],
+            ['SQL', ['foo' => "bar\x7F\xFF"], ['foo' => '(binary value)']],
             ['SQL', ['foo' => ''], ['foo' => '']],
         ];
     }
