bug #62242 [MonologBridge] Accept HttpExceptionInterface in HttpCodeActivationStrategy (GromNaN)

nicolas-grekas · nicolas-grekas · commit f3dc27495238 · 2025-10-31T08:33:32.000+01:00
This PR was merged into the 6.4 branch. Discussion ---------- [MonologBridge] Accept HttpExceptionInterface in HttpCodeActivationStrategy | Q | A | ------------- | --- | Branch? | 6.4 | Bug fix? | yes | New feature? | no | Deprecations? | no | Issues | Fix #60239 | License | MIT Commits ------- c2c34bb [MonologBundle] Accept HttpExceptionInterface in HttpCodeActivationStrategy
diff --git a/src/Symfony/Bridge/Monolog/Handler/FingersCrossed/HttpCodeActivationStrategy.php b/src/Symfony/Bridge/Monolog/Handler/FingersCrossed/HttpCodeActivationStrategy.php
@@ -14,7 +14,7 @@
 use Monolog\Handler\FingersCrossed\ActivationStrategyInterface;
 use Monolog\LogRecord;
 use Symfony\Component\HttpFoundation\RequestStack;
-use Symfony\Component\HttpKernel\Exception\HttpException;
+use Symfony\Component\HttpKernel\Exception\HttpExceptionInterface;
 
 /**
  * Activation strategy that ignores certain HTTP codes.
@@ -49,7 +49,7 @@ public function isHandlerActivated(array|LogRecord $record): bool
         if (
             $isActivated
             && isset($record['context']['exception'])
-            && $record['context']['exception'] instanceof HttpException
+            && $record['context']['exception'] instanceof HttpExceptionInterface
             && ($request = $this->requestStack->getMainRequest())
         ) {
             foreach ($this->exclusions as $exclusion) {
diff --git a/src/Symfony/Bridge/Monolog/Tests/Handler/FingersCrossed/HttpCodeActivationStrategyTest.php b/src/Symfony/Bridge/Monolog/Tests/Handler/FingersCrossed/HttpCodeActivationStrategyTest.php
@@ -18,7 +18,7 @@
 use Symfony\Bridge\Monolog\Tests\RecordFactory;
 use Symfony\Component\HttpFoundation\Request;
 use Symfony\Component\HttpFoundation\RequestStack;
-use Symfony\Component\HttpKernel\Exception\HttpException;
+use Symfony\Component\HttpKernel\Exception\HttpExceptionInterface;
 
 class HttpCodeActivationStrategyTest extends TestCase
 {
@@ -74,6 +74,23 @@ public static function isActivatedProvider(): array
 
     private static function getContextException(int $code): array
     {
-        return ['exception' => new HttpException($code)];
+        return ['exception' => new class($code) extends \RuntimeException implements HttpExceptionInterface {
+            private int $statusCode;
+
+            public function __construct(int $statusCode)
+            {
+                $this->statusCode = $statusCode;
+            }
+
+            public function getStatusCode(): int
+            {
+                return $this->statusCode;
+            }
+
+            public function getHeaders(): array
+            {
+                return [];
+            }
+        }];
     }
 }
