Fixing time-sensitive test

weaverryan · weaverryan · commit f5ebe368b4a0 · 2019-03-27T23:55:47.000-04:00
diff --git a/src/Symfony/Component/Messenger/Tests/WorkerTest.php b/src/Symfony/Component/Messenger/Tests/WorkerTest.php
@@ -27,6 +27,9 @@
 use Symfony\Component\Messenger\Worker;
 use Symfony\Contracts\EventDispatcher\EventDispatcherInterface;
 
+/**
+ * @group time-sensitive
+ */
 class WorkerTest extends TestCase
 {
     public function testWorkerDispatchTheReceivedMessage()
@@ -44,7 +47,7 @@ public function testWorkerDispatchTheReceivedMessage()
         $bus->expects($this->at(1))->method('dispatch')->with($envelope = new Envelope($ipaMessage, new ReceivedStamp()))->willReturn($envelope);
 
         $worker = new Worker([$receiver], $bus);
-        $worker->run(['sleep' => 0], function (?Envelope $envelope) use ($worker) {
+        $worker->run([], function (?Envelope $envelope) use ($worker) {
             // stop after the messages finish
             if (null === $envelope) {
                 $worker->stop();
@@ -64,7 +67,7 @@ public function testWorkerDoesNotWrapMessagesAlreadyWrappedWithReceivedMessage()
         $bus->expects($this->at(0))->method('dispatch')->with($envelope)->willReturn($envelope);
 
         $worker = new Worker([$receiver], $bus, []);
-        $worker->run(['sleep' => 0], function (?Envelope $envelope) use ($worker) {
+        $worker->run([], function (?Envelope $envelope) use ($worker) {
             // stop after the messages finish
             if (null === $envelope) {
                 $worker->stop();
@@ -100,7 +103,7 @@ public function testDispatchCausesRetry()
         $retryStrategy->expects($this->once())->method('isRetryable')->willReturn(true);
 
         $worker = new Worker(['receiver1' => $receiver], $bus, ['receiver1' => $retryStrategy]);
-        $worker->run(['sleep' => 0], function (?Envelope $envelope) use ($worker) {
+        $worker->run([], function (?Envelope $envelope) use ($worker) {
             // stop after the messages finish
             if (null === $envelope) {
                 $worker->stop();
@@ -124,7 +127,7 @@ public function testDispatchCausesRejectWhenNoRetry()
         $retryStrategy->expects($this->once())->method('isRetryable')->willReturn(false);
 
         $worker = new Worker(['receiver1' => $receiver], $bus, ['receiver1' => $retryStrategy]);
-        $worker->run(['sleep' => 0], function (?Envelope $envelope) use ($worker) {
+        $worker->run([], function (?Envelope $envelope) use ($worker) {
             // stop after the messages finish
             if (null === $envelope) {
                 $worker->stop();
@@ -147,7 +150,7 @@ public function testDispatchCausesRejectOnUnrecoverableMessage()
         $retryStrategy->expects($this->never())->method('isRetryable');
 
         $worker = new Worker(['receiver1' => $receiver], $bus, ['receiver1' => $retryStrategy]);
-        $worker->run(['sleep' => 0], function (?Envelope $envelope) use ($worker) {
+        $worker->run([], function (?Envelope $envelope) use ($worker) {
             // stop after the messages finish
             if (null === $envelope) {
                 $worker->stop();
@@ -166,7 +169,7 @@ public function testWorkerDoesNotSendNullMessagesToTheBus()
         $bus->expects($this->never())->method('dispatch');
 
         $worker = new Worker([$receiver], $bus);
-        $worker->run(['sleep' => 0], function (?Envelope $envelope) use ($worker) {
+        $worker->run([], function (?Envelope $envelope) use ($worker) {
             // stop after the messages finish
             if (null === $envelope) {
                 $worker->stop();
@@ -192,7 +195,7 @@ public function testWorkerDispatchesEventsOnSuccess()
             );
 
         $worker = new Worker([$receiver], $bus, [], $eventDispatcher);
-        $worker->run(['sleep' => 0], function (?Envelope $envelope) use ($worker) {
+        $worker->run([], function (?Envelope $envelope) use ($worker) {
             // stop after the messages finish
             if (null === $envelope) {
                 $worker->stop();
@@ -219,17 +222,14 @@ public function testWorkerDispatchesEventsOnError()
             );
 
         $worker = new Worker([$receiver], $bus, [], $eventDispatcher);
-        $worker->run(['sleep' => 0], function (?Envelope $envelope) use ($worker) {
+        $worker->run([], function (?Envelope $envelope) use ($worker) {
             // stop after the messages finish
             if (null === $envelope) {
                 $worker->stop();
             }
         });
     }
 
-    /**
-     * @group time-sensitive
-     */
     public function testTimeoutIsConfigurable()
     {
         $apiMessage = new DummyMessage('API');
@@ -258,10 +258,10 @@ public function testTimeoutIsConfigurable()
                 $worker->stop();
                 $duration = microtime(true) - $startTime;
 
-                // wait time should be .3 seconds, so execution should
-                // be only a bit more than that
-                $this->assertGreaterThanOrEqual(.3, $duration);
-                $this->assertLessThan(.5, $duration);
+                // wait time should be .3 seconds
+                // use .29 & .31 for timing "wiggle room"
+                $this->assertGreaterThanOrEqual(.29, $duration);
+                $this->assertLessThan(.31, $duration);
             }
         });
     }
@@ -306,7 +306,7 @@ public function testWorkerWithMultipleReceivers()
         $receivedCount = 0;
         $worker = new Worker([$receiver1, $receiver2, $receiver3], $bus);
         $processedEnvelopes = [];
-        $worker->run(['sleep' => 0], function (?Envelope $envelope) use ($worker, &$receivedCount, &$processedEnvelopes) {
+        $worker->run([], function (?Envelope $envelope) use ($worker, &$receivedCount, &$processedEnvelopes) {
             if (null !== $envelope) {
                 $processedEnvelopes[] = $envelope;
                 ++$receivedCount;
