bug #41686 [Console] Fix using #[AsCommand] without DI (nicolas-grekas)

nicolas-grekas · nicolas-grekas · commit f640e6c2659c · 2021-06-12T12:09:30.000+02:00
This PR was merged into the 5.3 branch. Discussion ---------- [Console] Fix using #[AsCommand] without DI | Q | A | ------------- | --- | Branch? | 5.3 | Bug fix? | yes | New feature? | no | Deprecations? | no | Tickets | Fix #41547 | License | MIT | Doc PR | - Commits ------- c4357ea [Console] Fix using #[AsCommand] without DI
diff --git a/src/Symfony/Component/Console/Command/Command.php b/src/Symfony/Component/Console/Command/Command.php
@@ -101,7 +101,18 @@ public function __construct(string $name = null)
     {
         $this->definition = new InputDefinition();
 
-        if (null !== $name || null !== $name = static::getDefaultName()) {
+        if (null === $name && null !== $name = static::getDefaultName()) {
+            $aliases = explode('|', $name);
+
+            if ('' === $name = array_shift($aliases)) {
+                $this->setHidden(true);
+                $name = array_shift($aliases);
+            }
+
+            $this->setAliases($aliases);
+        }
+
+        if (null !== $name) {
             $this->setName($name);
         }
 
diff --git a/src/Symfony/Component/Console/Tests/Command/CommandTest.php b/src/Symfony/Component/Console/Tests/Command/CommandTest.php
@@ -414,6 +414,13 @@ public function testCommandAttribute()
     {
         $this->assertSame('|foo|f', Php8Command::getDefaultName());
         $this->assertSame('desc', Php8Command::getDefaultDescription());
+
+        $command = new Php8Command();
+
+        $this->assertSame('foo', $command->getName());
+        $this->assertSame('desc', $command->getDescription());
+        $this->assertTrue($command->isHidden());
+        $this->assertSame(['f'], $command->getAliases());
     }
 }
 

Original file line number	Diff line number	Diff line change
`@@ -414,6 +414,13 @@ public function testCommandAttribute()`
`414`	`414`	`{`
`415`	`415`	`$this->assertSame('\|foo\|f', Php8Command::getDefaultName());`
`416`	`416`	`$this->assertSame('desc', Php8Command::getDefaultDescription());`
	`417`	`+`
	`418`	`+ $command = new Php8Command();`
	`419`	`+`
	`420`	`+ $this->assertSame('foo', $command->getName());`
	`421`	`+ $this->assertSame('desc', $command->getDescription());`
	`422`	`+ $this->assertTrue($command->isHidden());`
	`423`	`+ $this->assertSame(['f'], $command->getAliases());`
`417`	`424`	`}`
`418`	`425`	`}`
`419`	`426`