cs

Nyholm · Nyholm · commit f647abe388b4 · 2019-09-28T18:26:10.000+02:00
diff --git a/src/Symfony/Component/HttpClient/Httplug/CorePromise.php b/src/Symfony/Component/HttpClient/Httplug/CorePromise.php
@@ -116,7 +116,7 @@ public function __construct(
 
     public function wait(): void
     {
-        if ($this->state !== Promise::PENDING) {
+        if (Promise::PENDING !== $this->state) {
             // No need to wait if we already are resolved.
             return;
         }
@@ -131,12 +131,11 @@ public function wait(): void
                 $this->promisePool->getPromise($response)->reject($e);
             }
 
-            if ($this->state !== Promise::PENDING) {
+            if (Promise::PENDING !== $this->state) {
                 // We just processed our response
                 return;
             }
         }
-
     }
 
     /**
diff --git a/src/Symfony/Component/HttpClient/Httplug/HttplugPromise.php b/src/Symfony/Component/HttpClient/Httplug/HttplugPromise.php
@@ -12,11 +12,6 @@
 namespace Symfony\Component\HttpClient\Httplug;
 
 use Http\Promise\Promise;
-use Psr\Http\Message\RequestInterface;
-use Psr\Http\Message\ResponseFactoryInterface;
-use Psr\Http\Message\StreamFactoryInterface;
-use Symfony\Contracts\HttpClient\HttpClientInterface;
-use Symfony\Contracts\HttpClient\ResponseInterface;
 
 /**
  * @author Tobias Nyholm <tobias.nyholm@gmail.com>
diff --git a/src/Symfony/Component/HttpClient/Httplug/PromisePool.php b/src/Symfony/Component/HttpClient/Httplug/PromisePool.php
@@ -32,7 +32,7 @@ public function getPendingResponses(): array
     {
         $responses = [];
         foreach ($this->promises as $tupel) {
-            if ($tupel[0]->getState() === Promise::PENDING) {
+            if (Promise::PENDING === $tupel[0]->getState()) {
                 $responses[] = $tupel[1];
             }
         }
@@ -61,6 +61,7 @@ public function remove(CorePromise $promise): void
         foreach ($this->promises as $i => $tupel) {
             if ($tupel[0] === $promise) {
                 unset($this->promises[$i]);
+
                 return;
             }
         }

Original file line number	Diff line number	Diff line change
`@@ -116,7 +116,7 @@ public function __construct(`
`116`	`116`
`117`	`117`	`public function wait(): void`
`118`	`118`	`{`
`119`		`- if ($this->state !== Promise::PENDING) {`
	`119`	`+ if (Promise::PENDING !== $this->state) {`
`120`	`120`	`// No need to wait if we already are resolved.`
`121`	`121`	`return;`
`122`	`122`	`}`
`@@ -131,12 +131,11 @@ public function wait(): void`
`131`	`131`	`$this->promisePool->getPromise($response)->reject($e);`
`132`	`132`	`}`
`133`	`133`
`134`		`- if ($this->state !== Promise::PENDING) {`
	`134`	`+ if (Promise::PENDING !== $this->state) {`
`135`	`135`	`// We just processed our response`
`136`	`136`	`return;`
`137`	`137`	`}`
`138`	`138`	`}`
`139`		`-`
`140`	`139`	`}`
`141`	`140`
`142`	`141`	`/**`
Original file line number	Diff line number	Diff line change
`@@ -32,7 +32,7 @@ public function getPendingResponses(): array`
`32`	`32`	`{`
`33`	`33`	`$responses = [];`
`34`	`34`	`foreach ($this->promises as $tupel) {`
`35`		`- if ($tupel[0]->getState() === Promise::PENDING) {`
	`35`	`+ if (Promise::PENDING === $tupel[0]->getState()) {`
`36`	`36`	`$responses[] = $tupel[1];`
`37`	`37`	`}`
`38`	`38`	`}`
`@@ -61,6 +61,7 @@ public function remove(CorePromise $promise): void`
`61`	`61`	`foreach ($this->promises as $i => $tupel) {`
`62`	`62`	`if ($tupel[0] === $promise) {`
`63`	`63`	`unset($this->promises[$i]);`
	`64`	`+`
`64`	`65`	`return;`
`65`	`66`	`}`
`66`	`67`	`}`