feature #28387 [HttpKernel][Profiler] Add arg value resolver category in performances panel (ogizanagi)

fabpot · fabpot · commit f6b4dc94d1ff · 2018-09-08T09:28:50.000+02:00
This PR was merged into the 4.2-dev branch. Discussion ---------- [HttpKernel][Profiler] Add arg value resolver category in performances panel | Q | A | ------------- | --- | Branch? | master  | Bug fix? | no | New feature? | yes  | BC breaks? | no  | Deprecations? | no  | Tests pass? | yes  | Fixed tickets | part of #27262  | License | MIT | Doc PR | N/A Extracted from #27321 <img width="1071" alt="screenshot 2018-05-20 a 12 23 55" src="https://user-images.githubusercontent.com/2211145/40278071-98c04924-5c2a-11e8-9770-d78ac62d2c16.PNG"> Commits ------- b24e054 [HttpKernel][Profiler] Add arg value resolver category in performances panel
diff --git a/src/Symfony/Bundle/WebProfilerBundle/Resources/views/Collector/time.html.twig b/src/Symfony/Bundle/WebProfilerBundle/Resources/views/Collector/time.html.twig
@@ -9,6 +9,7 @@
         'event_listener':         '#00B8F5',
         'template':               '#66CC00',
         'doctrine':               '#FF6633',
+        'controller.argument_value_resolver': '#8c5de6',
     } %}
 {% endif %}
 
diff --git a/src/Symfony/Component/HttpKernel/Controller/ArgumentResolver/TraceableValueResolver.php b/src/Symfony/Component/HttpKernel/Controller/ArgumentResolver/TraceableValueResolver.php
@@ -38,7 +38,7 @@ public function __construct(ArgumentValueResolverInterface $inner, Stopwatch $st
     public function supports(Request $request, ArgumentMetadata $argument): bool
     {
         $method = \get_class($this->inner).'::'.__FUNCTION__;
-        $this->stopwatch->start($method);
+        $this->stopwatch->start($method, 'controller.argument_value_resolver');
 
         $return = $this->inner->supports($request, $argument);
 
@@ -53,7 +53,7 @@ public function supports(Request $request, ArgumentMetadata $argument): bool
     public function resolve(Request $request, ArgumentMetadata $argument): iterable
     {
         $method = \get_class($this->inner).'::'.__FUNCTION__;
-        $this->stopwatch->start($method);
+        $this->stopwatch->start($method, 'controller.argument_value_resolver');
 
         yield from $this->inner->resolve($request, $argument);
 

Original file line number	Diff line number	Diff line change
`@@ -38,7 +38,7 @@ public function __construct(ArgumentValueResolverInterface $inner, Stopwatch $st`
`38`	`38`	`public function supports(Request $request, ArgumentMetadata $argument): bool`
`39`	`39`	`{`
`40`	`40`	`$method = \get_class($this->inner).'::'.__FUNCTION__;`
`41`		`- $this->stopwatch->start($method);`
	`41`	`+ $this->stopwatch->start($method, 'controller.argument_value_resolver');`
`42`	`42`
`43`	`43`	`$return = $this->inner->supports($request, $argument);`
`44`	`44`
`@@ -53,7 +53,7 @@ public function supports(Request $request, ArgumentMetadata $argument): bool`
`53`	`53`	`public function resolve(Request $request, ArgumentMetadata $argument): iterable`
`54`	`54`	`{`
`55`	`55`	`$method = \get_class($this->inner).'::'.__FUNCTION__;`
`56`		`- $this->stopwatch->start($method);`
	`56`	`+ $this->stopwatch->start($method, 'controller.argument_value_resolver');`
`57`	`57`
`58`	`58`	`yield from $this->inner->resolve($request, $argument);`
`59`	`59`