skip bcrypt tests on incompatible platforms

Christian Flothmann · Christian Flothmann · commit f9be27a61c39 · 2015-12-19T14:25:32.000+01:00
Not all PHP versions before 5.3.7 have backported fixes that make it
possible to use `password_has()` function. Therefore, we have to skip
tests on not supported platforms.
diff --git a/src/Symfony/Component/Security/Tests/Core/Encoder/BCryptPasswordEncoderTest.php b/src/Symfony/Component/Security/Tests/Core/Encoder/BCryptPasswordEncoderTest.php
@@ -11,6 +11,7 @@
 
 namespace Symfony\Component\Security\Tests\Core\Encoder;
 
+use PasswordCompat\binary\check;
 use Symfony\Component\Security\Core\Encoder\BCryptPasswordEncoder;
 
 /**
@@ -47,13 +48,17 @@ public function testCostInRange()
 
     public function testResultLength()
     {
+        $this->skipIfPhpVersionIsNotSupported();
+
         $encoder = new BCryptPasswordEncoder(self::VALID_COST);
         $result = $encoder->encodePassword(self::PASSWORD, null);
         $this->assertEquals(60, strlen($result));
     }
 
     public function testValidation()
     {
+        $this->skipIfPhpVersionIsNotSupported();
+
         $encoder = new BCryptPasswordEncoder(self::VALID_COST);
         $result = $encoder->encodePassword(self::PASSWORD, null);
         $this->assertTrue($encoder->isPasswordValid($result, self::PASSWORD, null));
@@ -78,4 +83,11 @@ public function testCheckPasswordLength()
         $this->assertFalse($encoder->isPasswordValid($result, str_repeat('a', 73), 'salt'));
         $this->assertTrue($encoder->isPasswordValid($result, str_repeat('a', 72), 'salt'));
     }
+
+    private function skipIfPhpVersionIsNotSupported()
+    {
+        if (PHP_VERSION_ID < 50307 && !check()) {
+            $this->markTestSkipped('Skipping test as this PHP version is not compatible with the ircmaxell/password-compat library.');
+        }
+    }
 }
