Adding test case, adding stop to delegated receiver

ragboyjr · ragboyjr · commit fb8e57caa9af · 2018-09-24T13:23:40.000-04:00
Signed-off-by: RJ Garcia &lt;rj@bighead.net&gt;
diff --git a/src/Symfony/Component/Messenger/Tests/Transport/Enhancers/InfiniteLoopReceiverTest.php b/src/Symfony/Component/Messenger/Tests/Transport/Enhancers/InfiniteLoopReceiverTest.php
@@ -0,0 +1,74 @@
+<?php
+
+/*
+ * This file is part of the Symfony package.
+ *
+ * (c) Fabien Potencier <fabien@symfony.com>
+ *
+ * For the full copyright and license information, please view the LICENSE
+ * file that was distributed with this source code.
+ */
+
+namespace Symfony\Component\Messenger\Tests\Transport\Enhancers;
+
+use PHPUnit\Framework\TestCase;
+use Symfony\Component\Messenger\Transport\ReceiverInterface;
+use Symfony\Component\Messenger\Tests\Fixtures\CallbackReceiver;
+use Symfony\Component\Messenger\Transport\Enhancers\InfiniteLoopReceiver;
+
+class InfiniteLoopReceiverTest extends TestCase
+{
+    public function testReceiverReceivesUntilStopIsCalled()
+    {
+        $i = 0;
+        $decoratedReceiver = null;
+        $receiver = new CallbackReceiver(function ($handler) use (&$i, &$decoratedReceiver) {
+            $i += 1;
+            if ($i === 3) {
+                $decoratedReceiver->stop();
+            }
+        });
+
+        $decoratedReceiver = new InfiniteLoopReceiver($receiver);
+        $decoratedReceiver->receive(function() {});
+        $this->assertEquals(3, $i);
+    }
+
+    public function testReceiverDelegatesStopToInnerReceiver()
+    {
+        $decoratedReceiver = null;
+        $receiver = new class($decoratedReceiver) implements ReceiverInterface {
+            public $wasStopped = 0;
+            private $decoratedReceiver;
+
+            public function __construct(&$decoratedReceiver) {
+                $this->decoratedReceiver = &$decoratedReceiver;
+            }
+
+            public function receive(callable $handle): void {
+                $this->decoratedReceiver->stop();
+            }
+            public function stop(): void {
+                $this->wasStopped += 1;
+            }
+        };
+        $decoratedReceiver = new InfiniteLoopReceiver($receiver);
+        $decoratedReceiver->receive(function() {});
+        $this->assertEquals(1, $receiver->wasStopped);
+    }
+
+    /**
+     * @expectedException Exception
+     * @expectedExceptionMessage test
+     */
+    public function testReceiverRethrowsAnyExceptions()
+    {
+        $decoratedReceiver = null;
+        $receiver = new CallbackReceiver(function ($handler) {
+            throw new \Exception('test');
+        });
+
+        $decoratedReceiver = new InfiniteLoopReceiver($receiver);
+        $decoratedReceiver->receive(function() {});
+    }
+}
diff --git a/src/Symfony/Component/Messenger/Transport/Enhancers/InfiniteLoopReceiver.php b/src/Symfony/Component/Messenger/Transport/Enhancers/InfiniteLoopReceiver.php
@@ -18,7 +18,6 @@ public function __construct(ReceiverInterface $receiver)
         $this->shouldStop = false;
     }
 
-
     public function receive(callable $handler): void
     {
         while (!$this->shouldStop) {
@@ -36,10 +35,9 @@ public function receive(callable $handler): void
         }
     }
 
-    /**
-     * Stop receiving some messages.
-     */
-    public function stop(): void {
+    public function stop(): void
+    {
         $this->shouldStop = true;
+        $this->receiver->stop();
     }
 }

Original file line number	Diff line number	Diff line change
`@@ -18,7 +18,6 @@ public function __construct(ReceiverInterface $receiver)`
`18`	`18`	`$this->shouldStop = false;`
`19`	`19`	`}`
`20`	`20`
`21`		`-`
`22`	`21`	`public function receive(callable $handler): void`
`23`	`22`	`{`
`24`	`23`	`while (!$this->shouldStop) {`
`@@ -36,10 +35,9 @@ public function receive(callable $handler): void`
`36`	`35`	`}`
`37`	`36`	`}`
`38`	`37`
`39`		`- /**`
`40`		`- * Stop receiving some messages.`
`41`		`- */`
`42`		`- public function stop(): void {`
	`38`	`+ public function stop(): void`
	`39`	`+ {`
`43`	`40`	`$this->shouldStop = true;`
	`41`	`+ $this->receiver->stop();`
`44`	`42`	`}`
`45`	`43`	`}`