[DI] Enhance service locator error message

nicolas-grekas · nicolas-grekas · commit fdb0ea9fdd5c · 2017-10-17T00:51:02.000+02:00
diff --git a/src/Symfony/Component/DependencyInjection/Compiler/ServiceLocatorTagPass.php b/src/Symfony/Component/DependencyInjection/Compiler/ServiceLocatorTagPass.php
@@ -78,6 +78,9 @@ protected function processValue($value, $isRoot = false)
     public static function register(ContainerBuilder $container, array $refMap)
     {
         foreach ($refMap as $id => $ref) {
+            if (!$ref instanceof Reference) {
+                throw new InvalidArgumentException(sprintf('Invalid service locator definition: only services can be referenced, "%s" found for key "%s". Inject parameter values using constructors instead.', is_object($ref) ? get_class($ref) : gettype($ref), $id));
+            }
             $refMap[$id] = new ServiceClosureArgument($ref);
         }
         ksort($refMap);

Original file line number	Diff line number	Diff line change
`@@ -78,6 +78,9 @@ protected function processValue($value, $isRoot = false)`
`78`	`78`	`public static function register(ContainerBuilder $container, array $refMap)`
`79`	`79`	`{`
`80`	`80`	`foreach ($refMap as $id => $ref) {`
	`81`	`+ if (!$ref instanceof Reference) {`
	`82`	`+ throw new InvalidArgumentException(sprintf('Invalid service locator definition: only services can be referenced, "%s" found for key "%s". Inject parameter values using constructors instead.', is_object($ref) ? get_class($ref) : gettype($ref), $id));`
	`83`	`+ }`
`81`	`84`	`$refMap[$id] = new ServiceClosureArgument($ref);`
`82`	`85`	`}`
`83`	`86`	`ksort($refMap);`