minor #50185 [HttpClient][HttpFoundation][HttpKernel][Ldap][Mailer][Mime][Process][Routing][Security][Serializer][Translation][Validator] Add missing return types (wouterj)

nicolas-grekas · nicolas-grekas · commit ff98effcd036 · 2023-04-28T18:09:40.000+02:00
This PR was merged into the 6.3 branch. Discussion ---------- [HttpClient][HttpFoundation][HttpKernel][Ldap][Mailer][Mime][Process][Routing][Security][Serializer][Translation][Validator] Add missing return types | Q | A | ------------- | --- | Branch? | 6.3 | Bug fix? | no | New feature? | no | Deprecations? | yes | Tickets | Ref #47551 | License | MIT | Doc PR | - Last one, for the components. Only some bundle methods are missing now. Commits ------- f86dbbd Add missing return types
diff --git a/.github/expected-missing-return-types.diff b/.github/expected-missing-return-types.diff
diff --git a/src/Symfony/Component/HttpClient/Response/StreamWrapper.php b/src/Symfony/Component/HttpClient/Response/StreamWrapper.php
@@ -32,7 +32,7 @@ class StreamWrapper
     /** @var resource|string|null */
     private $content;
 
-    /** @var resource|null */
+    /** @var resource|callable|null */
     private $handle;
 
     private bool $blocking = true;
@@ -266,6 +266,9 @@ public function stream_seek(int $offset, int $whence = \SEEK_SET): bool
         return false;
     }
 
+    /**
+     * @return resource|false
+     */
     public function stream_cast(int $castAs)
     {
         if (\STREAM_CAST_FOR_SELECT === $castAs) {
diff --git a/src/Symfony/Component/HttpFoundation/Request.php b/src/Symfony/Component/HttpFoundation/Request.php
@@ -1732,6 +1732,9 @@ public function preferSafeContent(): bool
      * Copyright (c) 2005-2010 Zend Technologies USA Inc. (https://www.zend.com/)
      */
 
+    /**
+     * @return string
+     */
     protected function prepareRequestUri()
     {
         $requestUri = '';
diff --git a/src/Symfony/Component/HttpKernel/DependencyInjection/ConfigurableExtension.php b/src/Symfony/Component/HttpKernel/DependencyInjection/ConfigurableExtension.php
@@ -34,6 +34,8 @@ final public function load(array $configs, ContainerBuilder $container): void
 
     /**
      * Configures the passed container according to the merged configuration.
+     *
+     * @return void
      */
     abstract protected function loadInternal(array $mergedConfig, ContainerBuilder $container);
 }
diff --git a/src/Symfony/Component/Ldap/Security/LdapUserProvider.php b/src/Symfony/Component/Ldap/Security/LdapUserProvider.php
@@ -167,7 +167,7 @@ protected function loadUser(string $identifier, Entry $entry): UserInterface
         return new LdapUser($entry, $identifier, $password, $this->defaultRoles, $extraFields);
     }
 
-    private function getAttributeValue(Entry $entry, string $attribute)
+    private function getAttributeValue(Entry $entry, string $attribute): mixed
     {
         if (!$entry->hasAttribute($attribute)) {
             throw new InvalidArgumentException(sprintf('Missing attribute "%s" for user "%s".', $attribute, $entry->getDn()));
diff --git a/src/Symfony/Component/Mailer/Bridge/Mailjet/Transport/MailjetApiTransport.php b/src/Symfony/Component/Mailer/Bridge/Mailjet/Transport/MailjetApiTransport.php
@@ -199,7 +199,7 @@ private function getEndpoint(): ?string
         return ($this->host ?: self::HOST).($this->port ? ':'.$this->port : '');
     }
 
-    private function castCustomHeader(string $value, string $type)
+    private function castCustomHeader(string $value, string $type): mixed
     {
         return match ($type) {
             'bool' => filter_var($value, \FILTER_VALIDATE_BOOL),
diff --git a/src/Symfony/Component/Mime/Email.php b/src/Symfony/Component/Mime/Email.php
@@ -396,6 +396,9 @@ public function getBody(): AbstractPart
         return $this->generateBody();
     }
 
+    /**
+     * @return void
+     */
     public function ensureValidity()
     {
         $this->ensureBodyValid();
diff --git a/src/Symfony/Component/Process/Exception/ProcessFailedException.php b/src/Symfony/Component/Process/Exception/ProcessFailedException.php
@@ -47,6 +47,9 @@ public function __construct(Process $process)
         $this->process = $process;
     }
 
+    /**
+     * @return Process
+     */
     public function getProcess()
     {
         return $this->process;
diff --git a/src/Symfony/Component/Process/Exception/ProcessTimedOutException.php b/src/Symfony/Component/Process/Exception/ProcessTimedOutException.php
@@ -38,6 +38,9 @@ public function __construct(Process $process, int $timeoutType)
         ));
     }
 
+    /**
+     * @return Process
+     */
     public function getProcess()
     {
         return $this->process;
@@ -59,7 +62,7 @@ public function isIdleTimeout()
         return self::TYPE_IDLE === $this->timeoutType;
     }
 
-    public function getExceededTimeout()
+    public function getExceededTimeout(): ?float
     {
         return match ($this->timeoutType) {
             self::TYPE_GENERAL => $this->process->getTimeout(),
diff --git a/src/Symfony/Component/Process/Process.php b/src/Symfony/Component/Process/Process.php
@@ -285,6 +285,8 @@ public function mustRun(callable $callback = null, array $env = []): static
      * @param callable|null $callback A PHP callback to run whenever there is some
      *                                output available on STDOUT or STDERR
      *
+     * @return void
+     *
      * @throws RuntimeException When process can't be launched
      * @throws RuntimeException When process is already running
      * @throws LogicException   In case a callback is provided and output has been disabled
@@ -1140,6 +1142,8 @@ public function setInput(mixed $input): static
      * In case you run a background process (with the start method), you should
      * trigger this method regularly to ensure the process timeout
      *
+     * @return void
+     *
      * @throws ProcessTimedOutException In case the timeout was reached
      */
     public function checkTimeout()
@@ -1180,6 +1184,8 @@ public function getStartTime(): float
      *
      * Enabling the "create_new_console" option allows a subprocess to continue
      * to run after the main process exited, on both Windows and *nix
+     *
+     * @return void
      */
     public function setOptions(array $options)
     {
@@ -1275,6 +1281,8 @@ protected function buildCallback(callable $callback = null): \Closure
      * Updates the status of the process, reads pipes.
      *
      * @param bool $blocking Whether to use a blocking read call
+     *
+     * @return void
      */
     protected function updateStatus(bool $blocking)
     {
@@ -1323,7 +1331,7 @@ protected function isSigchildEnabled(): bool
      *
      * @throws LogicException in case output has been disabled or process is not started
      */
-    private function readPipesForOutput(string $caller, bool $blocking = false)
+    private function readPipesForOutput(string $caller, bool $blocking = false): void
     {
         if ($this->outputDisabled) {
             throw new LogicException('Output has been disabled.');
@@ -1358,7 +1366,7 @@ private function validateTimeout(?float $timeout): ?float
      * @param bool $blocking Whether to use blocking calls or not
      * @param bool $close    Whether to close file handles or not
      */
-    private function readPipes(bool $blocking, bool $close)
+    private function readPipes(bool $blocking, bool $close): void
     {
         $result = $this->processPipes->readAndWrite($blocking, $close);
 
@@ -1407,7 +1415,7 @@ private function close(): int
     /**
      * Resets data related to the latest run of the process.
      */
-    private function resetProcessData()
+    private function resetProcessData(): void
     {
         $this->starttime = null;
         $this->callback = null;
@@ -1528,7 +1536,7 @@ function ($m) use (&$env, $uid) {
      *
      * @throws LogicException if the process has not run
      */
-    private function requireProcessIsStarted(string $functionName)
+    private function requireProcessIsStarted(string $functionName): void
     {
         if (!$this->isStarted()) {
             throw new LogicException(sprintf('Process must be started before calling "%s()".', $functionName));
@@ -1540,7 +1548,7 @@ private function requireProcessIsStarted(string $functionName)
      *
      * @throws LogicException if the process is not yet terminated
      */
-    private function requireProcessIsTerminated(string $functionName)
+    private function requireProcessIsTerminated(string $functionName): void
     {
         if (!$this->isTerminated()) {
             throw new LogicException(sprintf('Process must be terminated before calling "%s()".', $functionName));
diff --git a/src/Symfony/Component/Routing/Loader/AnnotationClassLoader.php b/src/Symfony/Component/Routing/Loader/AnnotationClassLoader.php
@@ -358,6 +358,9 @@ protected function createRoute(string $path, array $defaults, array $requirement
         return new Route($path, $defaults, $requirements, $options, $host, $schemes, $methods, $condition);
     }
 
+    /**
+     * @return void
+     */
     abstract protected function configureRoute(Route $route, \ReflectionClass $class, \ReflectionMethod $method, object $annot);
 
     /**
diff --git a/src/Symfony/Component/Routing/Matcher/UrlMatcher.php b/src/Symfony/Component/Routing/Matcher/UrlMatcher.php
@@ -255,6 +255,9 @@ protected function mergeDefaults(array $params, array $defaults): array
         return $defaults;
     }
 
+    /**
+     * @return ExpressionLanguage
+     */
     protected function getExpressionLanguage()
     {
         if (null === $this->expressionLanguage) {
diff --git a/src/Symfony/Component/Routing/Router.php b/src/Symfony/Component/Routing/Router.php
@@ -178,6 +178,9 @@ public function getOption(string $key): mixed
         return $this->options[$key];
     }
 
+    /**
+     * @return RouteCollection
+     */
     public function getRouteCollection()
     {
         return $this->collection ??= $this->loader->load($this->resource, $this->options['resource_type']);
diff --git a/src/Symfony/Component/Routing/Tests/Loader/PhpFileLoaderTest.php b/src/Symfony/Component/Routing/Tests/Loader/PhpFileLoaderTest.php
@@ -312,7 +312,7 @@ public function testImportAttributesWithPsr4Prefix(string $configFile)
             $loader = new PhpFileLoader($locator),
             new Psr4DirectoryLoader($locator),
             new class() extends AnnotationClassLoader {
-                protected function configureRoute(Route $route, \ReflectionClass $class, \ReflectionMethod $method, object $annot)
+                protected function configureRoute(Route $route, \ReflectionClass $class, \ReflectionMethod $method, object $annot): void
                 {
                     $route->setDefault('_controller', $class->getName().'::'.$method->getName());
                 }
@@ -337,7 +337,7 @@ public function testImportAttributesFromClass()
         new LoaderResolver([
             $loader = new PhpFileLoader(new FileLocator(\dirname(__DIR__).'/Fixtures')),
             new class() extends AnnotationClassLoader {
-                protected function configureRoute(Route $route, \ReflectionClass $class, \ReflectionMethod $method, object $annot)
+                protected function configureRoute(Route $route, \ReflectionClass $class, \ReflectionMethod $method, object $annot): void
                 {
                     $route->setDefault('_controller', $class->getName().'::'.$method->getName());
                 }
diff --git a/src/Symfony/Component/Routing/Tests/Loader/Psr4DirectoryLoaderTest.php b/src/Symfony/Component/Routing/Tests/Loader/Psr4DirectoryLoaderTest.php
@@ -106,7 +106,7 @@ private function getLoader(): DelegatingLoader
             new LoaderResolver([
                 new Psr4DirectoryLoader($locator),
                 new class() extends AnnotationClassLoader {
-                    protected function configureRoute(Route $route, \ReflectionClass $class, \ReflectionMethod $method, object $annot)
+                    protected function configureRoute(Route $route, \ReflectionClass $class, \ReflectionMethod $method, object $annot): void
                     {
                         $route->setDefault('_controller', $class->getName().'::'.$method->getName());
                     }
diff --git a/src/Symfony/Component/Routing/Tests/Loader/XmlFileLoaderTest.php b/src/Symfony/Component/Routing/Tests/Loader/XmlFileLoaderTest.php
@@ -607,7 +607,7 @@ public function testImportAttributesWithPsr4Prefix(string $configFile)
             $loader = new XmlFileLoader($locator),
             new Psr4DirectoryLoader($locator),
             new class() extends AnnotationClassLoader {
-                protected function configureRoute(Route $route, \ReflectionClass $class, \ReflectionMethod $method, object $annot)
+                protected function configureRoute(Route $route, \ReflectionClass $class, \ReflectionMethod $method, object $annot): void
                 {
                     $route->setDefault('_controller', $class->getName().'::'.$method->getName());
                 }
@@ -632,7 +632,7 @@ public function testImportAttributesFromClass()
         new LoaderResolver([
             $loader = new XmlFileLoader(new FileLocator(\dirname(__DIR__).'/Fixtures')),
             new class() extends AnnotationClassLoader {
-                protected function configureRoute(Route $route, \ReflectionClass $class, \ReflectionMethod $method, object $annot)
+                protected function configureRoute(Route $route, \ReflectionClass $class, \ReflectionMethod $method, object $annot): void
                 {
                     $route->setDefault('_controller', $class->getName().'::'.$method->getName());
                 }
diff --git a/src/Symfony/Component/Routing/Tests/Loader/YamlFileLoaderTest.php b/src/Symfony/Component/Routing/Tests/Loader/YamlFileLoaderTest.php
@@ -473,7 +473,7 @@ public function testImportAttributesWithPsr4Prefix(string $configFile)
             $loader = new YamlFileLoader($locator),
             new Psr4DirectoryLoader($locator),
             new class() extends AnnotationClassLoader {
-                protected function configureRoute(Route $route, \ReflectionClass $class, \ReflectionMethod $method, object $annot)
+                protected function configureRoute(Route $route, \ReflectionClass $class, \ReflectionMethod $method, object $annot): void
                 {
                     $route->setDefault('_controller', $class->getName().'::'.$method->getName());
                 }
@@ -498,7 +498,7 @@ public function testImportAttributesFromClass()
         new LoaderResolver([
             $loader = new YamlFileLoader(new FileLocator(\dirname(__DIR__).'/Fixtures')),
             new class() extends AnnotationClassLoader {
-                protected function configureRoute(Route $route, \ReflectionClass $class, \ReflectionMethod $method, object $annot)
+                protected function configureRoute(Route $route, \ReflectionClass $class, \ReflectionMethod $method, object $annot): void
                 {
                     $route->setDefault('_controller', $class->getName().'::'.$method->getName());
                 }
diff --git a/src/Symfony/Component/Security/Core/User/InMemoryUserProvider.php b/src/Symfony/Component/Security/Core/User/InMemoryUserProvider.php
@@ -50,6 +50,8 @@ public function __construct(array $users = [])
     /**
      * Adds a new User to the provider.
      *
+     * @return void
+     *
      * @throws \LogicException
      */
     public function createUser(UserInterface $user)
diff --git a/src/Symfony/Component/Security/Http/Firewall.php b/src/Symfony/Component/Security/Http/Firewall.php
@@ -108,6 +108,9 @@ public function onKernelFinishRequest(FinishRequestEvent $event)
         }
     }
 
+    /**
+     * @return array
+     */
     public static function getSubscribedEvents()
     {
         return [
diff --git a/src/Symfony/Component/Serializer/Normalizer/AbstractObjectNormalizer.php b/src/Symfony/Component/Serializer/Normalizer/AbstractObjectNormalizer.php
@@ -139,12 +139,17 @@ public function __construct(
 
     /**
      * @param array $context
+     *
+     * @return bool
      */
     public function supportsNormalization(mixed $data, string $format = null /* , array $context = [] */)
     {
         return \is_object($data) && !$data instanceof \Traversable;
     }
 
+    /**
+     * @return array|string|int|float|bool|\ArrayObject|null
+     */
     public function normalize(mixed $object, string $format = null, array $context = [])
     {
         if (!isset($context['cache_key'])) {
@@ -226,6 +231,9 @@ public function normalize(mixed $object, string $format = null, array $context =
         return $data;
     }
 
+    /**
+     * @return object
+     */
     protected function instantiateObject(array &$data, string $class, array &$context, \ReflectionClass $reflectionClass, array|bool $allowedAttributes, string $format = null)
     {
         if ($this->classDiscriminatorResolver && $mapping = $this->classDiscriminatorResolver->getMappingForClass($class)) {
@@ -299,12 +307,17 @@ abstract protected function getAttributeValue(object $object, string $attribute,
 
     /**
      * @param array $context
+     *
+     * @return bool
      */
     public function supportsDenormalization(mixed $data, string $type, string $format = null /* , array $context = [] */)
     {
         return class_exists($type) || (interface_exists($type, false) && null !== $this->classDiscriminatorResolver?->getMappingForClass($type));
     }
 
+    /**
+     * @return mixed
+     */
     public function denormalize(mixed $data, string $type, string $format = null, array $context = [])
     {
         if (!isset($context['cache_key'])) {
@@ -408,7 +421,7 @@ public function denormalize(mixed $data, string $type, string $format = null, ar
     }
 
     /**
-     * Sets attribute value.
+     * @return void
      */
     abstract protected function setAttributeValue(object $object, string $attribute, mixed $value, string $format = null, array $context = []);
 
diff --git a/src/Symfony/Component/Translation/Catalogue/AbstractOperation.php b/src/Symfony/Component/Translation/Catalogue/AbstractOperation.php
@@ -183,6 +183,8 @@ public function moveMessagesToIntlDomainsIfPossible(string $batch = self::ALL_BA
      * stores the results.
      *
      * @param string $domain The domain which the operation will be performed for
+     *
+     * @return void
      */
     abstract protected function processDomain(string $domain);
 }
diff --git a/src/Symfony/Component/Translation/Command/XliffLintCommand.php b/src/Symfony/Component/Translation/Command/XliffLintCommand.php
diff --git a/src/Symfony/Component/Translation/Extractor/PhpExtractor.php b/src/Symfony/Component/Translation/Extractor/PhpExtractor.php
diff --git a/src/Symfony/Component/Translation/Util/ArrayConverter.php b/src/Symfony/Component/Translation/Util/ArrayConverter.php
diff --git a/src/Symfony/Component/Validator/Constraints/IsbnValidator.php b/src/Symfony/Component/Validator/Constraints/IsbnValidator.php
diff --git a/src/Symfony/Component/Validator/Exception/ValidationFailedException.php b/src/Symfony/Component/Validator/Exception/ValidationFailedException.php

Original file line number	Diff line number	Diff line change
`@@ -1732,6 +1732,9 @@ public function preferSafeContent(): bool`
`1732`	`1732`	`* Copyright (c) 2005-2010 Zend Technologies USA Inc. (https://www.zend.com/)`
`1733`	`1733`	`*/`
`1734`	`1734`
	`1735`	`+ /**`
	`1736`	`+ * @return string`
	`1737`	`+ */`
`1735`	`1738`	`protected function prepareRequestUri()`
`1736`	`1739`	`{`
`1737`	`1740`	`$requestUri = '';`
Original file line number	Diff line number	Diff line change
`@@ -34,6 +34,8 @@ final public function load(array $configs, ContainerBuilder $container): void`
`34`	`34`
`35`	`35`	`/**`
`36`	`36`	`* Configures the passed container according to the merged configuration.`
	`37`	`+ *`
	`38`	`+ * @return void`
`37`	`39`	`*/`
`38`	`40`	`abstract protected function loadInternal(array $mergedConfig, ContainerBuilder $container);`
`39`	`41`	`}`
Original file line number	Diff line number	Diff line change
`@@ -167,7 +167,7 @@ protected function loadUser(string $identifier, Entry $entry): UserInterface`
`167`	`167`	`return new LdapUser($entry, $identifier, $password, $this->defaultRoles, $extraFields);`
`168`	`168`	`}`
`169`	`169`
`170`		`- private function getAttributeValue(Entry $entry, string $attribute)`
	`170`	`+ private function getAttributeValue(Entry $entry, string $attribute): mixed`
`171`	`171`	`{`
`172`	`172`	`if (!$entry->hasAttribute($attribute)) {`
`173`	`173`	`throw new InvalidArgumentException(sprintf('Missing attribute "%s" for user "%s".', $attribute, $entry->getDn()));`
Original file line number	Diff line number	Diff line change
`@@ -199,7 +199,7 @@ private function getEndpoint(): ?string`
`199`	`199`	`return ($this->host ?: self::HOST).($this->port ? ':'.$this->port : '');`
`200`	`200`	`}`
`201`	`201`
`202`		`- private function castCustomHeader(string $value, string $type)`
	`202`	`+ private function castCustomHeader(string $value, string $type): mixed`
`203`	`203`	`{`
`204`	`204`	`return match ($type) {`
`205`	`205`	`'bool' => filter_var($value, \FILTER_VALIDATE_BOOL),`
Original file line number	Diff line number	Diff line change
`@@ -396,6 +396,9 @@ public function getBody(): AbstractPart`
`396`	`396`	`return $this->generateBody();`
`397`	`397`	`}`
`398`	`398`
	`399`	`+ /**`
	`400`	`+ * @return void`
	`401`	`+ */`
`399`	`402`	`public function ensureValidity()`
`400`	`403`	`{`
`401`	`404`	`$this->ensureBodyValid();`
Original file line number	Diff line number	Diff line change
`@@ -47,6 +47,9 @@ public function __construct(Process $process)`
`47`	`47`	`$this->process = $process;`
`48`	`48`	`}`
`49`	`49`
	`50`	`+ /**`
	`51`	`+ * @return Process`
	`52`	`+ */`
`50`	`53`	`public function getProcess()`
`51`	`54`	`{`
`52`	`55`	`return $this->process;`
Original file line number	Diff line number	Diff line change
`@@ -38,6 +38,9 @@ public function __construct(Process $process, int $timeoutType)`
`38`	`38`	`));`
`39`	`39`	`}`
`40`	`40`
	`41`	`+ /**`
	`42`	`+ * @return Process`
	`43`	`+ */`
`41`	`44`	`public function getProcess()`
`42`	`45`	`{`
`43`	`46`	`return $this->process;`
`@@ -59,7 +62,7 @@ public function isIdleTimeout()`
`59`	`62`	`return self::TYPE_IDLE === $this->timeoutType;`
`60`	`63`	`}`
`61`	`64`
`62`		`- public function getExceededTimeout()`
	`65`	`+ public function getExceededTimeout(): ?float`
`63`	`66`	`{`
`64`	`67`	`return match ($this->timeoutType) {`
`65`	`68`	`self::TYPE_GENERAL => $this->process->getTimeout(),`
Original file line number	Diff line number	Diff line change
`@@ -285,6 +285,8 @@ public function mustRun(callable $callback = null, array $env = []): static`
`285`	`285`	`* @param callable\|null $callback A PHP callback to run whenever there is some`
`286`	`286`	`* output available on STDOUT or STDERR`
`287`	`287`	`*`
	`288`	`+ * @return void`
	`289`	`+ *`
`288`	`290`	`* @throws RuntimeException When process can't be launched`
`289`	`291`	`* @throws RuntimeException When process is already running`
`290`	`292`	`* @throws LogicException In case a callback is provided and output has been disabled`
`@@ -1140,6 +1142,8 @@ public function setInput(mixed $input): static`
`1140`	`1142`	`* In case you run a background process (with the start method), you should`
`1141`	`1143`	`* trigger this method regularly to ensure the process timeout`
`1142`	`1144`	`*`
	`1145`	`+ * @return void`
	`1146`	`+ *`
`1143`	`1147`	`* @throws ProcessTimedOutException In case the timeout was reached`
`1144`	`1148`	`*/`
`1145`	`1149`	`public function checkTimeout()`
`@@ -1180,6 +1184,8 @@ public function getStartTime(): float`
`1180`	`1184`	`*`
`1181`	`1185`	`* Enabling the "create_new_console" option allows a subprocess to continue`
`1182`	`1186`	`* to run after the main process exited, on both Windows and *nix`
	`1187`	`+ *`
	`1188`	`+ * @return void`
`1183`	`1189`	`*/`
`1184`	`1190`	`public function setOptions(array $options)`
`1185`	`1191`	`{`
`@@ -1275,6 +1281,8 @@ protected function buildCallback(callable $callback = null): \Closure`
`1275`	`1281`	`* Updates the status of the process, reads pipes.`
`1276`	`1282`	`*`
`1277`	`1283`	`* @param bool $blocking Whether to use a blocking read call`
	`1284`	`+ *`
	`1285`	`+ * @return void`
`1278`	`1286`	`*/`
`1279`	`1287`	`protected function updateStatus(bool $blocking)`
`1280`	`1288`	`{`
`@@ -1323,7 +1331,7 @@ protected function isSigchildEnabled(): bool`
`1323`	`1331`	`*`
`1324`	`1332`	`* @throws LogicException in case output has been disabled or process is not started`
`1325`	`1333`	`*/`
`1326`		`- private function readPipesForOutput(string $caller, bool $blocking = false)`
	`1334`	`+ private function readPipesForOutput(string $caller, bool $blocking = false): void`
`1327`	`1335`	`{`
`1328`	`1336`	`if ($this->outputDisabled) {`
`1329`	`1337`	`throw new LogicException('Output has been disabled.');`
`@@ -1358,7 +1366,7 @@ private function validateTimeout(?float $timeout): ?float`
`1358`	`1366`	`* @param bool $blocking Whether to use blocking calls or not`
`1359`	`1367`	`* @param bool $close Whether to close file handles or not`
`1360`	`1368`	`*/`
`1361`		`- private function readPipes(bool $blocking, bool $close)`
	`1369`	`+ private function readPipes(bool $blocking, bool $close): void`
`1362`	`1370`	`{`
`1363`	`1371`	`$result = $this->processPipes->readAndWrite($blocking, $close);`
`1364`	`1372`
`@@ -1407,7 +1415,7 @@ private function close(): int`
`1407`	`1415`	`/**`
`1408`	`1416`	`* Resets data related to the latest run of the process.`
`1409`	`1417`	`*/`
`1410`		`- private function resetProcessData()`
	`1418`	`+ private function resetProcessData(): void`
`1411`	`1419`	`{`
`1412`	`1420`	`$this->starttime = null;`
`1413`	`1421`	`$this->callback = null;`
`@@ -1528,7 +1536,7 @@ function ($m) use (&$env, $uid) {`
`1528`	`1536`	`*`
`1529`	`1537`	`* @throws LogicException if the process has not run`
`1530`	`1538`	`*/`
`1531`		`- private function requireProcessIsStarted(string $functionName)`
	`1539`	`+ private function requireProcessIsStarted(string $functionName): void`
`1532`	`1540`	`{`
`1533`	`1541`	`if (!$this->isStarted()) {`
`1534`	`1542`	`throw new LogicException(sprintf('Process must be started before calling "%s()".', $functionName));`
`@@ -1540,7 +1548,7 @@ private function requireProcessIsStarted(string $functionName)`
`1540`	`1548`	`*`
`1541`	`1549`	`* @throws LogicException if the process is not yet terminated`
`1542`	`1550`	`*/`
`1543`		`- private function requireProcessIsTerminated(string $functionName)`
	`1551`	`+ private function requireProcessIsTerminated(string $functionName): void`
`1544`	`1552`	`{`
`1545`	`1553`	`if (!$this->isTerminated()) {`
`1546`	`1554`	`throw new LogicException(sprintf('Process must be terminated before calling "%s()".', $functionName));`